Skip to content

Harmonize image size checks

Philip Oberfichtner u-boot 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 7 repliesIn review
  2. v43 patches 6 repliesSuperseded
  3. v35 patches 28 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches18 repliesSuperseded
v1 RFC3 patches3 repliesSuperseded

Changes in v5 from the cover letter

- Minor style improvements

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Image size checks: Use HAS_SIZE_LIMIT consistentlyMakefile arch/arm/mach-socfpga/Kconfig arch/mips/mach-mtmips/Kconfig +35 more+68 -222 replies
2/3Image size checks: Clarify help textsKconfig common/spl/Kconfig common/spl/Kconfig.tpl +1 more+14 -141 reply
3/3Makefile: Deduplicate image size checksMakefile+13 -351 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchMarek Vasut
1/3
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] Harmonize image size checks

This patch series aims at harmonizing image size checks, which are currently represented by the following Kconfig symbols:

CONFIG_HAS_BOARD_SIZE_LIMIT
CONFIG_BOARD_SIZE_LIMIT
CONFIG_SPL_SIZE_LIMIT
CONFIG_TPL_SIZE_LIMIT
CONFIG_VPL_SIZE_LIMIT

After this series, we would have
- Consistent logic
- Consistent help texts
- Less code duplication in the toplevel Makefile

Changes in v5:
- Minor style improvements

Changes in v4:
- Minimize the number of defconfig changes
- Drop patch "Simplify SPL_SIZE_LIMIT logic"
- Drop patch "Move all configs in one place"
- Improve help texts
- Use XXX_HAS_SIZE_LIMIT in the Makefile code
- Move "default y" statements to the respective main Kconfigs

Changes in v3:
V3 is a complete remake of the series. In the discussions on V2 we decided to follow the approach of using CONFIG_HAS_XXX_SIZE_LIMIT instead of my initial proposal, which was to disable a size check by setting its limit to zero.

Changes in v2:
- Rebase on current master
- Rebase on my pending mips patch series (linked above)
- Incorporated Heinrich's Review

Philip Oberfichtner (3):
Image size checks: Use HAS_SIZE_LIMIT consistently Image size checks: Clarify help texts
Makefile: Deduplicate image size checks

 Kconfig                               | 10 +++---
 Makefile                              | 48 ++++++++-------------------
 arch/arm/mach-socfpga/Kconfig         |  6 ----
 arch/mips/mach-mtmips/Kconfig         |  3 --
 arch/x86/cpu/apollolake/Kconfig       |  3 --
 common/spl/Kconfig                    | 29 ++++++++++++----
 common/spl/Kconfig.tpl                | 15 ++++++---
 common/spl/Kconfig.vpl                | 13 +++++---
 configs/am64x_evm_r5_defconfig        |  1 +
 configs/am65x_evm_r5_defconfig        |  1 +
 configs/am65x_evm_r5_usbmsc_defconfig |  1 +
 configs/brcp150_defconfig             |  1 +
 configs/brcp170_defconfig             |  1 +
 configs/brcp1_1r_defconfig            |  1 +
 configs/brcp1_1r_switch_defconfig     |  1 +
 configs/brcp1_2r_defconfig            |  1 +
 configs/brsmarc2_defconfig            |  1 +
 configs/evb-ast2600_defconfig         |  1 +
 configs/evb-rk3288_defconfig          |  1 +
 configs/firefly-rk3288_defconfig      |  1 +
 configs/ibex-ast2700_defconfig        |  1 +
 configs/ibm-sbp1_defconfig            |  1 +
 configs/imx28_btt3_defconfig          |  1 +
 configs/imx28_xea_defconfig           |  1 +
 configs/imxrt1020-evk_defconfig       |  1 +
 configs/imxrt1050-evk_defconfig       |  1 +
 configs/imxrt1050-evk_fspi_defconfig  |  1 +
 configs/imxrt1170-evk_defconfig       |  1 +
 configs/kontron_sl28_defconfig        |  1 +
 configs/phycore_am64x_r5_defconfig    |  1 +
 configs/stm32746g-eval_spl_defconfig  |  1 +
 configs/stm32f746-disco_spl_defconfig |  1 +
 configs/stm32f769-disco_spl_defconfig |  1 +
 configs/tinker-rk3288_defconfig       |  1 +
 configs/tinker-s-rk3288_defconfig     |  1 +
 configs/verdin-am62p_a53_defconfig    |  1 +
 configs/xilinx_mbv32_defconfig        |  1 +
 configs/xilinx_zynqmp_kria_defconfig  |  1 +
 configs/xilinx_zynqmp_virt_defconfig  |  1 +
 39 files changed, 91 insertions(+), 67 deletions(-)
Signature · 1 line
2.39.5