Skip to content

thunderbolt: HMAC fix and cleanup

Eric Biggers linux-crypto linux-usb lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2thunderbolt: Compare HMAC values in constant timedrivers/thunderbolt/domain.c+2 -10 replies
2/2thunderbolt: Use HMAC-SHA256 library instead of crypto_shashdrivers/thunderbolt/Kconfig drivers/thunderbolt/domain.c+8 -400 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] thunderbolt: HMAC fix and cleanup

Patch 1 fixes the HMAC comparison in the thunderbolt driver to be constant-time.

Patch 2 simplifies the HMAC computation in the thunderbolt driver by using the library API instead of crypto_shash. Note that this depends on the HMAC-SHA256 library API that was merged for v6.17-rc1.

Eric Biggers (2):
thunderbolt: Compare HMAC values in constant time
thunderbolt: Use HMAC-SHA256 library instead of crypto_shash

 drivers/thunderbolt/Kconfig  |  4 ++--
 drivers/thunderbolt/domain.c | 45 ++++++------------------------------
 2 files changed, 9 insertions(+), 40 deletions(-)

base-commit: d6084bb815c453de27af8071a23163a711586a6c

Signature · 1 line
2.50.1