Skip to content

KEYS: trusted_tpm1: HMAC fix and cleanup

Eric Biggers keyrings linux-crypto linux-integrity lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3KEYS: trusted_tpm1: Compare HMAC values in constant timesecurity/keys/trusted-keys/trusted_tpm1.c+4 -34 replies
2/3KEYS: trusted_tpm1: Use SHA-1 library instead of crypto_shashsecurity/keys/trusted-keys/Kconfig security/keys/trusted-keys/trusted_tpm1.c+36 -1901 reply
3/3KEYS: trusted_tpm1: Move private functionality out of public headerinclude/keys/trusted_tpm.h security/keys/trusted-keys/trusted_tpm1.c+72 -873 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchJarkko Sakkinen
1/3
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] KEYS: trusted_tpm1: HMAC fix and cleanup

Patch 1 fixes the HMAC-SHA1 comparison in trusted_tpm1 to be constant-time.

Patch 2 simplifies the SHA-1 and HMAC-SHA1 computation in trusted_tpm1 by using library APIs instead of crypto_shash. Note that this depends on the SHA-1 and HMAC-SHA1 library APIs that were merged for v6.17-rc1.

Patch 3 is a trusted_tpm1 cleanup that moves private functionality out of a public header.

Eric Biggers (3):
KEYS: trusted_tpm1: Compare HMAC values in constant time
KEYS: trusted_tpm1: Use SHA-1 library instead of crypto_shash
KEYS: trusted_tpm1: Move private functionality out of public header

 include/keys/trusted_tpm.h                |  79 ------
 security/keys/trusted-keys/Kconfig        |   5 +-
 security/keys/trusted-keys/trusted_tpm1.c | 284 ++++++++--------------
 3 files changed, 100 insertions(+), 268 deletions(-)

base-commit: d6084bb815c453de27af8071a23163a711586a6c

Signature · 1 line
2.50.1