SI power management fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 21 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | drm/amdgpu: Power up UVD 3 for FW validationdrivers/ | +6 | 8 replies | |
| 2/6 | drm/amd/pm: Disable ULV even if unsupporteddrivers/ | +5 | 3 replies | |
| 3/6 | drm/radeon: Disable ULV even if unsupporteddrivers/ | +5 | 3 replies | |
| 4/6 | drm/amd/pm: Fix si_upload_smc_datadrivers/ | +19 | 6 replies | |
| 5/6 | drm/radeon: Fix si_upload_smc_datadrivers/ | +19 | 1 reply | |
| 6/6 | drm/amd/pm: Fix SI DPM issues with high pixel clockdrivers/ | +37 | 0 replies |
Reviews trailers per patch
2 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Alex Deucher |
|---|---|
| 1/6 | |
| 2/6 | A-b |
| 3/6 | A-b |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] SI power management fixes
This series fixes some power management issues on SI. Where applicable, a radeon backport is also included. I recommend backporting these commits to the stable kernel.
1. Ensure that DPM powers on the UVD for FW validation. This is necessary because SI needs to use a specific power state for UVD to work correctly, which we forgot to use for FW validation.
2. Disable ULV mode even if unsupported (+ radeon backport). Send the PPSMC_MSG_DisableULV message to the SMC even when ULV mode is not supported, to ensure that ULV mode is actually turned off. This fixes some instability on Tahiti.
3. Fix si_upload_smc_data (+ radeon backport).
The si_write_smc_soft_register return value is actually zero on success, fix checking it. This fixes an SMC hang on Tahiti.
4. Fix issues with high pixel clock displays
As we don't have something like dce_calcs for old GPUs, sadly we have to apply ad-hoc fixes. This fixes different flickering issues that I observed on Oland, Tahiti and Pitcairn.
Timur Kristóf (6):
drm/amdgpu: Power up UVD 3 for FW validation drm/amd/pm: Disable ULV even if unsupported drm/radeon: Disable ULV even if unsupported drm/amd/pm: Fix si_upload_smc_data drm/radeon: Fix si_upload_smc_data drm/amd/pm: Fix SI DPM issues with high pixel clock
drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 9 ++- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 75 ++++++++++++++++++---- drivers/gpu/drm/radeon/si_dpm.c | 38 +++++++---- 3 files changed, 91 insertions(+), 31 deletions(-)
Signature · 1 line
2.50.1