Add __attribute_const__ to ffs()-family implementations
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest17 patches 10 repliesIn review 1 of 17 applied
Patches in v1 1 of 17 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/17 | KUnit: Introduce ffs()-family testslib/ lib/ lib/ | +541 | 0 replies | |
| 2/17 | bitops: Add __attribute_const__ to generic ffs()-family implementationsinclude/ include/ include/ +7 more | +14 | 0 replies | |
| 3/17 | csky: Add __attribute_const__ to ffs()-family implementationsarch/ | +4 | 1 reply | |
| 4/17 | x86: Add __attribute_const__ to ffs()-family implementationsarch/ | +6 | 0 replies | |
| 5/17 | powerpc: Add __attribute_const__ to ffs()-family implementationsarch/ | +2 | 3 replies | |
| 6/17 | sh: Add __attribute_const__ to ffs()-family implementationsarch/ | +2 | 0 replies | |
| 7/17 | alpha: Add __attribute_const__ to ffs()-family implementationsarch/ | +7 | 0 replies | |
| 8/17 | hexagon: Add __attribute_const__ to ffs()-family implementationsarch/ | +5 | 0 replies | |
| 9/17 | riscv: Add __attribute_const__ to ffs()-family implementationsarch/ | +3 | 1 reply | Applied |
| 10/17 | openrisc: Add __attribute_const__ to ffs()-family implementationsarch/ arch/ arch/ +1 more | +4 | 1 reply | |
| 11/17 | m68k: Add __attribute_const__ to ffs()-family implementationsarch/ | +7 | 1 reply | |
| 12/17 | mips: Add __attribute_const__ to ffs()-family implementationsarch/ | +4 | 0 replies | |
| 13/17 | parisc: Add __attribute_const__ to ffs()-family implementationsarch/ | +3 | 1 reply | |
| 14/17 | s390: Add __attribute_const__ to ffs()-family implementationsarch/ | +5 | 1 reply | |
| 15/17 | xtensa: Add __attribute_const__ to ffs()-family implementationsarch/ | +5 | 0 replies | |
| 16/17 | sparc: Add __attribute_const__ to ffs()-family implementationsarch/ | +4 | 0 replies | |
| 17/17 | KUnit: ffs: Validate all the __attribute_const__ annotationslib/ | +40 | 0 replies |
Reviews trailers per patch
7 of 17 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Stafford Horne | Geert Uytterhoeven | Heiko Carstens | Madhavan Srinivasan | Alexandre Ghiti | Helge Deller | Peter Zijlstra (Intel) | Guo Ren |
|---|---|---|---|---|---|---|---|---|
| Series | A-b | |||||||
| 1/17 | ||||||||
| 2/17 | ||||||||
| 3/17 | A-b | |||||||
| 4/17 | ||||||||
| 5/17 | A-b | |||||||
| 6/17 | ||||||||
| 7/17 | ||||||||
| 8/17 | ||||||||
| 9/17 | T-b A-b | |||||||
| 10/17 | A-b | |||||||
| 11/17 | R-b A-b | |||||||
| 12/17 | ||||||||
| 13/17 | A-b | |||||||
| 14/17 | A-b | |||||||
| 15/17 | ||||||||
| 16/17 | ||||||||
| 17/17 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.
Cover letter [PATCH 00/17] Add __attribute_const__ to ffs()-family implementations
Hi,
While tracking down a problem where constant expressions used by BUILD_BUG_ON() suddenly stopped working[1], we found that an added static initializer was convincing the compiler that it couldn't track the state of the prior statically initialized value. Tracing this down found that ffs() was used in the initializer macro, but since it wasn't marked with __attribute_const__, the compiler had to assume the function might change variable states as a side-effect (which is not true for ffs(), which provides deterministic math results).
Add KUnit tests for the family of functions and then add __attribute_const__ to all architecture implementations and wrappers.
-Kees
[1] https://github.com/KSPP/linux/issues/364
Kees Cook (17):
KUnit: Introduce ffs()-family tests
bitops: Add __attribute_const__ to generic ffs()-family
implementations
csky: Add __attribute_const__ to ffs()-family implementations
x86: Add __attribute_const__ to ffs()-family implementations
powerpc: Add __attribute_const__ to ffs()-family implementations
sh: Add __attribute_const__ to ffs()-family implementations
alpha: Add __attribute_const__ to ffs()-family implementations
hexagon: Add __attribute_const__ to ffs()-family implementations
riscv: Add __attribute_const__ to ffs()-family implementations
openrisc: Add __attribute_const__ to ffs()-family implementations
m68k: Add __attribute_const__ to ffs()-family implementations
mips: Add __attribute_const__ to ffs()-family implementations
parisc: Add __attribute_const__ to ffs()-family implementations
s390: Add __attribute_const__ to ffs()-family implementations
xtensa: Add __attribute_const__ to ffs()-family implementations
sparc: Add __attribute_const__ to ffs()-family implementations
KUnit: ffs: Validate all the __attribute_const__ annotations
lib/Kconfig.debug | 14 + lib/tests/Makefile | 1 + arch/alpha/include/asm/bitops.h | 14 +- arch/csky/include/asm/bitops.h | 8 +- arch/hexagon/include/asm/bitops.h | 10 +- arch/m68k/include/asm/bitops.h | 14 +- arch/mips/include/asm/bitops.h | 8 +- arch/openrisc/include/asm/bitops/__ffs.h | 2 +- arch/openrisc/include/asm/bitops/__fls.h | 2 +- arch/openrisc/include/asm/bitops/ffs.h | 2 +- arch/openrisc/include/asm/bitops/fls.h | 2 +- arch/parisc/include/asm/bitops.h | 6 +- arch/powerpc/include/asm/bitops.h | 4 +- arch/riscv/include/asm/bitops.h | 6 +- arch/s390/include/asm/bitops.h | 10 +- arch/sh/include/asm/bitops.h | 4 +- arch/sparc/include/asm/bitops_64.h | 8 +- arch/x86/include/asm/bitops.h | 12 +- arch/xtensa/include/asm/bitops.h | 10 +- include/asm-generic/bitops/__ffs.h | 2 +- include/asm-generic/bitops/__fls.h | 2 +- include/asm-generic/bitops/builtin-__ffs.h | 2 +- include/asm-generic/bitops/builtin-__fls.h | 2 +- include/asm-generic/bitops/builtin-fls.h | 2 +- include/asm-generic/bitops/ffs.h | 2 +- include/asm-generic/bitops/fls.h | 2 +- include/asm-generic/bitops/fls64.h | 4 +- include/linux/bitops.h | 2 +- lib/clz_ctz.c | 8 +- lib/tests/ffs_kunit.c | 566 +++++++++++++++++++++ 30 files changed, 656 insertions(+), 75 deletions(-) create mode 100644 lib/tests/ffs_kunit.c
Signature · 1 line
2.34.1