Skip to content

perf/s390: Regression: Move uid filtering to BPF filters

Ilya Leoshkevich bpf linux-perf-users linux-s390 lkml 3 versions – Applied

Status from this message: This series was applied to bpf/bpf.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 0 repliesApplied 2/2
  2. v42 patches 4 repliesSuperseded
  3. v32 patches 6 repliesSuperseded

Patches in v5 All 2 applied

#Subject and filesSizeRepliesApplied
1/2libbpf: Add the ability to suppress perf event enablementtools/lib/bpf/libbpf.c tools/lib/bpf/libbpf.h+11 -60 repliesApplied
2/2perf bpf-filter: Enable events manuallytools/perf/util/bpf-filter.c+4 -10 repliesApplied

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchEduard ZingermanThomas Richter
1/2A-b T-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] perf/s390: Regression: Move uid filtering to BPF filters

v4: https://lore.kernel.org/bpf/[email protected]/
v4 -> v5: Fix a typo in the commit message (Yonghong).

v3: https://lore.kernel.org/bpf/[email protected]/
v3 -> v4: Rename the new field to dont_enable (Alexei, Eduard).
Switch the Fixes: tag in patch 2 (Alexander, Thomas). Fix typos in the cover letter (Thomas).

v2: https://lore.kernel.org/bpf/[email protected]/
v2 -> v3: Use no_ioctl_enable in perf.

v1: https://lore.kernel.org/bpf/[email protected]/
v1 -> v2: Introduce no_ioctl_enable (Jiri).

Hi,

This series fixes a regression caused by moving UID filtering to BPF. The regression affects all events that support auxiliary data, most notably, "cycles" events on s390, but also PT events on Intel. The symptom is missing events when UID filtering is enabled.

Patch 1 introduces a new option for the bpf_program__attach_perf_event_opts() function.
Patch 2 makes use of it in perf, and also contains a lot of technical details of why exactly the problem is occurring.

Thanks to Thomas Richter for the investigation and the initial version of this fix, and to Jiri Olsa for suggestions.

Best regards,
Ilya

Ilya Leoshkevich (2):
libbpf: Add the ability to suppress perf event enablement perf bpf-filter: Enable events manually

 tools/lib/bpf/libbpf.c       | 13 ++++++++-----
 tools/lib/bpf/libbpf.h       |  4 +++-
 tools/perf/util/bpf-filter.c |  5 ++++-
 3 files changed, 15 insertions(+), 7 deletions(-)
Signature · 1 line
2.50.1