Skip to content

net/ceph/messenger: micro-optimizations for out_msg

Max Kellermann ceph-devel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net/ceph/messenger: ceph_con_get_out_msg() returns the message pointerinclude/linux/ceph/messenger.h net/ceph/messenger.c net/ceph/messenger_v1.c+4 -52 replies
2/3net/ceph/messenger_v[12]: pass ceph_msg* instead of loading con->out_msginclude/linux/ceph/messenger.h net/ceph/messenger.c net/ceph/messenger_v1.c +1 more+102 -1072 replies
3/3net/ceph/messenger: add empty check to ceph_con_get_out_msg()net/ceph/messenger.c net/ceph/messenger_v1.c net/ceph/messenger_v2.c+15 -85 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchViacheslav Dubeyko
1/3R-b T-b
2/3R-b T-b
3/3R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] net/ceph/messenger: micro-optimizations for out_msg

These patches reduce reloads of con->out_msg by passing pointers that we already have in local variables (i.e. registers) as parameters.

Access to con->out_queue is now gone completely from v1/v2 and only few references to con->out_msg remain. In the long run, I'd like to get rid of con->out_msg completely and instead send the whole con->out_queue in one kernel_sendmsg() call. This patch series helps with preparing that.

Max Kellermann (3):
net/ceph/messenger: ceph_con_get_out_msg() returns the message pointer net/ceph/messenger_v[12]: pass ceph_msg* instead of loading

    con->out_msg

net/ceph/messenger: add empty check to ceph_con_get_out_msg()

 include/linux/ceph/messenger.h |   6 +-
 net/ceph/messenger.c           |  12 +--
 net/ceph/messenger_v1.c        |  59 ++++++------
 net/ceph/messenger_v2.c        | 160 ++++++++++++++++-----------------
 4 files changed, 119 insertions(+), 118 deletions(-)
Signature · 1 line
2.47.2