Enable Shadow Stack Virtualization for SVM
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 6 repliesIn review
- v35 patches 7 repliesSuperseded
Changes in v4 from the cover letter
- Rebased on v13 of the Intel CET Virtualization series.
- Add SEV-ES save area fields to dump_vmcb.
- Don't pass through MSR_IA32_INT_SSP_TAB.
- Don't remove clearing of IBT capability.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | KVM: x86: SVM: Emulate reads and writes to shadow stack MSRsarch/ | +18 | 1 reply | |
| 2/5 | KVM: x86: SVM: Update dump_vmcb with shadow stack save area additionsarch/ | +11 | 0 replies | |
| 3/5 | KVM: x86: SVM: Pass through shadow stack MSRsarch/ | +11 | 0 replies | |
| 4/5 | KVM: SVM: Add MSR_IA32_XSS to the GHCB for hypervisor kernelarch/ arch/ | +6 | 2 replies | |
| 5/5 | KVM: SVM: Enable shadow stack virtualization for SVMarch/ | +0 | 0 replies |
Reviews trailers per patch
3 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Maxim Levitsky | Chao Gao |
|---|---|---|
| 1/5 | ||
| 2/5 | R-b | |
| 3/5 | R-b | |
| 4/5 | ||
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/5] Enable Shadow Stack Virtualization for SVM
AMD Zen3 and newer processors support shadow stack, a feature designed to protect against ROP (return-oriented programming) attacks in which an attacker manipulates return addresses on the call stack in order to execute arbitrary code. To prevent this, shadow stacks can be allocated that are only used by control transfer and return instructions. When a CALL instruction is issued, it writes the return address to both the program stack and the shadow stack. When the subsequent RET instruction is issued, it pops the return address from both stacks and compares them. If the addresses don't match, a control-protection exception is raised.
Shadow stack and a related feature, Indirect Branch Tracking (IBT), are collectively referred to as Control-flow Enforcement Technology (CET). However, current AMD processors only support shadow stack and not IBT.
This series adds support for shadow stack in SVM guests and builds upon the support added in the CET guest support patch series [1]. Additional patches are required to support shadow stack enabled guests in qemu [2].
[1]: CET guest support patches (v13)
https://lore.kernel.org/all/[email protected]/
[2]: CET qemu patches
https://lore.kernel.org/all/[email protected]/
[3]: Previous SVM support patches (v3)
https://lore.kernel.org/all/[email protected]/
---
RFC v2:
- Rebased on v3 of the Intel CET virtualization series, dropping the patch that moved cet_is_msr_accessible to common code as that has been pulled into the Intel series.
- Minor change removing curly brackets around if statement introduced
in patch 6/6.
RFC v3:
- Rebased on v5 of the Intel CET virtualization series.
- Add patch changing the name of vmplX_ssp SEV-ES save area fields to plX_ssp.
- Merge this series intended for KVM with the separate guest kernel
patch (now patch 7/8).
- Update MSR passthrough code to conditionally pass through shadow stack MSRS based on both host and guest support.
- Don't save PL0_SSP, PL1_SSP, and PL2_SSP MSRs on SEV-ES VMRUN as these are currently unused.
v1:
- Remove RFC tag from series
- Rebase on v6 of the Intel CET virtualization series
- Use KVM-governed feature to track SHSTK for SVM
v2:
- Add new patch renaming boot_*msr to raw_*msr. Utilize raw_rdmsr when reading XSS on SEV-ES cpuid instructions.
- Omit unnecessary patch for saving shadow stack msrs on SEV-ES VMRUN
- Omit passing through of XSS for SEV-ES as support has already been properly implemented in a26b7cd22546 ("KVM: SEV: Do not intercept accesses to MSR_IA32_XSS for SEV-ES guests")
v3:
- Rebased on v11 of the Intel CET Virtualization series.
- Split guest kernel patches into a separate series as these are independent of this series and are needed to support non-KVM hypervisors.
v4:
- Rebased on v13 of the Intel CET Virtualization series.
- Add SEV-ES save area fields to dump_vmcb.
- Don't pass through MSR_IA32_INT_SSP_TAB.
- Don't remove clearing of IBT capability.
John Allen (5):
KVM: x86: SVM: Emulate reads and writes to shadow stack MSRs
KVM: x86: SVM: Update dump_vmcb with shadow stack save area additions
KVM: x86: SVM: Pass through shadow stack MSRs
KVM: SVM: Add MSR_IA32_XSS to the GHCB for hypervisor kernel
KVM: SVM: Enable shadow stack virtualization for SVM
arch/x86/kvm/svm/sev.c | 5 +++++ arch/x86/kvm/svm/svm.c | 43 +++++++++++++++++++++++++++++++++++++++--- arch/x86/kvm/svm/svm.h | 1 + 3 files changed, 46 insertions(+), 3 deletions(-)
Signature · 1 line
2.47.3