Skip to content

Add TLB invalidation abstraction

stuartsummers intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/xe: Move explicit CT lock in TLB invalidation sequencedrivers/gpu/drm/xe/xe_gt_tlb_invalidation.c+2 -63 replies
2/8drm/xe: s/tlb_invalidation/tlb_invaldrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_device_types.h drivers/gpu/drm/xe/xe_exec_queue.c +17 more+255 -2660 replies
3/8drm/xe: Add xe_tlb_inval structuredrivers/gpu/drm/xe/xe_gt_tlb_inval_types.h drivers/gpu/drm/xe/xe_gt_types.h+34 -290 replies
4/8drm/xe: Add xe_gt_tlb_invalidation_done_handlerdrivers/gpu/drm/xe/xe_gt_tlb_inval.c+30 -170 replies
5/8drm/xe: Decouple TLB invalidations from GTdrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_gt.c +15 more+329 -3040 replies
6/8drm/xe: Prep TLB invalidation fence before sendingdrivers/gpu/drm/xe/xe_tlb_inval.c+51 -520 replies
7/8drm/xe: Add helpers to send TLB invalidationsdrivers/gpu/drm/xe/xe_tlb_inval.c+115 -1150 replies
8/8drm/xe: Split TLB invalidation code in frontend and backenddrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_guc_ct.c drivers/gpu/drm/xe/xe_guc_tlb_inval.c +4 more+470 -3530 replies

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchStuart Summers
1/8
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] Add TLB invalidation abstraction

This is a new collection of patches from Matt that has been floating around internally and on the mailing list. The goal here is to abstract the actual mechanism of the invalidation from the higher level invalidation triggers (like page table updates).

Most of these were brought in unmodified by Matt, but I've done some minor rebase work here and there and added my signoff where those rebases seemed a little more extensive.

Tested on BMG locally.

v3: Minor spelling fixes and added R-B's per updates on
on the mailing list
v2: Start the series with a new patch to drop the
explicit CT lock (Matt)
Pull in the remaining patches from [1]

[1] https://patchwork.freedesktop.org/series/151670/#rev1

Matthew Brost (7):
drm/xe: s/tlb_invalidation/tlb_inval
drm/xe: Add xe_tlb_inval structure
drm/xe: Add xe_gt_tlb_invalidation_done_handler drm/xe: Decouple TLB invalidations from GT drm/xe: Prep TLB invalidation fence before sending drm/xe: Add helpers to send TLB invalidations drm/xe: Split TLB invalidation code in frontend and backend

stuartsummers (1):
drm/xe: Move explicit CT lock in TLB invalidation sequence

 drivers/gpu/drm/xe/Makefile                   |   5 +-
 drivers/gpu/drm/xe/xe_device_types.h          |   4 +-
 drivers/gpu/drm/xe/xe_exec_queue.c            |   2 +-
 drivers/gpu/drm/xe/xe_ggtt.c                  |   4 +-
 drivers/gpu/drm/xe/xe_gt.c                    |   8 +-
 drivers/gpu/drm/xe/xe_gt_pagefault.c          |   1 -
 drivers/gpu/drm/xe/xe_gt_tlb_inval_job.h      |  34 -
 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c   | 604 ------------------
 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.h   |  40 --
 .../gpu/drm/xe/xe_gt_tlb_invalidation_types.h |  32 -
 drivers/gpu/drm/xe/xe_gt_types.h              |  33 +-
 drivers/gpu/drm/xe/xe_guc_ct.c                |   8 +-
 drivers/gpu/drm/xe/xe_guc_tlb_inval.c         | 242 +++++++
 drivers/gpu/drm/xe/xe_guc_tlb_inval.h         |  19 +
 drivers/gpu/drm/xe/xe_lmtt.c                  |  12 +-
 drivers/gpu/drm/xe/xe_migrate.h               |  10 +-
 drivers/gpu/drm/xe/xe_pci.c                   |   6 +-
 drivers/gpu/drm/xe/xe_pci_types.h             |   2 +-
 drivers/gpu/drm/xe/xe_pt.c                    |  63 +-
 drivers/gpu/drm/xe/xe_svm.c                   |   3 +-
 drivers/gpu/drm/xe/xe_tlb_inval.c             | 407 ++++++++++++
 drivers/gpu/drm/xe/xe_tlb_inval.h             |  46 ++
 ..._gt_tlb_inval_job.c => xe_tlb_inval_job.c} | 154 +++--
 drivers/gpu/drm/xe/xe_tlb_inval_job.h         |  33 +
 drivers/gpu/drm/xe/xe_tlb_inval_types.h       | 128 ++++
 drivers/gpu/drm/xe/xe_trace.h                 |  24 +-
 drivers/gpu/drm/xe/xe_vm.c                    |  66 +-
 drivers/gpu/drm/xe/xe_vm.h                    |   4 +-
 28 files changed, 1069 insertions(+), 925 deletions(-)
 delete mode 100644 drivers/gpu/drm/xe/xe_gt_tlb_inval_job.h
 delete mode 100644 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
 delete mode 100644 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.h
 delete mode 100644 drivers/gpu/drm/xe/xe_gt_tlb_invalidation_types.h
 create mode 100644 drivers/gpu/drm/xe/xe_guc_tlb_inval.c
 create mode 100644 drivers/gpu/drm/xe/xe_guc_tlb_inval.h
 create mode 100644 drivers/gpu/drm/xe/xe_tlb_inval.c
 create mode 100644 drivers/gpu/drm/xe/xe_tlb_inval.h
 rename drivers/gpu/drm/xe/{xe_gt_tlb_inval_job.c => xe_tlb_inval_job.c} (50%)
 create mode 100644 drivers/gpu/drm/xe/xe_tlb_inval_job.h
 create mode 100644 drivers/gpu/drm/xe/xe_tlb_inval_types.h
Signature · 1 line
2.34.1