irqchip/sg2042-msi: Fix broken affinity setting
Status from this message: The following commit has been merged into the irq/core branch of tip:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 12 repliesApplied
- v14 patches 12 repliesSuperseded
Changes in v2 from the cover letter
1. patch 1: Fix comment format problem, and structure the changelog.
2. patch 2: Improve the comment title and body, add describtion about the fact the PLIC is used as parent chip.
3. patch 2: Remove __always_inline for cond_[shutdown/startup]_parent().
4. patch 3: Update the align of the "XXX_MSI_FLAGS_XXX" macro.
5. patch 4: Claim the fact that the added flag is used by the negotiation of MSI controller driver and PCIe device driver, and can be only used when both of them support this flag.
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | genirq: Add irq_chip_(startup/shutdown)_parent()include/ kernel/ | +39 | 0 replies | |
| 2/4 | PCI/MSI: Add startup/shutdown for per device domainsdrivers/ include/ | +54 | 14 replies | |
| 3/4 | irqchip/sg2042-msi: Fix broken affinity settingdrivers/ | +13 | 0 replies | |
| 4/4 | irqchip/sg2042-msi: Set MSI_FLAG_MULTI_PCI_MSI flags for SG2044drivers/ | +1 | 0 replies |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Bjorn Helgaas | Chen Wang | Nathan Chancellor | Linux Kernel Functional Testing |
|---|---|---|---|---|
| Series | R-b T-b | |||
| 1/4 | ||||
| 2/4 | A-b | T-b | T-b | |
| 3/4 | ||||
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v2 0/4] irqchip/sg2042-msi: Fix broken affinity setting
When using NVME on SG2044, the NVME always complains "I/O tag XXX (XXX) QID XX timeout, completion polled", which is caused by the broken handler of the sg2042-msi driver.
As PLIC driver can only setting affinity when enabling, the sg2042-msi does not properly handled affinity setting previously and enable irq in an unexpected executing path.
Add irq_startup/irq_shutdown support to the PCI template domain, then set irq_chip_[startup/shutdown]_parent for irq_startup/ irq_shutdown of the sg2042-msi driver. So the irq can be started properly.
Change from v1:
1. patch 1: Fix comment format problem, and structure the changelog.
2. patch 2: Improve the comment title and body, add describtion about the fact the PLIC is used as parent chip.
3. patch 2: Remove __always_inline for cond_[shutdown/startup]_parent().
4. patch 3: Update the align of the "XXX_MSI_FLAGS_XXX" macro.
5. patch 4: Claim the fact that the added flag is used by the negotiation of MSI controller driver and PCIe device driver, and can be only used when both of them support this flag.
Inochi Amaoto (4):
genirq: Add irq_chip_(startup/shutdown)_parent() PCI/MSI: Add startup/shutdown for per device domains irqchip/sg2042-msi: Fix broken affinity setting irqchip/sg2042-msi: Set MSI_FLAG_MULTI_PCI_MSI flags for SG2044
drivers/irqchip/irq-sg2042-msi.c | 19 +++++++++--- drivers/pci/msi/irqdomain.c | 52 ++++++++++++++++++++++++++++++++ include/linux/irq.h | 2 ++ include/linux/msi.h | 2 ++ kernel/irq/chip.c | 37 +++++++++++++++++++++++ 5 files changed, 107 insertions(+), 5 deletions(-)
--
2.50.1