Skip to content

hw/sd/ssi-sd: Return noise (dummy byte) when no card connected

Philippe Mathieu-Daudé qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/23 patches 6 repliesIn review
  2. v2 posting 1/22 of 3 patches 0 repliesSuperseded
  3. v12 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Reworded patch #1 description (Alex)
- Removed '_' test method prefix (Alex)

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/sd/ssi-sd: Return noise (dummy byte) when no card connectedhw/sd/ssi-sd.c+4 -01 reply
2/3tests/functional: Test SPI-SD adapter without SD card connectedtests/functional/test_riscv64_sifive_u.py+17 -52 replies
3/3hw/ssi: Document ssi_transfer() methodinclude/hw/ssi/ssi.h+14 -02 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchGuenter RoeckAlex BennéeGustavo Romero
1/3T-b R-b R-b
2/3Inspired-by R-b T-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH-for-10.1 RESEND RESEND v2 0/3] hw/sd/ssi-sd: Return noise (dummy byte) when no card connected

Trivial fix for the issue reported by Guenter here:
https://lore.kernel.org/qemu-devel/[email protected]/

- Return dummy byte when no card is connected
- Add a test
- Document ssi_transfer()

Since v1:
- Reworded patch #1 description (Alex)
- Removed '_' test method prefix (Alex)

Philippe Mathieu-Daudé (3):
hw/sd/ssi-sd: Return noise (dummy byte) when no card connected tests/functional: Test SPI-SD adapter without SD card connected hw/ssi: Document ssi_transfer() method

 include/hw/ssi/ssi.h                      | 14 ++++++++++++++
 hw/sd/ssi-sd.c                            |  4 ++++
 tests/functional/test_riscv64_sifive_u.py | 22 +++++++++++++++++-----
 3 files changed, 35 insertions(+), 5 deletions(-)
Signature · 1 line
2.49.0