Skip to content

arm64: dts: qcom: Add PCIe Support for sm8750

Krishna Chaitanya Chundru linux-arm-msm linux-devicetree linux-pci linux-phy lkml 3 versions – Applied

Status from this message: Applied patches 1 and 3, thanks!

Get series with b4
b4 am [email protected] change-id 20250809-pakala-25a7c1ddba85

Versions newest first

  1. v3 Latest3 patches 13 repliesApplied
  2. v23 patches 10 repliesSuperseded
  3. v14 patches 6 repliesApplied

Changes in v3 from the cover letter

- Use device_type to find pci node or not instead of node name.
- Link to v2: https://lore.kernel.org/r/[email protected]

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3dt-bindings: PCI: qcom,pcie-sm8550: Add SM8750 compatibleDocumentation/devicetree/bindings/pci/qcom,pcie-sm8550.yaml+1 -00 replies
2/3arm64: dts: qcom: sm8750: Add PCIe PHY and controller nodearch/arm64/boot/dts/qcom/sm8750.dtsi+179 -110 replies
3/3PCI: qcom: Restrict port parsing only to pci child nodesdrivers/pci/controller/dwc/pcie-qcom.c+2 -00 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchRob Herring (Arm)
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] arm64: dts: qcom: Add PCIe Support for sm8750

Describe PCIe controller and PHY. Also add required system resources like regulators, clocks, interrupts and registers configuration for PCIe.

The qcom_pcie_parse_ports() function currently iterates over all available child nodes of the PCIe controller's device tree node. This includes unrelated nodes such as OPP (Operating Performance Points) nodes, which do not contain the expected 'reset' and 'phy' properties. As a result, parsing fails and the driver falls back to the legacy method of parsing the controller node directly. However, this fallback also fails when properties are shifted to the root port, leading to probe failure.

Fix this by restricting the parsing logic to only consider child nodes with device_type = "pci", which is the expected and required property for PCIe ports as defined in pci-bus-common.yaml.

---
Changes in v3:
- Use device_type to find pci node or not instead of node name.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Follow the x1e80100.dtsi pcie node description (Konrad).
- define phy & perst, wake in port node as per latest bindings.
- Add check in the driver to parse only pcie child nodes.
- Added acked by tag(Rob).
- Removed dtbinding and phy driver patches as they got applied.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Krishna Chaitanya Chundru (3):
dt-bindings: PCI: qcom,pcie-sm8550: Add SM8750 compatible
arm64: dts: qcom: sm8750: Add PCIe PHY and controller node
PCI: qcom: Restrict port parsing only to pci child nodes

 .../devicetree/bindings/pci/qcom,pcie-sm8550.yaml  |   1 +
 arch/arm64/boot/dts/qcom/sm8750.dtsi               | 180 ++++++++++++++++++++-
 drivers/pci/controller/dwc/pcie-qcom.c             |   2 +
 3 files changed, 182 insertions(+), 1 deletion(-)

---
base-commit: b6add54ba61890450fa54fd9327d10fdfd653439
change-id: 20250809-pakala-25a7c1ddba85

Best regards,

Signature · 1 line
Krishna Chaitanya Chundru <[email protected]>