Skip to content

devlink port attr cleanup

Parav Pandit netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesApplied 2/2
  2. v12 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Addressed comments from Jakub and Vadim
- changed patch order
- replaced dl_port_attrs to attrs that matches implementation API declaration

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2devlink/port: Simplify return checksnet/devlink/port.c+6 -230 repliesApplied
2/2devlink/port: Check attributes early and constifyinclude/net/devlink.h net/devlink/port.c+3 -30 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJiri Pirko
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/2] devlink port attr cleanup

Hi,

This two small patches simplifies the devlink port attributes set functions.

Summary:
patch-1 removes the return 0 check at several places and simplfies patch-2 constifies the attributes and moves the checks early caller

Please review.

changelog:
v1->v2:
- Addressed comments from Jakub and Vadim
- changed patch order
- replaced dl_port_attrs to attrs that matches implementation API declaration

Parav Pandit (2):
devlink/port: Simplify return checks devlink/port: Check attributes early and constify

 include/net/devlink.h |  2 +-
 net/devlink/port.c    | 33 ++++++++-------------------------
 2 files changed, 9 insertions(+), 26 deletions(-)
Signature · 1 line
2.26.2