Skip to content

scsi: pm80xx: Fix expander support

Niklas Cassel linux-scsi 2 versions – Applied

Status from this message: Applied to 6.18/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 23 repliesApplied
  2. v15 patches 8 repliesSuperseded

Changes in v2 from the cover letter

-Addressed Damien's review comments.
-Picked up tags from Igor. Did not pick up tags on patches that were
changed.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/10scsi: pm80xx: Restore support for expandersdrivers/scsi/pm8001/pm8001_sas.c+2 -31 reply
2/10scsi: pm80xx: Fix array-index-out-of-of-bounds on rmmoddrivers/scsi/pm8001/pm8001_sas.c+8 -11 reply
3/10scsi: libsas: Add dev_parent_is_expander() helperdrivers/scsi/libsas/sas_expander.c include/scsi/libsas.h+9 -44 replies
4/10scsi: hisi_sas: Use dev_parent_is_expander() helperdrivers/scsi/hisi_sas/hisi_sas_main.c drivers/scsi/hisi_sas/hisi_sas_v2_hw.c drivers/scsi/hisi_sas/hisi_sas_v3_hw.c+5 -92 replies
5/10scsi: isci: Use dev_parent_is_expander() helperdrivers/scsi/isci/remote_device.c+1 -12 replies
6/10scsi: mvsas: Use dev_parent_is_expander() helperdrivers/scsi/mvsas/mv_sas.c+1 -12 replies
7/10scsi: pm80xx: Use dev_parent_is_expander() helperdrivers/scsi/pm8001/pm8001_hwi.c drivers/scsi/pm8001/pm8001_sas.c drivers/scsi/pm8001/pm80xx_hwi.c+8 -134 replies
8/10scsi: pm80xx: Add helper function to get the local phy iddrivers/scsi/pm8001/pm8001_hwi.c drivers/scsi/pm8001/pm8001_sas.c drivers/scsi/pm8001/pm8001_sas.h +1 more+16 -81 reply
9/10scsi: pm80xx: Fix pm8001_abort_task() for chip_8006 when using an expanderdrivers/scsi/pm8001/pm8001_sas.c+3 -31 reply
10/10scsi: pm80xx: Use pm80xx_get_local_phy_id() to access phy arraydrivers/scsi/pm8001/pm8001_sas.c+5 -23 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchIgor PylypivDamien Le MoalJohn GarryJason YanJack Wang
1/10R-b R-b T-b
2/10R-b R-b T-b
3/10R-b R-b R-b
4/10R-b R-b
5/10R-b R-b
6/10R-b R-b
7/10R-b R-b R-b A-b
8/10R-b
9/10R-b R-b
10/10R-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/10] scsi: pm80xx: Fix expander support

Hello all,

Some recent patches broke expander support for the pm80xx driver.

The first two patches in this series make sure that expanders work with the pm80xx driver again.

It also fixes a bug in pm8001_abort_task() that was found through code review.

There is also some patches that make the pm80xx driver more robust, so it is less likely that the expander support will break again in the future.

There is also some minor changes to some other libsas drivers to make use of the new dev_parent_is_expander() helper.

Please test and review.

Kind regards,
Niklas

Changes since V1:
-Addressed Damien's review comments.
-Picked up tags from Igor. Did not pick up tags on patches that were
changed.

Niklas Cassel (10):
scsi: pm80xx: Restore support for expanders
scsi: pm80xx: Fix array-index-out-of-of-bounds on rmmod
scsi: libsas: Add dev_parent_is_expander() helper
scsi: hisi_sas: Use dev_parent_is_expander() helper
scsi: isci: Use dev_parent_is_expander() helper
scsi: mvsas: Use dev_parent_is_expander() helper
scsi: pm80xx: Use dev_parent_is_expander() helper
scsi: pm80xx: Add helper function to get the local phy id
scsi: pm80xx: Fix pm8001_abort_task() for chip_8006 when using an
expander
scsi: pm80xx: Use pm80xx_get_local_phy_id() to access phy array

 drivers/scsi/hisi_sas/hisi_sas_main.c  |  2 +-
 drivers/scsi/hisi_sas/hisi_sas_v2_hw.c |  6 ++---
 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c |  6 ++---
 drivers/scsi/isci/remote_device.c      |  2 +-
 drivers/scsi/libsas/sas_expander.c     |  5 +---
 drivers/scsi/mvsas/mv_sas.c            |  2 +-
 drivers/scsi/pm8001/pm8001_hwi.c       | 11 +++------
 drivers/scsi/pm8001/pm8001_sas.c       | 34 ++++++++++++++++++++------
 drivers/scsi/pm8001/pm8001_sas.h       |  1 +
 drivers/scsi/pm8001/pm80xx_hwi.c       | 10 +++-----
 include/scsi/libsas.h                  |  8 ++++++
 11 files changed, 50 insertions(+), 37 deletions(-)
Signature · 1 line
2.50.1