Skip to content

tty: use lock, rpm, and free guards

Jiri Slaby (SUSE) linux-mm linux-s390 linux-serial lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16console: introduce console_lock guard()sinclude/linux/console.h+2 -00 replies
2/16tty: introduce tty_port_tty guard()include/linux/tty_port.h+14 -00 replies
3/16serial: introduce uart_port_lock() guard()sinclude/linux/serial_core.h+13 -00 replies
4/16serial: 8250: introduce RPM guard()sdrivers/tty/serial/8250/8250.h drivers/tty/serial/8250/8250_port.c+9 -20 replies
5/16tty: tty_port: use guard()sdrivers/tty/tty_port.c+74 -940 replies
6/16mxser: use tty_port_tty guard() in mxser_port_isr()drivers/tty/mxser.c+29 -330 replies
7/16mxser: use guard()sdrivers/tty/mxser.c+74 -1230 replies
8/16serial: serial_core: use guard()sdrivers/tty/serial/serial_core.c+59 -840 replies
9/16serial: 8250: use guard()sdrivers/tty/serial/8250/8250_core.c drivers/tty/serial/8250/8250_port.c+143 -2200 replies
10/16serial: 8250_core: use guard() in serial_unlink_irq_chain()drivers/tty/serial/8250/8250_core.c+11 -90 replies
11/16serial: 8250_omap: extract omap_8250_set_termios_atomic()drivers/tty/serial/8250/8250_omap.c+24 -150 replies
12/16serial: 8250_omap: use guard()sdrivers/tty/serial/8250/8250_omap.c+37 -710 replies
13/16serial: 8250_rsa: use guard()sdrivers/tty/serial/8250/8250_rsa.c+3 -40 replies
14/16tty/vt: use guard()s in con_font_set/get() and con_{set,get}_unimap()drivers/tty/vt/consolemap.c drivers/tty/vt/vt.c+78 -950 replies
15/16tty/vt: use guard()sdrivers/tty/vt/consolemap.c drivers/tty/vt/selection.c drivers/tty/vt/vc_screen.c +2 more+170 -2440 replies
16/16s390/char/con3270: use tty_port_tty guard()drivers/s390/char/con3270.c+8 -101 reply

Reviews trailers per patch

1 of 16 patches has a Reviewed-by or Acked-by.

PatchHeiko Carstens
1/16
2/16
3/16
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/16] tty: use lock, rpm, and free guards

The first 4 patches introduce guards for:
* console_lock/console_unlock
* tty_port_tty_get/tty_kref_put
* uart_port_lock/uart_port_unlock in all its variants (_irq, _irqsave, _try)
* serial8250_rpm_get/serial8250_rpm_put

"tty/vt: use guard()s" also introduces a local free_page_ptr guard for __get_free_page/free_page (with proper casts). This could be made public in include/.

The rest of patches make uses all those guards across the tty code.

Jiri Slaby (SUSE) (16):
console: introduce console_lock guard()s
tty: introduce tty_port_tty guard()
serial: introduce uart_port_lock() guard()s
serial: 8250: introduce RPM guard()s
tty: tty_port: use guard()s
mxser: use tty_port_tty guard() in mxser_port_isr()
mxser: use guard()s
serial: serial_core: use guard()s
serial: 8250: use guard()s
serial: 8250_core: use guard() in serial_unlink_irq_chain()
serial: 8250_omap: extract omap_8250_set_termios_atomic()
serial: 8250_omap: use guard()s
serial: 8250_rsa: use guard()s
tty/vt: use guard()s in con_font_set/get() and con_{set,get}_unimap() tty/vt: use guard()s
s390/char/con3270: use tty_port_tty guard()

 drivers/s390/char/con3270.c         |  18 +-
 drivers/tty/mxser.c                 | 259 ++++++++++--------------
 drivers/tty/serial/8250/8250.h      |   5 +
 drivers/tty/serial/8250/8250_core.c |  91 ++++-----
 drivers/tty/serial/8250/8250_omap.c | 145 ++++++--------
 drivers/tty/serial/8250/8250_port.c | 298 ++++++++++++----------------
 drivers/tty/serial/8250/8250_rsa.c  |   7 +-
 drivers/tty/serial/serial_core.c    | 143 ++++++-------
 drivers/tty/tty_port.c              | 168 +++++++---------
 drivers/tty/vt/consolemap.c         | 116 +++++------
 drivers/tty/vt/selection.c          |  20 +-
 drivers/tty/vt/vc_screen.c          |  74 +++----
 drivers/tty/vt/vt.c                 | 187 ++++++++---------
 drivers/tty/vt/vt_ioctl.c           | 190 ++++++++----------
 include/linux/console.h             |   2 +
 include/linux/serial_core.h         |  13 ++
 include/linux/tty_port.h            |  14 ++
 17 files changed, 747 insertions(+), 1003 deletions(-)
Signature · 1 line
2.50.1