Skip to content

ASoC: Intel: avs: Code cleanups and separation

Cezary Rojewski linux-sound 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ASoC: Intel: avs: Separate debug symbolssound/soc/intel/avs/apl.c sound/soc/intel/avs/avs.h sound/soc/intel/avs/board_selection.c +12 more+105 -740 replies
2/4ASoC: Intel: avs: Drop pcm.h dependency for probessound/soc/intel/avs/probes.c+17 -30 replies
3/4ASoC: Intel: avs: Do not share the name pointer between componentssound/soc/intel/avs/pcm.c+7 -50 replies
4/4ASoC: Intel: avs: Streamline register-component function namessound/soc/intel/avs/avs.h sound/soc/intel/avs/board_selection.c sound/soc/intel/avs/debug.h +2 more+26 -260 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchAmadeusz Sławiński
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] ASoC: Intel: avs: Code cleanups and separation

Set of patches that brings no new functionality but makes it easier to maintain and read the avs-driver code. There is one 'fix' among them - the third patch, described below.

First, debug-related code - mainly the data-probing feature - is mixed with non-debug PCM code. Separate it into debug.h and update the pcm.c file.

Next, as the probing-board is not tied to any topology file, it shall not using struct avs_soc_component descriptor but the basic struct snd_soc_component one. While on the first sight this is just bump in LOCs, runtime is simplified as no topology checks and related code will be engaged.

With probing-board addressed and debug code relocated:
- address the component-teardown issues when the componet->name points to a string which is shared by multiple components and/or machine boards. devm_kstrdup() makes this go away.

- streamline the naming scheme for the functions engaged in the components registration. This is purely a readability improvement.

Cezary Rojewski (4):
ASoC: Intel: avs: Separate debug symbols
ASoC: Intel: avs: Drop pcm.h dependency for probes
ASoC: Intel: avs: Do not share the name pointer between components
ASoC: Intel: avs: Streamline register-component function names

 sound/soc/intel/avs/apl.c             |  1 +
 sound/soc/intel/avs/avs.h             | 89 +++-----------------------
 sound/soc/intel/avs/board_selection.c | 10 +--
 sound/soc/intel/avs/cnl.c             |  1 +
 sound/soc/intel/avs/core.c            |  1 +
 sound/soc/intel/avs/debug.h           | 91 +++++++++++++++++++++++++++
 sound/soc/intel/avs/debugfs.c         |  1 +
 sound/soc/intel/avs/icl.c             |  1 +
 sound/soc/intel/avs/ipc.c             |  1 +
 sound/soc/intel/avs/lnl.c             |  1 +
 sound/soc/intel/avs/mtl.c             |  1 +
 sound/soc/intel/avs/pcm.c             | 35 ++++++-----
 sound/soc/intel/avs/probes.c          | 23 +++++--
 sound/soc/intel/avs/ptl.c             |  1 +
 sound/soc/intel/avs/skl.c             |  1 +
 sound/soc/intel/avs/tgl.c             |  1 +
 16 files changed, 153 insertions(+), 106 deletions(-)
 create mode 100644 sound/soc/intel/avs/debug.h
Signature · 1 line
2.25.1