crypto,nvme: fixup HKDF-Expand-Label implementation
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | crypto: hkdf: add hkdf_expand_label()crypto/ include/ | +59 | 3 replies | |
| 2/2 | nvme-auth: use hkdf_expand_label()drivers/ | +13 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] crypto,nvme: fixup HKDF-Expand-Label implementation
From: Hannes Reinecke <[email protected]>
As per RFC 8446 (TLS 1.3) the HKDF-Expand-Label function is using vectors for the 'label' and 'context' field, but defines these vectors as a string prefixed with the string length (in binary). The implementation in nvme is missing the length prefix which was causing interoperability issues with spec-conformant implementations.
This patchset adds a function 'hkdf_expand_label()' to correctly implement the HKDF-Expand-Label functionality and modifies the nvme driver to utilize this function instead of the open-coded implementation.
As usual, comments and reviews are welcome.
Chris Leech (1):
crypto: hkdf: add hkdf_expand_label()
Hannes Reinecke (1):
nvme-auth: use hkdf_expand_label()
crypto/hkdf.c | 55 ++++++++++++++++++++++++++++++++++++++ drivers/nvme/common/auth.c | 33 +++++++++-------------- include/crypto/hkdf.h | 4 +++ 3 files changed, 72 insertions(+), 20 deletions(-)
Signature · 1 line
2.43.0