Skip to content

gpio: Use modern PM macros

Jisheng Zhang linux-arm-kernel linux-gpio linux-omap lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest14 patches 9 repliesIn review
  2. v415 patches 10 repliesSuperseded
  3. v315 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v215 patches14 repliesSuperseded
v116 patches13 repliesSuperseded

Changes in v5 from the cover letter

- collect Reviewed-by tags.
- use pm_ptr() instead of pm_sleep_ptr() for gpio-tqmx86
- drop patch5 for gpio-pxa due to maintainer's conern with memory waste

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14gpio: dwapb: Use modern PM macrosdrivers/gpio/gpio-dwapb.c+4 -140 replies
2/14gpio: brcmstb: Use modern PM macrosdrivers/gpio/gpio-brcmstb.c+3 -97 replies
3/14gpio: htc-egpio: Use modern PM macrosdrivers/gpio/gpio-htc-egpio.c+8 -130 replies
4/14gpio: pl061: Use modern PM macrosdrivers/gpio/gpio-pl061.c+2 -150 replies
5/14gpio: ml-ioh: Use modern PM macrosdrivers/gpio/gpio-ml-ioh.c+6 -60 replies
6/14gpio: mlxbf2: Use modern PM macrosdrivers/gpio/gpio-mlxbf2.c+4 -40 replies
7/14gpio: msc313: Use modern PM macrosdrivers/gpio/gpio-msc313.c+4 -41 reply
8/14gpio: omap: Use modern PM macrosdrivers/gpio/gpio-omap.c+7 -80 replies
9/14gpio: pch: Use modern PM macrosdrivers/gpio/gpio-pch.c+6 -60 replies
10/14gpio: tqmx86: Use modern PM macrosdrivers/gpio/gpio-tqmx86.c+4 -50 replies
11/14gpio: uniphier: Use modern PM macrosdrivers/gpio/gpio-uniphier.c+4 -50 replies
12/14gpio: xgene: Use modern PM macrosdrivers/gpio/gpio-xgene.c+4 -40 replies
13/14gpio: xilinx: Use modern PM macrosdrivers/gpio/gpio-xilinx.c+7 -80 replies
14/14gpio: zynq: Use modern PM macrosdrivers/gpio/gpio-zynq.c+7 -80 replies

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by.

PatchLinus WalleijAndy ShevchenkoDoug BergerFlorian FainelliDaniel Palmer
1/14A-b R-b
2/14A-b A-b R-b
3/14R-b R-b
4/14R-b A-b R-b
5/14A-b A-b R-b
6/14A-b R-b
7/14A-b R-b R-b
8/14A-b R-b
9/14A-b A-b R-b
10/14A-b
11/14A-b R-b
12/14A-b R-b
13/14A-b R-b
14/14A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/14] gpio: Use modern PM macros

Use the modern PM macros for the suspend and resume functions to be automatically dropped by the compiler when CONFIG_PM or CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards or __maybe_unused.

This has the advantage of always compiling these functions in, independently of any Kconfig option. Thanks to that, bugs and other regressions are subsequently easier to catch.

Almost all drivers are converted, only gpio-tegra and gpio-mlxbf are left as is, because the memory for saving HW context is not trivial, if we convert them, then the two drivers' users may complain for !CONFIG_PM && !CONFIG_PM_SLEEP case. So I didn't touch them.

patch to gpio-dwapb.c is tested on real HW, others are compile-tested only.

since v4:
- collect Reviewed-by tags.
- use pm_ptr() instead of pm_sleep_ptr() for gpio-tqmx86
- drop patch5 for gpio-pxa due to maintainer's conern with memory waste

since v3:
- fix typos.
- fix the stray change in gpio-pxa driver.

since v2:
- collect Acked-by, Reviewed-by tags.
- move the embeddng the structure for pm in gpio-dwapb out, will send it as a separate patch.

since v1:
- rebase on the latest gpio/for-next branch.
- collect Acked-by, Reviewed-by tags.
- clarify the trival memory wasted numbers with CONFIG_PM=n in the dwapb's patch commit message as suggested by Andy.
- drop patch to bt8xxx since the clean up is acchieved when switching to generic PCI pm framework.

Jisheng Zhang (14):
gpio: dwapb: Use modern PM macros
gpio: brcmstb: Use modern PM macros
gpio: htc-egpio: Use modern PM macros
gpio: pl061: Use modern PM macros
gpio: ml-ioh: Use modern PM macros
gpio: mlxbf2: Use modern PM macros
gpio: msc313: Use modern PM macros
gpio: omap: Use modern PM macros
gpio: pch: Use modern PM macros
gpio: tqmx86: Use modern PM macros
gpio: uniphier: Use modern PM macros
gpio: xgene: Use modern PM macros
gpio: xilinx: Use modern PM macros
gpio: zynq: Use modern PM macros

 drivers/gpio/gpio-brcmstb.c   | 12 +++---------
 drivers/gpio/gpio-dwapb.c     | 18 ++++--------------
 drivers/gpio/gpio-htc-egpio.c | 21 ++++++++-------------
 drivers/gpio/gpio-ml-ioh.c    | 12 ++++++------
 drivers/gpio/gpio-mlxbf2.c    |  8 ++++----
 drivers/gpio/gpio-msc313.c    |  8 ++++----
 drivers/gpio/gpio-omap.c      | 15 +++++++--------
 drivers/gpio/gpio-pch.c       | 12 ++++++------
 drivers/gpio/gpio-pl061.c     | 17 ++---------------
 drivers/gpio/gpio-tqmx86.c    |  9 ++++-----
 drivers/gpio/gpio-uniphier.c  |  9 ++++-----
 drivers/gpio/gpio-xgene.c     |  8 ++++----
 drivers/gpio/gpio-xilinx.c    | 15 +++++++--------
 drivers/gpio/gpio-zynq.c      | 15 +++++++--------
 14 files changed, 70 insertions(+), 109 deletions(-)
Signature · 1 line
2.51.0