Skip to content

Convert old-style function definitions into modern-style definitions

Steve Dickson linux-nfs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12Convert old-style function definitions into modern-style definitionssrc/xdr.c src/xdr_array.c src/xdr_float.c +5 more+270 -2910 replies
2/12Convert old-style function definitions into modern-style definitionssrc/svc.c src/svc_auth.c src/svc_auth_unix.c +5 more+197 -2190 replies
3/12Convert old-style function definitions into modern-style definitionssrc/rpcb_clnt.c src/rpcb_prot.c src/rpcb_st_xdr.c+119 -1250 replies
4/12Convert old-style function definitions into modern-style definitionssrc/rpcdname.c src/rtime.c+6 -80 replies
5/12Convert old-style function definitions into modern-style definitionssrc/rpc_callmsg.c src/rpc_generic.c src/rpc_prot.c +1 more+180 -2010 replies
6/12Convert old-style function definitions into modern-style definitionssrc/pmap_getmaps.c src/pmap_getport.c src/pmap_prot.c +2 more+26 -300 replies
7/12Convert old-style function definitions into modern-style definitionssrc/netname.c src/netnamer.c+25 -250 replies
8/12Convert old-style function definitions into modern-style definitionssrc/key_call.c+27 -310 replies
9/12Convert old-style function definitions into modern-style definitionssrc/getnetconfig.c src/getnetpath.c src/getpublickey.c +1 more+29 -350 replies
10/12Convert old-style function definitions into modern-style definitionssrc/clnt_bcast.c src/clnt_dg.c src/clnt_perror.c +3 more+121 -1470 replies
11/12Convert old-style function definitions into modern-style definitionssrc/bindresvport.c+1 -30 replies
12/12Convert old-style function definitions into modern-style definitionssrc/auth_time.c src/auth_unix.c src/authunix_prot.c+31 -440 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/12] Convert old-style function definitions into modern-style definitions

This patch set converts all of the old-style function definitions into modern-style definitions through out the library... basically touching almost every function definition.

The conversion was pretty straightforward... The same repetitive changes were make on all the functions and the compiler pointed out any declaration issue that came up. I'm confident the API did not change.

I test the changes by doing kernel builds over both secured and unsecured mounts. I also ran my Bakeathon Cthon tool which mounts all versions, simultaneously, and runs cthon test on them... both secured and insecure mounts... for over 48hrs.

The one part I didn't test was the NIS support since I didn't have a NIS setup... I'm pretty confident things should work... Again the changes were I'm all straightforward.

Reviews are welcome!

Steve Dickson (12):
Convert old-style function definitions into modern-style definitions Convert old-style function definitions into modern-style definitions Convert old-style function definitions into modern-style definitions Convert old-style function definitions into modern-style definitions Convert old-style function definitions into modern-style definitions Convert old-style function definitions into modern-style definitions Convert old-style function definitions into modern-style definitions Convert old-style function definitions into modern-style definitions Convert old-style function definitions into modern-style definitions Convert old-style function definitions into modern-style definitions Convert old-style function definitions into modern-style definitions Convert old-style function definitions into modern-style definitions

 src/auth_time.c     |  42 +++---
 src/auth_unix.c     |  29 ++---
 src/authunix_prot.c |   4 +-
 src/bindresvport.c  |   4 +-
 src/clnt_bcast.c    |  46 ++++---
 src/clnt_dg.c       |  59 ++++-----
 src/clnt_perror.c   |  23 +---
 src/clnt_raw.c      |  46 +++----
 src/clnt_simple.c   |  19 +--
 src/clnt_vc.c       |  75 +++++------
 src/getnetconfig.c  |  24 ++--
 src/getnetpath.c    |  12 +-
 src/getpublickey.c  |  20 +--
 src/getrpcport.c    |   8 +-
 src/key_call.c      |  58 ++++-----
 src/netname.c       |  19 ++-
 src/netnamer.c      |  31 ++---
 src/pmap_getmaps.c  |   3 +-
 src/pmap_getport.c  |  10 +-
 src/pmap_prot.c     |   4 +-
 src/pmap_prot2.c    |   8 +-
 src/pmap_rmt.c      |  31 +++--
 src/rpc_callmsg.c   |   4 +-
 src/rpc_generic.c   |  31 ++---
 src/rpc_prot.c      |  36 ++---
 src/rpc_soc.c       | 310 ++++++++++++++++++++++----------------------
 src/rpcb_clnt.c     | 154 +++++++++++-----------
 src/rpcb_prot.c     |  48 +++----
 src/rpcb_st_xdr.c   |  42 +++---
 src/rpcdname.c      |   3 +-
 src/rtime.c         |  11 +-
 src/svc.c           | 107 +++++++--------
 src/svc_auth.c      |  14 +-
 src/svc_auth_unix.c |  12 +-
 src/svc_dg.c        |  75 +++++------
 src/svc_generic.c   |  32 ++---
 src/svc_raw.c       |  46 ++++---
 src/svc_simple.c    |  19 ++-
 src/svc_vc.c        | 111 ++++++++--------
 src/xdr.c           | 224 ++++++++++++++++----------------
 src/xdr_array.c     |  26 ++--
 src/xdr_float.c     |  12 +-
 src/xdr_mem.c       |  74 +++++------
 src/xdr_rec.c       | 121 ++++++++---------
 src/xdr_reference.c |  20 +--
 src/xdr_sizeof.c    |  30 ++---
 src/xdr_stdio.c     |  54 ++++----
 47 files changed, 1032 insertions(+), 1159 deletions(-)
Signature · 1 line
2.50.1