Skip to content

PCI/AER: Handle Advisory Non-Fatal error

Matthew W Carlis linux-acpi linux-cxl linux-edac linux-pci linuxppc-dev lkml 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 3/30 of 2 patches 0 repliesNew
  2. v5 posting 2/30 of 2 patches 1 replySuperseded
  3. v5 posting 1/30 of 2 patches 2 repliesSuperseded

Patches in v5 posting 3/3 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/2] PCI/AER: Handle Advisory Non-Fatal error

On Fri, 22 Aug 2025 11:51:12 -0500, Bjorn Helgaas wrote

Quoted 2 lines

Matthew, if you are able to test and/or provide a Reviewed-by, that would be the best thing you can do to move this forward ...

I spent some time looking at the patch thinking about it a little more carefully. The only thing I don't really like in this revision of the patch is the logging for "may cause Advisory". Example below from "[PATCH v5 2/2] PCI/AER: Print UNCOR_STATUS bits that might be ANFE".

AER: Correctable error message received from 0000:b7:02.0
PCIe Bus Error: severity=Correctable, type=Transaction Layer, (Receiver ID)
device [8086:0db0] error status/mask=00002000/00000000
[13] NonFatalErr
Uncorrectable errors that may cause Advisory Non-Fatal:
[12] TLP

I don't think we really need to log the UE caused by ANF any differently than any other UE & in fact I would prefer not to. In my mind we should log all the UE status bits via the same format as before. Taking from example above, in my mind it would be nice if the logging looked like this.

AER: Correctable error message received from 0000:b7:02.0
PCIe Bus Error: severity=Correctable, type=Transaction Layer, (Receiver ID)
device [8086:0db0] error status/mask=00002000/00000000
[13] NonFatalErr
PCIe Bus Error: severity=Uncorrectable (Non-Fatal), type=Transaction Layer
[12] TLP

If there was only one error (that triggered ANF handling) then we would know that the Non-Fatal UE was what triggered the NonFatalErr. If some other Non-Fatal errors are happening at the same time then it doesn't really matter which was sent via ERR_COR vs ERR_NONFATAL since we would also know from Root Error Status that we had received at least one of each message type. The objective in my mind being to free up header-logs & log status details without making error the recovery worse.

Does this sound reasonable or unreasonable? I can update the patch-set & re-submit if 'reasonable'.

Cheers!
-Matt