Skip to content

tcp: annotate data-races around icsk_retransmits and icsk_probes_out

Eric Dumazet netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesApplied 2/2

Patches in v1 All 2 applied

#Subject and filesSizeRepliesApplied
1/2tcp: annotate data-races around icsk->icsk_retransmitsnet/ipv4/inet_diag.c net/ipv4/tcp.c net/ipv4/tcp_input.c +5 more+12 -101 replyApplied
2/2tcp: annotate data-races around icsk->icsk_probes_outnet/ipv4/inet_diag.c net/ipv4/tcp.c net/ipv4/tcp_input.c +4 more+10 -103 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNeal Cardwell
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/2] tcp: annotate data-races around icsk_retransmits and icsk_probes_out

icsk->icsk_retransmits is read locklessly from inet_sk_diag_fill(), tcp_get_timestamping_opt_stats, get_tcp4_sock() and get_tcp6_sock().

icsk->icsk_probes_out is read locklessly from inet_sk_diag_fill(), get_tcp4_sock() and get_tcp6_sock().

Add corresponding READ_ONCE()/WRITE_ONCE() annotations.

Eric Dumazet (2):
tcp: annotate data-races around icsk->icsk_retransmits
tcp: annotate data-races around icsk->icsk_probes_out

 net/ipv4/inet_diag.c  | 6 +++---
 net/ipv4/tcp.c        | 5 +++--
 net/ipv4/tcp_input.c  | 8 ++++----
 net/ipv4/tcp_ipv4.c   | 4 ++--
 net/ipv4/tcp_output.c | 6 +++---
 net/ipv4/tcp_timer.c  | 6 +++---
 net/ipv6/tcp_ipv6.c   | 4 ++--
 net/mptcp/protocol.c  | 3 ++-
 8 files changed, 22 insertions(+), 20 deletions(-)
Signature · 1 line
2.51.0.rc2.233.g662b1ed5c5-goog