keyutils: Add some fixes and updates
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | lib: Fix a couple of potential signed oveflowskeyutils.c | +5 | 1 reply | |
| 2/7 | request-key: Fix mishandling of last line of config filerequest-key.c | +2 | 2 replies | |
| 3/7 | test: Hide endiannesstests/ tests/ | +25 | 0 replies | |
| 4/7 | tests: Add skips for testing of unsupported featurestests/ tests/ tests/ +11 more | +136 | 0 replies | |
| 5/7 | request-key: Add help textman/ request-key.c | +85 | 1 reply | |
| 6/7 | request-key: Add a simpler debug testman/ request-key.c | +161 | 1 reply | |
| 7/7 | request-key: Support the promised multiwildcard matchingman/ request-key.c | +217 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Jarkko Sakkinen |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | R-b |
| 5/7 | R-b |
| 6/7 | T-b R-b |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/7] keyutils: Add some fixes and updates
Hi Jarkko,
Here are some patches that I'm proposing to add to keyutils:
(1) Fix a couple of potential signed overflows in the library.
(2) In request-key, fix the mishandling of the last line of the request-key.conf file if it doesn't have a newline at the end.
(3) In the tests, hide the endianness of raw binary content (such as keyring content) by using od to byteswap it appropriately rather than trying to do this manually.
(4) In the tests, add skips for unsupported features.
(5) In request-key, add help text if "--help" is given or no parameters are given.
(6) Add a simpler way to do configuration testing:
request-key --check [-lnv] type desc [info] [op]
(7) Add support for multiwildcard matching in request-key.conf. This can be tested with:
request-key --match [-v] pattern datum [datum...]
Apologies, some of these should have been committed a while ago.
David
David Howells (7):
lib: Fix a couple of potential signed oveflows
request-key: Fix mishandling of last line of config file
test: Hide endianness
tests: Add skips for testing of unsupported features
request-key: Add help text
request-key: Add a simpler debug test
request-key: Support the promised multiwildcard matching
keyutils.c | 5 + man/request-key.8 | 85 +++- request-key.c | 504 ++++++++++++++++------ tests/features/limits/runtest.sh | 6 + tests/hex2bin.pl | 21 + tests/keyctl/id/bad-args/runtest.sh | 6 + tests/keyctl/id/noargs/runtest.sh | 6 + tests/keyctl/id/valid/runtest.sh | 6 + tests/keyctl/move/bad-args/runtest.sh | 6 + tests/keyctl/move/noargs/runtest.sh | 6 + tests/keyctl/move/recursion/runtest.sh | 6 + tests/keyctl/move/valid/runtest.sh | 6 + tests/keyctl/reading/valid/runtest.sh | 9 +- tests/keyctl/session/valid2/runtest.sh | 6 + tests/keyctl/supports/bad-args/runtest.sh | 6 + tests/keyctl/supports/valid/runtest.sh | 6 + tests/prepare.inc.sh | 23 +- tests/toolbox.inc.sh | 69 ++- 18 files changed, 619 insertions(+), 163 deletions(-) create mode 100644 tests/hex2bin.pl