Skip to content

module: logging and code improvements

Jinchao Wang linux-modules lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 8 repliesIn review
  2. v24 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- show mod->name in try_to_force_load
- fix a introduced bug in patch 3

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4module: signing: Use pr_err for signature rejectionkernel/module/signing.c+1 -13 replies
2/4module: show why force load failskernel/module/main.c+1 -03 replies
3/4module: centralize no-versions force load checkkernel/module/version.c+8 -21 reply
4/4module: separate vermagic and livepatch checkskernel/module/main.c+7 -61 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPetr Pavlu
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] module: logging and code improvements

This series of patches cleans up and refactors the kernel's module loading code. The goal is to make the subsystem's logging clearer and its internal logic more straightforward for developers to understand.

The patches in this series:

- module: signing: Use pr_err for signature rejection
Makes module signature rejection messages more visible.
- module: show why force load fails
Adds a reason to the error message when force loading is disabled.
- module: centralize no-versions force load check
Refactors the code to centralize the "no versions" force load check.
- module: separate vermagic and livepatch checks
Improves code organization by separating vermagic and livepatch checks.

---
Changes from v2:
- show mod->name in try_to_force_load
- fix a introduced bug in patch 3

Changes from v1:
- A patch was dropped because it was based on a misunderstanding of the ignore versioning flag's original intent.

v2:
https://lore.kernel.org/all/[email protected]/

v1 :
https://lore.kernel.org/all/[email protected]

Jinchao Wang (4):
module: signing: Use pr_err for signature rejection
module: show why force load fails
module: centralize no-versions force load check
module: separate vermagic and livepatch checks

 kernel/module/main.c    | 14 ++++++++------
 kernel/module/signing.c |  2 +-
 kernel/module/version.c | 10 ++++++++--
 3 files changed, 17 insertions(+), 9 deletions(-)
Signature · 1 line
2.43.0