Skip to content

mm/pageblock: improve readability of some pageblock handling

Wei Yang linux-mm 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 8 repliesSuperseded
  3. v12 patches 6 repliesSuperseded

Changes in v3 from the cover letter

fix the definition of MIGRATETYPE_MASK, thanks ziy

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mm/page_alloc: use xxx_pageblock_isolate() for better readingmm/page_alloc.c+3 -40 replies
2/2mm/pageblock-flags: remove PB_migratetype_bits/PB_migrate_endinclude/linux/pageblock-flags.h mm/page_alloc.c+7 -91 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchZi YanDavid Hildenbrand
1/2R-b A-b
2/2R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Patch v3 0/2] mm/pageblock: improve readability of some pageblock handling

During code reading, found two possible points to improve the readability of pageblock handling.

Patch 1: isolate bit is standalone and there are dedicated helpers. Instead of check the bit directly, we could use the helper to do it.

Patch 2: remove PB_migratetype_bits and PB_migrate_end to reduce magical computation.

v2->v3:
fix the definition of MIGRATETYPE_MASK, thanks ziy

v1->v2:
remove PB_migratetype_bits and PB_migrate_end

Wei Yang (2):
mm/page_alloc: use xxx_pageblock_isolate() for better reading mm/pageblock-flags: remove PB_migratetype_bits/PB_migrate_end

 include/linux/pageblock-flags.h | 12 +++++-------
 mm/page_alloc.c                 | 11 +++++------
 2 files changed, 10 insertions(+), 13 deletions(-)
Signature · 1 line
2.34.1