RFC Avoid overlapping declarations
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest8 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | test/ring: avoid shadow variable usageapp/ | +95 | 1 reply | |
| 2/8 | test/table: replace conflicting variable nameapp/ app/ app/ +1 more | +27 | 0 replies | |
| 3/8 | eal: add macro to disable shadow warningslib/ | +17 | 1 reply | |
| 4/8 | eal: avoid shadowed variable aligned_endlib/ | +3 | 0 replies | |
| 5/8 | eal: avoid shadowed variables in trace codelib/ | +21 | 0 replies | |
| 6/8 | ethdev: avoid shadowed variable warningslib/ lib/ lib/ | +4 | 1 reply | |
| 7/8 | telemetry: avoid potential name conflict for handlerlib/ lib/ | +2 | 1 reply | |
| 8/8 | pcapng: avoid shadow declaration warninglib/ | +4 | 0 replies |
Reviews trailers per patch
4 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Bruce Richardson | Andrew Rybchenko |
|---|---|---|
| 1/8 | A-b | |
| 2/8 | ||
| 3/8 | A-b | |
| 4/8 | ||
| 5/8 | ||
| 6/8 | A-b | |
| 7/8 | A-b | |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC 0/8] Avoid overlapping declarations
This is first part of changes to fix places where a variable declaration overlaps another. These get shown if -Wshadow is enabled. Lots of drivers and eventdev still have this problem.
Stephen Hemminger (8):
test/ring: avoid shadow variable usage test/table: replace conflicting variable name
eal: add macro to disable shadow warnings
eal: avoid shadowed variable aligned_end
eal: avoid shadowed variables in trace code
ethdev: avoid shadowed variable warnings
telemetry: avoid potential name conflict for handler
pcapng: avoid shadow declaration warning
app/test/test_ring.c | 190 +++++++++++++++--------------- app/test/test_table.c | 2 +- app/test/test_table.h | 2 +- app/test/test_table_acl.c | 28 ++--- app/test/test_table_pipeline.c | 22 ++-- lib/eal/common/eal_common_trace.c | 42 +++---- lib/eal/common/malloc_heap.c | 6 +- lib/eal/include/rte_common.h | 17 +++ lib/ethdev/ethdev_driver.c | 2 +- lib/ethdev/ethdev_driver.h | 6 +- lib/ethdev/rte_ethdev.c | 1 - lib/pcapng/rte_pcapng.c | 9 +- lib/telemetry/rte_telemetry.h | 2 +- lib/telemetry/telemetry.c | 2 +- 14 files changed, 173 insertions(+), 158 deletions(-)
Signature · 1 line
2.47.2