Skip to content

inet_diag: make dumps faster with simple filters

Eric Dumazet netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 5 repliesApplied 5/5

Patches in v1 All 5 applied

#Subject and filesSizeRepliesApplied
1/5inet_diag: annotate data-races in inet_diag_msg_common_fill()net/ipv4/inet_diag.c+9 -91 replyApplied
2/5tcp: annotate data-races in tcp_req_diag_fill()net/ipv4/tcp_diag.c net/ipv4/tcp_output.c+3 -31 replyApplied
3/5inet_diag: annotate data-races in inet_diag_bc_sk()net/ipv4/inet_diag.c+7 -71 replyApplied
4/5inet_diag: change inet_diag_bc_sk() first argumentinclude/linux/inet_diag.h net/ipv4/inet_diag.c net/ipv4/raw_diag.c +3 more+16 -321 replyApplied
5/5inet_diag: avoid cache line misses in inet_diag_bc_sk()include/linux/inet_diag.h net/ipv4/inet_diag.c+36 -211 replyApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchKuniyuki Iwashima
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/5] inet_diag: make dumps faster with simple filters

inet_diag_bc_sk() pulls five cache lines per socket, while most filters only need the two first ones.

We can change it to only pull needed cache lines, to make things like "ss -temoi src :21456" much faster.

First patches (1-3) are annotating data-races as a first step.

Eric Dumazet (5):
inet_diag: annotate data-races in inet_diag_msg_common_fill()
tcp: annotate data-races in tcp_req_diag_fill()
inet_diag: annotate data-races in inet_diag_bc_sk()
inet_diag: change inet_diag_bc_sk() first argument
inet_diag: avoid cache line misses in inet_diag_bc_sk()

 include/linux/inet_diag.h |  7 +++-
 net/ipv4/inet_diag.c      | 85 ++++++++++++++++++++++-----------------
 net/ipv4/raw_diag.c       | 10 ++---
 net/ipv4/tcp_diag.c       | 12 +++---
 net/ipv4/tcp_output.c     |  2 +-
 net/ipv4/udp_diag.c       | 10 ++---
 net/mptcp/mptcp_diag.c    | 15 ++-----
 7 files changed, 70 insertions(+), 71 deletions(-)
Signature · 1 line
2.51.0.268.g9569e192d0-goog