Skip to content

SI power management fixes (v3)

Timur Kristóf amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/amdgpu: Power up UVD 3 for FW validation (v2)drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c+25 -40 replies
2/10drm/amd/pm: Disable ULV even if unsupported (v3)drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c+3 -70 replies
3/10drm/amd/pm: Increase SMC timeout on SI and warn (v3)drivers/gpu/drm/amd/pm/legacy-dpm/si_smc.c+24 -20 replies
4/10drm/amd/pm: Fix si_upload_smc_data (v3)drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c+24 -190 replies
5/10drm/amd/pm: Adjust si_upload_smc_data register programming (v3)drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c+2 -20 replies
6/10drm/amd/pm: Treat zero vblank time as too short in si_dpm (v3)drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c+7 -10 replies
7/10drm/amd/pm: Disable MCLK switching with non-DC at 120 Hz+ (v2)drivers/gpu/drm/amd/pm/amdgpu_dpm_internal.c+7 -00 replies
8/10drm/amd/pm: Disable SCLK switching on Oland with high pixel clocks (v3)drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c+31 -00 replies
9/10drm/amd/pm: Remove wm_low and wm_high fields from amdgpu_crtc (v2)drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h drivers/gpu/drm/amd/amdgpu/dce_v10_0.c drivers/gpu/drm/amd/amdgpu/dce_v11_0.c +2 more+3 -90 replies
10/10drm/amd/pm: Print VCE clocks too in si_dpm (v3)drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c+1 -00 replies

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlex Deucher
SeriesR-b
1/10
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] SI power management fixes (v3)

This series fixes some power management issues on SI, addressing the feedback I got for the previous versions.

Additionally, the following improvements were made:

There is now a patch that increases the SMC timeout. This gets rid of some errors that happened when switching between power states. Apparently the SMC can sometimes take a long time.

Also removed one of the ad-hoc fixes from si_dpm because it didn't actually address anything, and edited that patch to focus on just solving the flickering on Oland.

And edited the si_upload_smc_data patch yet again to program the soft registers to zero when there are no displays connected.

Timur Kristóf (10):
drm/amdgpu: Power up UVD 3 for FW validation (v2) drm/amd/pm: Disable ULV even if unsupported (v3) drm/amd/pm: Increase SMC timeout on SI and warn (v3) drm/amd/pm: Fix si_upload_smc_data (v3)
drm/amd/pm: Adjust si_upload_smc_data register programming (v3) drm/amd/pm: Treat zero vblank time as too short in si_dpm (v3) drm/amd/pm: Disable MCLK switching with non-DC at 120 Hz+ (v2) drm/amd/pm: Disable SCLK switching on Oland with high pixel clocks

    (v3)

drm/amd/pm: Remove wm_low and wm_high fields from amdgpu_crtc (v2) drm/amd/pm: Print VCE clocks too in si_dpm (v3)

 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h     |  2 -
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c       |  3 +-
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c       |  3 +-
 drivers/gpu/drm/amd/amdgpu/dce_v6_0.c        |  1 -
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c        |  3 +-
 drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c        | 29 +++++-
 drivers/gpu/drm/amd/pm/amdgpu_dpm_internal.c |  7 ++
 drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c   | 93 ++++++++++++++------
 drivers/gpu/drm/amd/pm/legacy-dpm/si_smc.c   | 26 +++++-
 9 files changed, 125 insertions(+), 42 deletions(-)
Signature · 1 line
2.51.0