Skip to content

better error messages for ioctls

Kent Overstreet linux-bcachefs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3bcachefs: Add v2 ioctls that return error stringsfs/bcachefs/bcachefs_ioctl.h fs/bcachefs/chardev.c+204 -300 replies
2/3bcachefs: v2 versions of subvolume ioctlsfs/bcachefs/bcachefs_ioctl.h fs/bcachefs/chardev.c fs/bcachefs/chardev.h +1 more+108 -140 replies
3/3bcachefs: Plumb error messages through data drop pathsfs/bcachefs/ec.c fs/bcachefs/ec.h fs/bcachefs/migrate.c +2 more+55 -380 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] better error messages for ioctls

This fixes a common user complaint - uninformative error messages from various bcachefs-tools commands.

Add v2 versions of various ioctls that include a 'struct bch_ioctl_err_mesg', a pointer to a userspace buffer for an error message - and plumb a printbuf through various code for returning errors.

Kent Overstreet (3):
bcachefs: Add v2 ioctls that return error strings
bcachefs: v2 versions of subvolume ioctls
bcachefs: Plumb error messages through data drop paths

 fs/bcachefs/bcachefs_ioctl.h |  87 ++++++++++++++-----
 fs/bcachefs/chardev.c        | 159 +++++++++++++++++++++++++++++++++--
 fs/bcachefs/chardev.h        |   3 +
 fs/bcachefs/ec.c             |  23 +++--
 fs/bcachefs/ec.h             |   5 +-
 fs/bcachefs/fs-ioctl.c       |  91 ++++++++++++++++++--
 fs/bcachefs/migrate.c        |  55 ++++++------
 fs/bcachefs/migrate.h        |   4 +-
 fs/bcachefs/super.c          |   6 +-
 9 files changed, 359 insertions(+), 74 deletions(-)
Signature · 1 line
2.50.1