Skip to content

mm: add `const` to lots of pointer parameters

Max Kellermann linux-fsdevel linux-mm linux-parisc linux-s390 lkml sparclinux 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 4 repliesIn review
  2. v212 patches 20 repliesSuperseded
  3. v112 patches 15 repliesSuperseded

Changes in v3 from the cover letter

- remove garbage from 06/12
- changed tags on subject line (suggested by Matthew Wilcox)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12mm/shmem: add `const` to lots of pointer parametersinclude/linux/mm.h include/linux/shmem_fs.h mm/shmem.c+9 -93 replies
2/12mm/pagemap: add `const` to lots of pointer parametersinclude/linux/pagemap.h+29 -280 replies
3/12mm/mmzone: add `const` to lots of pointer parametersinclude/linux/mmzone.h+21 -210 replies
4/12fs: add `const` to several pointer parametersinclude/linux/fs.h+4 -30 replies
5/12mm/oom_kill: add `const` to pointer parameterinclude/linux/mm.h mm/oom_kill.c+3 -20 replies
6/12mm/util, s390: add `const` to several pointer parametersarch/s390/mm/mmap.c include/linux/mm.h include/linux/pagemap.h +1 more+11 -100 replies
7/12parisc: add `const` to mmap_upper_limit() parameterarch/parisc/include/asm/processor.h arch/parisc/kernel/sys_parisc.c+2 -20 replies
8/12mm/util, s390, sparc, x86: add const to arch_pick_mmap_layout() parameterarch/s390/mm/mmap.c arch/sparc/kernel/sys_sparc_64.c arch/x86/mm/mmap.c +2 more+17 -110 replies
9/12mm/mm_types: add `const` to several pointer parametersinclude/linux/mm_types.h+2 -20 replies
10/12mm/mm_inline: add `const` to lots of pointer parametersinclude/linux/mm_inline.h+14 -120 replies
11/12mm: add `const` to lots of pointer parametersinclude/linux/mm.h+16 -160 replies
12/12mm/highmem: add `const` to lots of pointer parametersarch/arm/include/asm/highmem.h arch/xtensa/include/asm/highmem.h include/linux/highmem-internal.h +2 more+34 -300 replies

Reviews trailers per patch

9 of 12 patches have a Reviewed-by or Acked-by.

PatchVishal Moola (Oracle)Lorenzo Stoakes
1/12R-b R-b
2/12R-b
3/12R-b
4/12R-b
5/12
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/12] mm: add `const` to lots of pointer parameters

For improved const-correctness.

This work was initially posted here:
https://lore.kernel.org/lkml/[email protected]/

.. but got rejected by Lorenzo Stoakes:
https://lore.kernel.org/lkml/[email protected]/

David Hildenbrand and Lorenzo Stoakes suggested splitting the patch into smaller chunks. My second attempt with one smaller patch was met with agreement:

https://lore.kernel.org/lkml/[email protected]/

Now this is the rest of the initial patch in small pieces, plus some more.

Establishing const-correctness in this low-level part of the kernel enables doing the same in higher-level parts, e.g. filesystems.

---
v1 -> v2:
- made several parameter values const (i.e. the pointer address, not just the pointed-to memory), as suggested by Andrew Morton and Yuanchu Xie
- drop existing+obsolete "extern" keywords on lines modified by these patches (suggested by Vishal Moola)
- add missing parameter names on lines modified by these patches (suggested by Vishal Moola)
- more "const" pointers (e.g. the task_struct passed to process_shares_mm())
- add missing "const" to s390, fixing s390 build failure
- moved the mmap_is_legacy() change in arch/s390/mm/mmap.c from 08/12 to 06/12 (suggested by Vishal Moola)

v2 -> v3:
- remove garbage from 06/12
- changed tags on subject line (suggested by Matthew Wilcox)

Max Kellermann (12):
mm/shmem: add const to lots of pointer parameters mm/pagemap: add const to lots of pointer parameters mm/mmzone: add const to lots of pointer parameters
fs: add const to several pointer parameters mm/oom_kill: add const to pointer parameter mm/util, s390: add const to several pointer parameters
parisc: add const to mmap_upper_limit() parameter mm/util, s390, sparc, x86: add const to arch_pick_mmap_layout()
parameter
mm/mm_types: add const to several pointer parameters mm/mm_inline: add const to lots of pointer parameters
mm: add const to lots of pointer parameters mm/highmem: add const to lots of pointer parameters

 arch/arm/include/asm/highmem.h      |  6 +--
 arch/parisc/include/asm/processor.h |  2 +-
 arch/parisc/kernel/sys_parisc.c     |  2 +-
 arch/s390/mm/mmap.c                 |  7 ++--
 arch/sparc/kernel/sys_sparc_64.c    |  3 +-
 arch/x86/mm/mmap.c                  |  7 ++--
 arch/xtensa/include/asm/highmem.h   |  2 +-
 include/linux/fs.h                  |  7 ++--
 include/linux/highmem-internal.h    | 38 ++++++++++---------
 include/linux/highmem.h             |  8 ++--
 include/linux/mm.h                  | 48 +++++++++++------------
 include/linux/mm_inline.h           | 26 +++++++------
 include/linux/mm_types.h            |  4 +-
 include/linux/mmzone.h              | 42 ++++++++++----------
 include/linux/pagemap.h             | 59 +++++++++++++++--------------
 include/linux/sched/mm.h            |  4 +-
 include/linux/shmem_fs.h            |  4 +-
 mm/highmem.c                        | 10 ++---
 mm/oom_kill.c                       |  3 +-
 mm/shmem.c                          |  6 +--
 mm/util.c                           | 20 ++++++----
 21 files changed, 162 insertions(+), 146 deletions(-)
Signature · 1 line
2.47.2