Skip to content

cifs: Various changes

Pali Rohár linux-cifs lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/211 patches 15 repliesIn review
  2. v1 posting 1/235 patches 23 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11cifs: Fix and improve cifs_is_path_accessible() functionfs/smb/client/smb1ops.c+16 -100 replies
2/11cifs: Remove code for querying FILE_INFO_STANDARD via CIFSSMBQPathInfo()fs/smb/client/cifssmb.c fs/smb/client/smb1ops.c fs/smb/client/smb1proto.h+5 -230 replies
3/11cifs: Remove CIFSSMBSetPathInfoFB() fallback functionfs/smb/client/cifssmb.c+0 -360 replies
4/11cifs: Remove cifs_backup_query_path_info() and replace it by cifs_query_path_info()fs/smb/client/inode.c fs/smb/client/smb1ops.c+5 -990 replies
5/11cifs: Fix validation of EAs for WSL reparse pointsfs/smb/client/reparse.c+20 -70 replies
6/11cifs: Validate presence of EA $LXMOD for WSL reparse pointsfs/smb/client/reparse.c+12 -04 replies
7/11cifs: Check if server supports EAs before trying to set it for WSLfs/smb/client/reparse.c+7 -03 replies
8/11cifs: Extend ->set_EA() callback to allow operate on reparse pointfs/smb/client/cifsglob.h fs/smb/client/cifssmb.c fs/smb/client/smb1proto.h +2 more+28 -50 replies
9/11cifs: Create native Window socket file compatible also with WSL subsystemfs/smb/client/reparse.c+28 -21 reply
10/11cifs: Add support for parsing WSL symlinks in version 1 formatfs/smb/client/cifsproto.h fs/smb/client/inode.c fs/smb/client/reparse.c +1 more+105 -203 replies
11/11cifs: Add support for creating WSL symlinks in version 1 formatfs/smb/client/cifsglob.h fs/smb/client/fs_context.c fs/smb/client/fs_context.h +2 more+81 -181 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RESEND 00/11] cifs: Various changes

This patch series contains various cifs changes which I sent year ago. All those patches are rebased on top of the 7.2-rc2 and there is no new change in them, just they are rebased for new code base.

I pushed these changes also into my git branch cifs:
https://git.kernel.org/pub/scm/linux/kernel/git/pali/linux.git/log/?h=cifs

Note that patch "cifs: Remove cifs_backup_query_path_info() and replace it by cifs_query_path_info()" is removing these lines:

- move_cifs_info_to_smb2(&data->fi, fi);
- fdi = (FILE_DIRECTORY_INFO *)fi;
- si = (FILE_ID_FULL_DIR_INFO *)fi;

And I have feeling that in this old code (which is being) removed could be a buffer overflow as it is casting between incompatible structures. I have not spent too much time with it as the code is begin removed. But maybe some AI tool could be able to confirm if this is some buffer overflow or not.

Pali Rohár (11):
cifs: Fix and improve cifs_is_path_accessible() function
cifs: Remove code for querying FILE_INFO_STANDARD via
CIFSSMBQPathInfo()
cifs: Remove CIFSSMBSetPathInfoFB() fallback function
cifs: Remove cifs_backup_query_path_info() and replace it by
cifs_query_path_info()
cifs: Fix validation of EAs for WSL reparse points
cifs: Validate presence of EA $LXMOD for WSL reparse points
cifs: Check if server supports EAs before trying to set it for WSL
cifs: Extend ->set_EA() callback to allow operate on reparse point
cifs: Create native Window socket file compatible also with WSL
subsystem
cifs: Add support for parsing WSL symlinks in version 1 format
cifs: Add support for creating WSL symlinks in version 1 format

 fs/smb/client/cifsglob.h   |  10 +-
 fs/smb/client/cifsproto.h  |   1 +
 fs/smb/client/cifssmb.c    |  79 +++--------
 fs/smb/client/fs_context.c |  11 +-
 fs/smb/client/fs_context.h |   3 +-
 fs/smb/client/inode.c      |  98 +-------------
 fs/smb/client/link.c       |   3 +-
 fs/smb/client/reparse.c    | 267 ++++++++++++++++++++++++++++++++-----
 fs/smb/client/smb1ops.c    |  35 +++--
 fs/smb/client/smb1proto.h  |   4 +-
 fs/smb/client/smb2ops.c    |   6 +-
 fs/smb/client/xattr.c      |   3 +-
 fs/smb/common/fscc.h       |   5 +-
 13 files changed, 306 insertions(+), 219 deletions(-)
Signature · 1 line
2.20.1