Skip to content

mm: establish const-correctness for pointer parameters

Max Kellermann linux-fsdevel linux-mm linux-parisc linux-s390 lkml sparclinux 3 versions Applied

Status from this message: [merged mm-stable] mm-constify-highmem-related-functions-for-improved-const-correctness.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest12 patches 20 repliesApplied 12/12
  2. v512 patches 40 repliesSuperseded
  3. v412 patches 11 repliesSuperseded

Changes in v6 from the cover letter

- fix inconsistent constness of assert_fault_locked()
- revert the const parameter value change from v2 (requested by Lorenzo Stoakes)
- revert the long cover letter, removing long explanations again (requested by Lorenzo Stoakes)

Patches in v6 All 12 applied

#Subject and filesSizeRepliesApplied
1/12mm: constify shmem related test functions for improved const-correctnessinclude/linux/mm.h include/linux/shmem_fs.h mm/shmem.c+9 -90 repliesApplied
2/12mm: constify pagemap related test/getter functionsinclude/linux/pagemap.h+29 -280 repliesApplied
3/12mm: constify zone related test/getter functionsinclude/linux/mmzone.h+21 -210 repliesApplied
4/12fs: constify mapping related test functions for improved const-correctnessinclude/linux/fs.h+3 -32 repliesApplied
5/12mm: constify process_shares_mm() for improved const-correctnessinclude/linux/mm.h mm/oom_kill.c+4 -41 replyApplied
6/12mm, s390: constify mapping related test/getter functionsarch/s390/mm/mmap.c include/linux/mm.h include/linux/pagemap.h +1 more+10 -102 repliesApplied
7/12parisc: constify mmap_upper_limit() parameterarch/parisc/include/asm/processor.h arch/parisc/kernel/sys_parisc.c+2 -22 repliesApplied
8/12mm: constify arch_pick_mmap_layout() for improved const-correctnessarch/s390/mm/mmap.c arch/sparc/kernel/sys_sparc_64.c arch/x86/mm/mmap.c +2 more+11 -112 repliesApplied
9/12mm: constify ptdesc_pmd_pts_count() and folio_get_private()include/linux/mm_types.h+2 -20 repliesApplied
10/12mm: constify various inline functions for improved const-correctnessinclude/linux/mm_inline.h+13 -122 repliesApplied
11/12mm: constify assert/test functions in mm.hinclude/linux/mm.h+20 -202 repliesApplied
12/12mm: constify highmem related functions for improved const-correctnessarch/arm/include/asm/highmem.h arch/xtensa/include/asm/highmem.h include/linux/highmem-internal.h +2 more+31 -312 repliesApplied

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchVishal Moola (Oracle)Lorenzo StoakesDavid HildenbrandVlastimil BabkaMike Rapoport (Microsoft)Jan KaraChristian BraunerShakeel Butt
SeriesA-b A-b A-b
1/12R-b R-b A-b
2/12R-b R-b A-b
3/12R-b R-b A-b
4/12R-b R-b A-b R-b R-b
5/12R-b A-b
6/12R-b R-b A-b
7/12R-b R-b A-b
8/12R-b R-b A-b
9/12R-b R-b A-b
10/12R-b R-b A-b
11/12R-b A-b
12/12R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v6 thread

Cover letter [PATCH v6 00/12] mm: establish const-correctness for pointer parameters

For improved const-correctness in the low-level memory-management subsystem, which provides a basis for further const-ification further up the call stack (e.g. filesystems).

This patch series splitted into smaller patches was initially posted as a single large patch:

https://lore.kernel.org/lkml/[email protected]/

I started this work when I tried to constify the Ceph filesystem code, but found that to be impossible because many "mm" functions accept non-const pointer, even though they modify nothing.

---
v1 -> v2:
- made several parameter values const (i.e. the pointer address, not just the pointed-to memory), as suggested by Andrew Morton and Yuanchu Xie
- drop existing+obsolete "extern" keywords on lines modified by these patches (suggested by Vishal Moola)
- add missing parameter names on lines modified by these patches (suggested by Vishal Moola)
- more "const" pointers (e.g. the task_struct passed to process_shares_mm())
- add missing "const" to s390, fixing s390 build failure
- moved the mmap_is_legacy() change in arch/s390/mm/mmap.c from 08/12 to 06/12 (suggested by Vishal Moola)

v2 -> v3:
- remove garbage from 06/12
- changed tags on subject line (suggested by Matthew Wilcox)

v3 -> v4:
- more verbose commit messages including a listing of function names (suggested by David Hildenbrand and Lorenzo Stoakes)

v4 -> v5:
- back to shorter commit messages after an agreement between David Hildenbrand and Lorenzo Stoakes was found

v5 -> v6:
- fix inconsistent constness of assert_fault_locked()
- revert the const parameter value change from v2 (requested by Lorenzo Stoakes)
- revert the long cover letter, removing long explanations again (requested by Lorenzo Stoakes)

Max Kellermann (12):
mm: constify shmem related test functions for improved
const-correctness
mm: constify pagemap related test/getter functions
mm: constify zone related test/getter functions
fs: constify mapping related test functions for improved
const-correctness
mm: constify process_shares_mm() for improved const-correctness mm, s390: constify mapping related test/getter functions
parisc: constify mmap_upper_limit() parameter
mm: constify arch_pick_mmap_layout() for improved const-correctness
mm: constify ptdesc_pmd_pts_count() and folio_get_private()
mm: constify various inline functions for improved const-correctness
mm: constify assert/test functions in mm.h
mm: constify highmem related functions for improved const-correctness

 arch/arm/include/asm/highmem.h      |  6 +--
 arch/parisc/include/asm/processor.h |  2 +-
 arch/parisc/kernel/sys_parisc.c     |  2 +-
 arch/s390/mm/mmap.c                 |  6 +--
 arch/sparc/kernel/sys_sparc_64.c    |  2 +-
 arch/x86/mm/mmap.c                  |  6 +--
 arch/xtensa/include/asm/highmem.h   |  2 +-
 include/linux/fs.h                  |  6 +--
 include/linux/highmem-internal.h    | 36 +++++++++---------
 include/linux/highmem.h             |  8 ++--
 include/linux/mm.h                  | 56 +++++++++++++--------------
 include/linux/mm_inline.h           | 25 ++++++------
 include/linux/mm_types.h            |  4 +-
 include/linux/mmzone.h              | 42 ++++++++++----------
 include/linux/pagemap.h             | 59 +++++++++++++++--------------
 include/linux/sched/mm.h            |  4 +-
 include/linux/shmem_fs.h            |  4 +-
 mm/highmem.c                        | 10 ++---
 mm/oom_kill.c                       |  6 +--
 mm/shmem.c                          |  6 +--
 mm/util.c                           | 16 ++++----
 21 files changed, 155 insertions(+), 153 deletions(-)
Signature · 1 line
2.47.2