Skip to content

ublk: add UBLK_F_BATCH_IO

Ming Lei linux-block 6 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest24 patches 7 repliesApplied
  2. v521 patches 14 repliesSuperseded
  3. v427 patches 38 repliesApplied
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v327 patches21 repliesSuperseded
v225 patches0 repliesSuperseded
v123 patches18 repliesSuperseded

Changes in v6 from the cover letter

- rebase on for-7.0/block
- fix ublk_handle_non_batch_cmd() (Caleb Sander Mateos)
- add ublk: refactor ublk_queue_rq() and add ublk_batch_queue_rq() (Caleb Sander Mateos)
- add ublk: fix batch I/O recovery -ENODEV error
- increase selftest timeout for running more things in some generic tests
- fix kublk utility wrt. ->cmd_inflight accounting for BATCH_IO
- pass all selftest after applying the io_uring cancel fix

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/24ublk: define ublk_ch_batch_io_fops for the coming feature F_BATCH_IOdrivers/block/ublk_drv.c+25 -10 replies
2/24ublk: prepare for not tracking task context for command batchdrivers/block/ublk_drv.c+4 -10 replies
3/24ublk: add new batch command UBLK_U_IO_PREP_IO_CMDS & UBLK_U_IO_COMMIT_IO_CMDSdrivers/block/ublk_drv.c include/uapi/linux/ublk_cmd.h+135 -10 replies
4/24ublk: handle UBLK_U_IO_PREP_IO_CMDSdrivers/block/ublk_drv.c include/uapi/linux/ublk_cmd.h+195 -11 reply
5/24ublk: handle UBLK_U_IO_COMMIT_IO_CMDSdrivers/block/ublk_drv.c include/uapi/linux/ublk_cmd.h+109 -20 replies
6/24ublk: add io events fifo structuredrivers/block/ublk_drv.c+63 -60 replies
7/24ublk: add batch I/O dispatch infrastructuredrivers/block/ublk_drv.c+195 -02 replies
8/24ublk: add UBLK_U_IO_FETCH_IO_CMDS for batch I/O processingdrivers/block/ublk_drv.c include/uapi/linux/ublk_cmd.h+393 -80 replies
9/24ublk: refactor ublk_queue_rq() and add ublk_batch_queue_rq()drivers/block/ublk_drv.c+46 -101 reply
10/24ublk: abort requests filled in event kfifodrivers/block/ublk_drv.c+23 -10 replies
11/24ublk: add new feature UBLK_F_BATCH_IOdrivers/block/ublk_drv.c include/uapi/linux/ublk_cmd.h+67 -80 replies
12/24ublk: document feature UBLK_F_BATCH_IODocumentation/block/ublk.rst+60 -40 replies
13/24ublk: implement batch request completion via blk_mq_end_request_batch()drivers/block/ublk_drv.c+17 -80 replies
14/24ublk: fix batch I/O recovery -ENODEV errordrivers/block/ublk_drv.c+60 -321 reply
15/24selftests: ublk: fix user_data truncation for tgt_data >= 256tools/testing/selftests/ublk/kublk.h+1 -10 replies
16/24selftests: ublk: replace assert() with ublk_assert()tools/testing/selftests/ublk/common.c tools/testing/selftests/ublk/file_backed.c tools/testing/selftests/ublk/kublk.c +3 more+19 -90 replies
17/24selftests: ublk: add ublk_io_buf_idx() for returning io buffer indextools/testing/selftests/ublk/file_backed.c tools/testing/selftests/ublk/kublk.c tools/testing/selftests/ublk/kublk.h +2 more+33 -200 replies
18/24selftests: ublk: add batch buffer management infrastructuretools/testing/selftests/ublk/batch.c tools/testing/selftests/ublk/kublk.c tools/testing/selftests/ublk/kublk.h +1 more+282 -30 replies
19/24selftests: ublk: handle UBLK_U_IO_PREP_IO_CMDStools/testing/selftests/ublk/batch.c tools/testing/selftests/ublk/kublk.c tools/testing/selftests/ublk/kublk.h+174 -120 replies
20/24selftests: ublk: handle UBLK_U_IO_COMMIT_IO_CMDStools/testing/selftests/ublk/batch.c tools/testing/selftests/ublk/kublk.c tools/testing/selftests/ublk/kublk.h+122 -290 replies
21/24selftests: ublk: handle UBLK_U_IO_FETCH_IO_CMDStools/testing/selftests/ublk/batch.c tools/testing/selftests/ublk/kublk.c tools/testing/selftests/ublk/kublk.h+159 -40 replies
22/24selftests: ublk: increase timeout to 150 secondstools/testing/selftests/ublk/Makefile tools/testing/selftests/ublk/settings+3 -00 replies
23/24selftests: ublk: add --batch/-b for enabling F_BATCH_IOtools/testing/selftests/ublk/Makefile tools/testing/selftests/ublk/kublk.c tools/testing/selftests/ublk/test_batch_01.sh +4 more+148 -20 replies
24/24selftests: ublk: support arbitrary threads/queues combinationtools/testing/selftests/ublk/Makefile tools/testing/selftests/ublk/batch.c tools/testing/selftests/ublk/kublk.c +3 more+302 -480 replies

Reviews trailers per patch

13 of 24 patches have a Reviewed-by or Acked-by.

PatchCaleb Sander Mateos
1/24R-b
2/24R-b
3/24R-b
4/24R-b
5/24R-b
6/24R-b
7/24R-b
8/24R-b
9/24R-b
10/24R-b
11/24R-b
12/24R-b
13/24R-b
14/24
15/24
16/24
17/24
18/24
19/24
20/24
21/24
22/24
23/24
24/24

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH V6 00/24] ublk: add UBLK_F_BATCH_IO

Hello,

This patchset adds UBLK_F_BATCH_IO feature for communicating between kernel and ublk server in batching way:

- Per-queue vs Per-I/O: Commands operate on queues rather than individual I/Os

- Batch processing: Multiple I/Os are handled in single operation

- Multishot commands: Use io_uring multishot for reducing submission overhead

- Flexible task assignment: Any task can handle any I/O (no per-I/O daemons)

- Better load balancing: Tasks can adjust their workload dynamically

- help for future optimizations:
- blk-mq batch tags free
- support io-poll
- per-task batch for avoiding per-io lock
- fetch command priority

- simplify command cancel process with per-queue lock

selftest are provided.

Performance test result(IOPS) on V3:

- page copy

tools/testing/selftests/ublk//kublk add -t null -q 16 [-b]

- zero copy(--auto_zc) tools/testing/selftests/ublk//kublk add -t null -q 16 --auto_zc [-b]

- IO test
taskset -c 0-31 fio/t/io_uring -p0 -n $JOBS -r 30 /dev/ublkb0

1) 16 jobs IO
- page copy: 37.77M vs. 42.40M(BATCH_IO), +12%
- zero copy(--auto_zc): 42.83M vs. 44.43M(BATCH_IO), +3.7%

2) single job IO
- page copy: 2.54M vs. 2.6M(BATCH_IO), +2.3%
- zero copy(--auto_zc): 3.13M vs. 3.35M(BATCH_IO), +7%

Links: https://lore.kernel.org/linux-block/[email protected]/
Links: https://lore.kernel.org/linux-block/[email protected]/
Links: https://lore.kernel.org/linux-block/[email protected]/
Links: https://lore.kernel.org/linux-block/[email protected]/
Links: https://lore.kernel.org/linux-block/[email protected]/

This patchset is based on for-7.0/block with the following two patches:

	[PATCH v4] ublk: fix ublksrv pid handling for pid namespaces ( https://lore.kernel.org/linux-block/[email protected]/ )

	[PATCH 0/3] selftests/ublk: three bug fixes ( https://lore.kernel.org/linux-block/[email protected]/ ) 

V6:
- rebase on for-7.0/block
- fix ublk_handle_non_batch_cmd() (Caleb Sander Mateos)
- add ublk: refactor ublk_queue_rq() and add ublk_batch_queue_rq() (Caleb Sander Mateos)
- add ublk: fix batch I/O recovery -ENODEV error
- increase selftest timeout for running more things in some generic tests
- fix kublk utility wrt. ->cmd_inflight accounting for BATCH_IO
- pass all selftest after applying the io_uring cancel fix

V5:
- rebase on for-6.19/block
- fix fetch command leak in ublk_batch_attach() by marking correct uring_cmd as cancellable
- add ublk_batch_queue_rqs() for building per-queue batch
- add __ublk_deinit_queue() for fixing failure path of initializing queue(Caleb Sander Mateos)
- explicitly disable UBLK_F_NEED_GET_DATA for BATCH_IO(Caleb Sander Mateos)
- kill unnecessary check in ublk_batch_commit_io_check()(Caleb Sander Mateos)
- rename ublk_batch_fcmd as ublk_batch_fetch_cmd(Caleb Sander Mateos)
- improve ublk_batch_dispatch() by not running inline dispatch for different fetch command(Caleb Sander Mateos)
- use READ_ONCE() for reading all ubq->active_fcmd(Caleb Sander Mateos)
- simplify ublk_abort_batch_queue()(Caleb Sander Mateos)
- improve handling for non-batch commands(Caleb Sander Mateos)
- document fetch command lifetime(Caleb Sander Mateos)
- patch style, sizeof(tag), signed/unsigned changes(Caleb Sander Mateos)
- add recovery function test for BATCH_IO in generic_04/genereic_05

V4:
- fix handling in case of running out of mshot buffer, request has to be un-prepared for zero copy
- don't expose unused tag to userspace
- replace fixed buffer with plain user buffer for UBLK_U_IO_PREP_IO_CMDS and UBLK_U_IO_COMMIT_IO_CMDS
- replace iov iterator with plain copy_from_user() for ublk_walk_cmd_buf(), code is simplified with performance improvement
- don't touch sqe->len for UBLK_U_IO_PREP_IO_CMDS and UBLK_U_IO_COMMIT_IO_CMDS(Caleb Sander Mateos)
- use READ_ONCE() for access sqe->addr (Caleb Sander Mateos)
- all kinds of patch style fix(Caleb Sander Mateos)
- inline __kfifo_alloc() (Caleb Sander Mateos)

V3:
- rebase on for-6.19/block
- use blk_mq_end_request_batch() to free requests in batch, only for page copy
- fix one IO hang issue because of memory barrier order, comments on the memory barrier pairing
- add NUMA ware kfifo_alloc_node()
- fix one build warning reported by 0-DAY CI
- selftests improvement & fix

V2:
- ublk_config_io_buf() vs. __ublk_fetch() order
- code style clean
- use READ_ONCE() to cache sqe data because sqe copy becomes conditional recently
- don't use sqe->len for UBLK_U_IO_PREP_IO_CMDS & UBLK_U_IO_COMMIT_IO_CMDS
- fix one build warning
- fix build_user_data()
- run performance analysis, and find one bug in io_uring_cmd_buffer_select(), fix is posted already

Ming Lei (24):
ublk: define ublk_ch_batch_io_fops for the coming feature F_BATCH_IO
ublk: prepare for not tracking task context for command batch
ublk: add new batch command UBLK_U_IO_PREP_IO_CMDS &
UBLK_U_IO_COMMIT_IO_CMDS
ublk: handle UBLK_U_IO_PREP_IO_CMDS
ublk: handle UBLK_U_IO_COMMIT_IO_CMDS
ublk: add io events fifo structure
ublk: add batch I/O dispatch infrastructure
ublk: add UBLK_U_IO_FETCH_IO_CMDS for batch I/O processing
ublk: refactor ublk_queue_rq() and add ublk_batch_queue_rq()
ublk: abort requests filled in event kfifo
ublk: add new feature UBLK_F_BATCH_IO
ublk: document feature UBLK_F_BATCH_IO
ublk: implement batch request completion via
blk_mq_end_request_batch()
ublk: fix batch I/O recovery -ENODEV error
selftests: ublk: fix user_data truncation for tgt_data >= 256
selftests: ublk: replace assert() with ublk_assert()
selftests: ublk: add ublk_io_buf_idx() for returning io buffer index
selftests: ublk: add batch buffer management infrastructure
selftests: ublk: handle UBLK_U_IO_PREP_IO_CMDS
selftests: ublk: handle UBLK_U_IO_COMMIT_IO_CMDS
selftests: ublk: handle UBLK_U_IO_FETCH_IO_CMDS
selftests: ublk: increase timeout to 150 seconds
selftests: ublk: add --batch/-b for enabling F_BATCH_IO
selftests: ublk: support arbitrary threads/queues combination

 Documentation/block/ublk.rst                  |   64 +-
 drivers/block/ublk_drv.c                      | 1303 ++++++++++++++++-
 include/uapi/linux/ublk_cmd.h                 |   84 ++
 tools/testing/selftests/ublk/Makefile         |    8 +
 tools/testing/selftests/ublk/batch.c          |  607 ++++++++
 tools/testing/selftests/ublk/common.c         |    2 +-
 tools/testing/selftests/ublk/file_backed.c    |   11 +-
 tools/testing/selftests/ublk/kublk.c          |  149 +-
 tools/testing/selftests/ublk/kublk.h          |  195 ++-
 tools/testing/selftests/ublk/null.c           |   18 +-
 tools/testing/selftests/ublk/settings         |    1 +
 tools/testing/selftests/ublk/stripe.c         |   17 +-
 tools/testing/selftests/ublk/test_batch_01.sh |   32 +
 tools/testing/selftests/ublk/test_batch_02.sh |   30 +
 tools/testing/selftests/ublk/test_batch_03.sh |   30 +
 .../testing/selftests/ublk/test_generic_04.sh |    5 +
 .../testing/selftests/ublk/test_generic_05.sh |    5 +
 .../testing/selftests/ublk/test_stress_08.sh  |   45 +
 .../testing/selftests/ublk/test_stress_09.sh  |   44 +
 tools/testing/selftests/ublk/utils.h          |   64 +
 20 files changed, 2569 insertions(+), 145 deletions(-)
 create mode 100644 tools/testing/selftests/ublk/batch.c
 create mode 100644 tools/testing/selftests/ublk/settings
 create mode 100755 tools/testing/selftests/ublk/test_batch_01.sh
 create mode 100755 tools/testing/selftests/ublk/test_batch_02.sh
 create mode 100755 tools/testing/selftests/ublk/test_batch_03.sh
 create mode 100755 tools/testing/selftests/ublk/test_stress_08.sh
 create mode 100755 tools/testing/selftests/ublk/test_stress_09.sh
Signature · 1 line
2.47.0