ublk: add UBLK_F_BATCH_IO
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest24 patches 7 repliesApplied
- v521 patches 14 repliesSuperseded
- v427 patches 38 repliesApplied
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 27 patches | 21 replies | Superseded | |
| v2 | 25 patches | 0 replies | Superseded | |
| v1 | 23 patches | 18 replies | Superseded |
Changes in v6 from the cover letter
- rebase on for-7.0/block
- fix ublk_handle_non_batch_cmd() (Caleb Sander Mateos)
- add ublk: refactor ublk_queue_rq() and add ublk_batch_queue_rq() (Caleb Sander Mateos)
- add ublk: fix batch I/O recovery -ENODEV error
- increase selftest timeout for running more things in some generic tests
- fix kublk utility wrt. ->cmd_inflight accounting for BATCH_IO
- pass all selftest after applying the io_uring cancel fix
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/24 | ublk: define ublk_ch_batch_io_fops for the coming feature F_BATCH_IOdrivers/ | +25 | 0 replies | |
| 2/24 | ublk: prepare for not tracking task context for command batchdrivers/ | +4 | 0 replies | |
| 3/24 | ublk: add new batch command UBLK_U_IO_PREP_IO_CMDS & UBLK_U_IO_COMMIT_IO_CMDSdrivers/ include/ | +135 | 0 replies | |
| 4/24 | ublk: handle UBLK_U_IO_PREP_IO_CMDSdrivers/ include/ | +195 | 1 reply | |
| 5/24 | ublk: handle UBLK_U_IO_COMMIT_IO_CMDSdrivers/ include/ | +109 | 0 replies | |
| 6/24 | ublk: add io events fifo structuredrivers/ | +63 | 0 replies | |
| 7/24 | ublk: add batch I/O dispatch infrastructuredrivers/ | +195 | 2 replies | |
| 8/24 | ublk: add UBLK_U_IO_FETCH_IO_CMDS for batch I/O processingdrivers/ include/ | +393 | 0 replies | |
| 9/24 | ublk: refactor ublk_queue_rq() and add ublk_batch_queue_rq()drivers/ | +46 | 1 reply | |
| 10/24 | ublk: abort requests filled in event kfifodrivers/ | +23 | 0 replies | |
| 11/24 | ublk: add new feature UBLK_F_BATCH_IOdrivers/ include/ | +67 | 0 replies | |
| 12/24 | ublk: document feature UBLK_F_BATCH_IODocumentation/ | +60 | 0 replies | |
| 13/24 | ublk: implement batch request completion via blk_mq_end_request_batch()drivers/ | +17 | 0 replies | |
| 14/24 | ublk: fix batch I/O recovery -ENODEV errordrivers/ | +60 | 1 reply | |
| 15/24 | selftests: ublk: fix user_data truncation for tgt_data >= 256tools/ | +1 | 0 replies | |
| 16/24 | selftests: ublk: replace assert() with ublk_assert()tools/ tools/ tools/ +3 more | +19 | 0 replies | |
| 17/24 | selftests: ublk: add ublk_io_buf_idx() for returning io buffer indextools/ tools/ tools/ +2 more | +33 | 0 replies | |
| 18/24 | selftests: ublk: add batch buffer management infrastructuretools/ tools/ tools/ +1 more | +282 | 0 replies | |
| 19/24 | selftests: ublk: handle UBLK_U_IO_PREP_IO_CMDStools/ tools/ tools/ | +174 | 0 replies | |
| 20/24 | selftests: ublk: handle UBLK_U_IO_COMMIT_IO_CMDStools/ tools/ tools/ | +122 | 0 replies | |
| 21/24 | selftests: ublk: handle UBLK_U_IO_FETCH_IO_CMDStools/ tools/ tools/ | +159 | 0 replies | |
| 22/24 | selftests: ublk: increase timeout to 150 secondstools/ tools/ | +3 | 0 replies | |
| 23/24 | selftests: ublk: add --batch/-b for enabling F_BATCH_IOtools/ tools/ tools/ +4 more | +148 | 0 replies | |
| 24/24 | selftests: ublk: support arbitrary threads/queues combinationtools/ tools/ tools/ +3 more | +302 | 0 replies |
Reviews trailers per patch
13 of 24 patches have a Reviewed-by or Acked-by.
| Patch | Caleb Sander Mateos |
|---|---|
| 1/24 | R-b |
| 2/24 | R-b |
| 3/24 | R-b |
| 4/24 | R-b |
| 5/24 | R-b |
| 6/24 | R-b |
| 7/24 | R-b |
| 8/24 | R-b |
| 9/24 | R-b |
| 10/24 | R-b |
| 11/24 | R-b |
| 12/24 | R-b |
| 13/24 | R-b |
| 14/24 | |
| 15/24 | |
| 16/24 | |
| 17/24 | |
| 18/24 | |
| 19/24 | |
| 20/24 | |
| 21/24 | |
| 22/24 | |
| 23/24 | |
| 24/24 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH V6 00/24] ublk: add UBLK_F_BATCH_IO
Hello,
This patchset adds UBLK_F_BATCH_IO feature for communicating between kernel and ublk server in batching way:
- Per-queue vs Per-I/O: Commands operate on queues rather than individual I/Os
- Batch processing: Multiple I/Os are handled in single operation
- Multishot commands: Use io_uring multishot for reducing submission overhead
- Flexible task assignment: Any task can handle any I/O (no per-I/O daemons)
- Better load balancing: Tasks can adjust their workload dynamically
- help for future optimizations:
- blk-mq batch tags free
- support io-poll
- per-task batch for avoiding per-io lock
- fetch command priority
- simplify command cancel process with per-queue lock
selftest are provided.
Performance test result(IOPS) on V3:
- page copy
tools/testing/selftests/ublk//kublk add -t null -q 16 [-b]
- zero copy(--auto_zc) tools/testing/selftests/ublk//kublk add -t null -q 16 --auto_zc [-b]
- IO test
taskset -c 0-31 fio/t/io_uring -p0 -n $JOBS -r 30 /dev/ublkb0
1) 16 jobs IO
- page copy: 37.77M vs. 42.40M(BATCH_IO), +12%
- zero copy(--auto_zc): 42.83M vs. 44.43M(BATCH_IO), +3.7%
2) single job IO
- page copy: 2.54M vs. 2.6M(BATCH_IO), +2.3%
- zero copy(--auto_zc): 3.13M vs. 3.35M(BATCH_IO), +7%
Links: https://lore.kernel.org/linux-block/[email protected]/
Links: https://lore.kernel.org/linux-block/[email protected]/
Links: https://lore.kernel.org/linux-block/[email protected]/
Links: https://lore.kernel.org/linux-block/[email protected]/
Links: https://lore.kernel.org/linux-block/[email protected]/
This patchset is based on for-7.0/block with the following two patches:
[PATCH v4] ublk: fix ublksrv pid handling for pid namespaces ( https://lore.kernel.org/linux-block/[email protected]/ ) [PATCH 0/3] selftests/ublk: three bug fixes ( https://lore.kernel.org/linux-block/[email protected]/ )
V6:
- rebase on for-7.0/block
- fix ublk_handle_non_batch_cmd() (Caleb Sander Mateos)
- add ublk: refactor ublk_queue_rq() and add ublk_batch_queue_rq() (Caleb Sander Mateos)
- add ublk: fix batch I/O recovery -ENODEV error
- increase selftest timeout for running more things in some generic tests
- fix kublk utility wrt. ->cmd_inflight accounting for BATCH_IO
- pass all selftest after applying the io_uring cancel fix
V5:
- rebase on for-6.19/block
- fix fetch command leak in ublk_batch_attach() by marking correct uring_cmd as cancellable
- add ublk_batch_queue_rqs() for building per-queue batch
- add __ublk_deinit_queue() for fixing failure path of initializing queue(Caleb Sander Mateos)
- explicitly disable UBLK_F_NEED_GET_DATA for BATCH_IO(Caleb Sander Mateos)
- kill unnecessary check in ublk_batch_commit_io_check()(Caleb Sander Mateos)
- rename ublk_batch_fcmd as ublk_batch_fetch_cmd(Caleb Sander Mateos)
- improve ublk_batch_dispatch() by not running inline dispatch for different fetch command(Caleb Sander Mateos)
- use READ_ONCE() for reading all ubq->active_fcmd(Caleb Sander Mateos)
- simplify ublk_abort_batch_queue()(Caleb Sander Mateos)
- improve handling for non-batch commands(Caleb Sander Mateos)
- document fetch command lifetime(Caleb Sander Mateos)
- patch style, sizeof(tag), signed/unsigned changes(Caleb Sander Mateos)
- add recovery function test for BATCH_IO in generic_04/genereic_05
V4:
- fix handling in case of running out of mshot buffer, request has to be un-prepared for zero copy
- don't expose unused tag to userspace
- replace fixed buffer with plain user buffer for UBLK_U_IO_PREP_IO_CMDS and UBLK_U_IO_COMMIT_IO_CMDS
- replace iov iterator with plain copy_from_user() for ublk_walk_cmd_buf(), code is simplified with performance improvement
- don't touch sqe->len for UBLK_U_IO_PREP_IO_CMDS and UBLK_U_IO_COMMIT_IO_CMDS(Caleb Sander Mateos)
- use READ_ONCE() for access sqe->addr (Caleb Sander Mateos)
- all kinds of patch style fix(Caleb Sander Mateos)
- inline __kfifo_alloc() (Caleb Sander Mateos)
V3:
- rebase on for-6.19/block
- use blk_mq_end_request_batch() to free requests in batch, only for page copy
- fix one IO hang issue because of memory barrier order, comments on the memory barrier pairing
- add NUMA ware kfifo_alloc_node()
- fix one build warning reported by 0-DAY CI
- selftests improvement & fix
V2:
- ublk_config_io_buf() vs. __ublk_fetch() order
- code style clean
- use READ_ONCE() to cache sqe data because sqe copy becomes conditional recently
- don't use sqe->len for UBLK_U_IO_PREP_IO_CMDS & UBLK_U_IO_COMMIT_IO_CMDS
- fix one build warning
- fix build_user_data()
- run performance analysis, and find one bug in io_uring_cmd_buffer_select(), fix is posted already
Ming Lei (24):
ublk: define ublk_ch_batch_io_fops for the coming feature F_BATCH_IO
ublk: prepare for not tracking task context for command batch
ublk: add new batch command UBLK_U_IO_PREP_IO_CMDS &
UBLK_U_IO_COMMIT_IO_CMDS
ublk: handle UBLK_U_IO_PREP_IO_CMDS
ublk: handle UBLK_U_IO_COMMIT_IO_CMDS
ublk: add io events fifo structure
ublk: add batch I/O dispatch infrastructure
ublk: add UBLK_U_IO_FETCH_IO_CMDS for batch I/O processing
ublk: refactor ublk_queue_rq() and add ublk_batch_queue_rq()
ublk: abort requests filled in event kfifo
ublk: add new feature UBLK_F_BATCH_IO
ublk: document feature UBLK_F_BATCH_IO
ublk: implement batch request completion via
blk_mq_end_request_batch()
ublk: fix batch I/O recovery -ENODEV error
selftests: ublk: fix user_data truncation for tgt_data >= 256
selftests: ublk: replace assert() with ublk_assert()
selftests: ublk: add ublk_io_buf_idx() for returning io buffer index
selftests: ublk: add batch buffer management infrastructure
selftests: ublk: handle UBLK_U_IO_PREP_IO_CMDS
selftests: ublk: handle UBLK_U_IO_COMMIT_IO_CMDS
selftests: ublk: handle UBLK_U_IO_FETCH_IO_CMDS
selftests: ublk: increase timeout to 150 seconds
selftests: ublk: add --batch/-b for enabling F_BATCH_IO
selftests: ublk: support arbitrary threads/queues combination
Documentation/block/ublk.rst | 64 +- drivers/block/ublk_drv.c | 1303 ++++++++++++++++- include/uapi/linux/ublk_cmd.h | 84 ++ tools/testing/selftests/ublk/Makefile | 8 + tools/testing/selftests/ublk/batch.c | 607 ++++++++ tools/testing/selftests/ublk/common.c | 2 +- tools/testing/selftests/ublk/file_backed.c | 11 +- tools/testing/selftests/ublk/kublk.c | 149 +- tools/testing/selftests/ublk/kublk.h | 195 ++- tools/testing/selftests/ublk/null.c | 18 +- tools/testing/selftests/ublk/settings | 1 + tools/testing/selftests/ublk/stripe.c | 17 +- tools/testing/selftests/ublk/test_batch_01.sh | 32 + tools/testing/selftests/ublk/test_batch_02.sh | 30 + tools/testing/selftests/ublk/test_batch_03.sh | 30 + .../testing/selftests/ublk/test_generic_04.sh | 5 + .../testing/selftests/ublk/test_generic_05.sh | 5 + .../testing/selftests/ublk/test_stress_08.sh | 45 + .../testing/selftests/ublk/test_stress_09.sh | 44 + tools/testing/selftests/ublk/utils.h | 64 + 20 files changed, 2569 insertions(+), 145 deletions(-) create mode 100644 tools/testing/selftests/ublk/batch.c create mode 100644 tools/testing/selftests/ublk/settings create mode 100755 tools/testing/selftests/ublk/test_batch_01.sh create mode 100755 tools/testing/selftests/ublk/test_batch_02.sh create mode 100755 tools/testing/selftests/ublk/test_batch_03.sh create mode 100755 tools/testing/selftests/ublk/test_stress_08.sh create mode 100755 tools/testing/selftests/ublk/test_stress_09.sh
Signature · 1 line
2.47.0