Skip to content

io_uring: use release-acquire ordering for IORING_SETUP_R_DISABLED

Caleb Sander Mateos io-uring lkml 7 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 7 repliesApplied
  2. v66 patches 3 repliesSuperseded
  3. v56 patches 11 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v45 patches3 repliesSuperseded
v34 patches1 replySuperseded
v25 patches12 repliesApplied
v14 patches5 repliesSuperseded

Changes in v7 from the cover letter

- Split from IORING_SETUP_SINGLE_ISSUER optimization series
- Drop unnecessary submitter_task {READ,WRITE}_ONCE() and NULL checks
- Drop redundant submitter_task check in io_register_enable_rings()
- Add comments explaining need for release-acquire ordering

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/3io_uring: use release-acquire ordering for IORING_SETUP_R_DISABLEDio_uring/io_uring.c io_uring/msg_ring.c io_uring/register.c+17 -40 replies
2/3io_uring/msg_ring: drop unnecessary submitter_task checksio_uring/io_uring.c io_uring/msg_ring.c io_uring/register.c+7 -203 replies
3/3io_uring/register: drop io_register_enable_rings() submitter_task checkio_uring/register.c+1 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJoanne KoongGabriel Krisman Bertazi
SeriesR-b
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/3] io_uring: use release-acquire ordering for IORING_SETUP_R_DISABLED

io_uring_enter(), __io_msg_ring_data(), and io_msg_send_fd() read ctx->flags and ctx->submitter_task without holding the ctx's uring_lock. This means they may race with the assignment to ctx->submitter_task and the clearing of IORING_SETUP_R_DISABLED from ctx->flags in io_register_enable_rings(). Ensure the correct ordering of the ctx->flags and ctx->submitter_task memory accesses by storing to ctx->flags using release ordering and loading it using acquire ordering.

Using release-acquire ordering for IORING_SETUP_R_DISABLED ensures the assignment to ctx->submitter_task in io_register_enable_rings() can't race with msg_ring's accesses, so drop the unneeded {READ,WRITE}_ONCE() and the NULL checks.

v7:
- Split from IORING_SETUP_SINGLE_ISSUER optimization series
- Drop unnecessary submitter_task {READ,WRITE}_ONCE() and NULL checks
- Drop redundant submitter_task check in io_register_enable_rings()
- Add comments explaining need for release-acquire ordering

Caleb Sander Mateos (3):
io_uring: use release-acquire ordering for IORING_SETUP_R_DISABLED io_uring/msg_ring: drop unnecessary submitter_task checks io_uring/register: drop io_register_enable_rings() submitter_task
check

 io_uring/io_uring.c | 13 ++++++-------
 io_uring/msg_ring.c | 28 ++++++++++++++--------------
 io_uring/register.c |  7 ++++---
 3 files changed, 24 insertions(+), 24 deletions(-)
Signature · 1 line
2.45.2