Skip to content

Add SDCA UMP/FDL support

Charles Keepax linux-sound 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/219 patches 4 repliesIn review
  2. v3 posting 1/219 patches 1 replySuperseded
  3. v20 of 20 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v115 patches34 repliesSuperseded

Changes in v3 from the cover letter

- Add mutex to lock between UMP timeout work and IRQ handlers
- Clean up UMP timeout work after FDL fails
- Use IRQ number rather than a boolean to track used IRQs
- Reduce FDL retries to 6
- Check disk size of firmwares
- Reset on more FDL failure paths
- Reorder volatile control check by entity

Patches in v3 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19ASoC: SDCA: Rename SoundWire struct device variablessound/soc/sdca/sdca_functions.c sound/soc/sdca/sdca_interrupts.c+10 -100 replies
2/19regmap: sdw-mbq: Don't assume the regmap device is the SoundWire slavedrivers/base/regmap/regmap-sdw-mbq.c include/linux/regmap.h sound/soc/codecs/rt722-sdca-sdw.c+26 -220 replies
3/19ASoC: SDCA: Add manual PM runtime gets to IRQ handlerssound/soc/sdca/sdca_interrupts.c+32 -100 replies
4/19ASoC: SDCA: Pass SoundWire slave to HIDinclude/sound/sdca_function.h include/sound/sdca_hid.h sound/soc/sdca/sdca_functions.c +1 more+24 -180 replies
5/19ASoC: SDCA: Pass device register map from IRQ alloc to handlersinclude/sound/sdca_interrupts.h sound/soc/sdca/sdca_interrupts.c+6 -10 replies
6/19ASoC: SDCA: Update externally_requested flag to cover all requestsinclude/sound/sdca_interrupts.h sound/soc/sdca/sdca_interrupts.c+7 -80 replies
7/19ASoC: SDCA: Factor out a helper to find SDCA IRQ datasound/soc/sdca/sdca_interrupts.c+22 -140 replies
8/19ASoC: SDCA: Rely less on the ASoC component in IRQ handlinginclude/sound/sdca_interrupts.h sound/soc/sdca/sdca_interrupts.c+31 -130 replies
9/19ASoC: SDCA: Force some SDCA Controls to be volatileinclude/sound/sdca_function.h sound/soc/sdca/sdca_functions.c sound/soc/sdca/sdca_regmap.c+60 -80 replies
10/19ASoC: SDCA: Parse XU Entity propertiesinclude/sound/sdca_function.h sound/soc/sdca/sdca_functions.c+48 -00 replies
11/19ASoC: SDCA: Parse Function Reset max delayinclude/sound/sdca_function.h sound/soc/sdca/sdca_functions.c+11 -20 replies
12/19ASoC: SDCA: Add UMP buffer helper functionsinclude/sound/sdca_function.h include/sound/sdca_ump.h sound/soc/sdca/Makefile +1 more+320 -10 replies
13/19ASoC: SDCA: Add SDCA FDL data parsinginclude/sound/sdca.h include/sound/sdca_function.h sound/soc/sdca/sdca_device.c +1 more+158 -00 replies
14/19ASoC: SDCA: Add FDL library for XU entitiesinclude/sound/sdca_fdl.h include/sound/sdca_function.h sound/soc/sdca/Kconfig +2 more+467 -02 replies
15/19ASoC: SDCA: Add FDL-specific IRQ processingsound/soc/sdca/sdca_interrupts.c+34 -00 replies
16/19ASoC: SDCA: Add completion for FDL start and stopinclude/sound/sdca_fdl.h sound/soc/sdca/sdca_fdl.c+85 -00 replies
17/19ASoC: SDCA: Add UMP timeout handling for FDLinclude/sound/sdca_fdl.h include/sound/sdca_ump.h sound/soc/sdca/sdca_fdl.c +1 more+76 -10 replies
18/19ASoC: SDCA: Add early IRQ handlinginclude/sound/sdca_interrupts.h sound/soc/sdca/sdca_interrupts.c+74 -00 replies
19/19ASoC: SDCA: Add HID button IRQinclude/sound/sdca_hid.h sound/soc/sdca/sdca_hid.c sound/soc/sdca/sdca_interrupts.c+85 -20 replies

Reviews trailers per patch

All 19 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBard LiaoPierre-Louis Bossart
SeriesR-b
1/19R-b
2/19R-b
3/19R-b
4/19R-b
5/19R-b
6/19R-b
7/19R-b
8/19R-b
9/19R-b
10/19R-b
11/19R-b
12/19R-b
13/19R-b
14/19R-b
15/19R-b
16/19R-b
17/19R-b
18/19R-b
19/19R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 RESEND 00/19] Add SDCA UMP/FDL support

Next installment of the SDCA changes, hopefully the next series after this should be the full class driver. It is worth noting this series has a build dependency on a patch working its way through the PM/ACPI tree:

commit ac46f5b6c661 ("ACPICA: Add SoundWire File Table (SWFT) signature")
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git

But we can probably worry about that later, as normally there is a reasonable amount of review on these SDCA series'.

This series broadly breaks down into 3 chunks, first there are several changes to remove the assumption that the struct device used for SDCA purposes represents the SoundWire slave. This is because the SDCA class driver will be made of an auxiliary driver for each SDCA Function, thus the SoundWire slave will be on the parent device for each individual driver. Then there are patches to add support for UMP/FDL. And then finally since the rest of the HID support is there and UMP was the last missing part required a small patch to add a function to allow reporting of HID events from SDCA devices.

Thanks,
Charles

Changes since v2:
- Add mutex to lock between UMP timeout work and IRQ handlers
- Clean up UMP timeout work after FDL fails
- Use IRQ number rather than a boolean to track used IRQs
- Reduce FDL retries to 6
- Check disk size of firmwares
- Reset on more FDL failure paths
- Reorder volatile control check by entity

Changes since v1:
- Add timeout for UMP buffer transfers
- Add function reset
- Parse XU properties from DisCo
- Rename entity_xu library to FDL
- Add a limit to the number of times it will try the FDL process
- Rename soundwire device pointers to sdev to distinguish from Function devices pointers

Charles Keepax (16):
ASoC: SDCA: Rename SoundWire struct device variables
regmap: sdw-mbq: Don't assume the regmap device is the SoundWire slave
ASoC: SDCA: Add manual PM runtime gets to IRQ handlers
ASoC: SDCA: Pass SoundWire slave to HID
ASoC: SDCA: Pass device register map from IRQ alloc to handlers
ASoC: SDCA: Update externally_requested flag to cover all requests
ASoC: SDCA: Factor out a helper to find SDCA IRQ data
ASoC: SDCA: Rely less on the ASoC component in IRQ handling
ASoC: SDCA: Force some SDCA Controls to be volatile
ASoC: SDCA: Parse XU Entity properties
ASoC: SDCA: Parse Function Reset max delay
ASoC: SDCA: Add UMP buffer helper functions
ASoC: SDCA: Add completion for FDL start and stop
ASoC: SDCA: Add UMP timeout handling for FDL
ASoC: SDCA: Add early IRQ handling
ASoC: SDCA: Add HID button IRQ

Maciej Strozek (3):
ASoC: SDCA: Add SDCA FDL data parsing
ASoC: SDCA: Add FDL library for XU entities
ASoC: SDCA: Add FDL-specific IRQ processing

 drivers/base/regmap/regmap-sdw-mbq.c |  23 +-
 include/linux/regmap.h               |  21 +-
 include/sound/sdca.h                 |   5 +
 include/sound/sdca_fdl.h             |  75 ++++
 include/sound/sdca_function.h        | 119 ++++++-
 include/sound/sdca_hid.h             |  21 +-
 include/sound/sdca_interrupts.h      |  19 +-
 include/sound/sdca_ump.h             |  50 +++
 sound/soc/codecs/rt722-sdca-sdw.c    |   4 +-
 sound/soc/sdca/Kconfig               |   8 +
 sound/soc/sdca/Makefile              |   4 +-
 sound/soc/sdca/sdca_device.c         |  20 ++
 sound/soc/sdca/sdca_fdl.c            | 499 +++++++++++++++++++++++++++
 sound/soc/sdca/sdca_functions.c      | 212 +++++++++++-
 sound/soc/sdca/sdca_hid.c            |  58 +++-
 sound/soc/sdca/sdca_interrupts.c     | 271 ++++++++++++---
 sound/soc/sdca/sdca_regmap.c         |   9 +-
 sound/soc/sdca/sdca_ump.c            | 262 ++++++++++++++
 18 files changed, 1573 insertions(+), 107 deletions(-)
 create mode 100644 include/sound/sdca_fdl.h
 create mode 100644 include/sound/sdca_ump.h
 create mode 100644 sound/soc/sdca/sdca_fdl.c
 create mode 100644 sound/soc/sdca/sdca_ump.c
Signature · 1 line
2.47.3