Skip to content

Fix local destination address resolution with VRF

Edward Srouji linux-rdma lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4RDMA/core: Squash a single user static functiondrivers/infiniband/core/addr.c+20 -293 replies
1/4RDMA/core: Squash a single user static functiondrivers/infiniband/core/addr.c+20 -290 replies
2/4RDMA/core: Resolve MAC of next-hop device without ARP supportdrivers/infiniband/core/addr.c+3 -74 replies
2/4RDMA/core: Resolve MAC of next-hop device without ARP supportdrivers/infiniband/core/addr.c+3 -70 replies
3/4RDMA/core: Use route entry flag to decide on loopback trafficdrivers/infiniband/core/addr.c+21 -130 replies
3/4RDMA/core: Use route entry flag to decide on loopback trafficdrivers/infiniband/core/addr.c+21 -130 replies
4/4IB/ipoib: Ignore L3 master devicedrivers/infiniband/ulp/ipoib/ipoib_main.c+11 -100 replies
4/4IB/ipoib: Ignore L3 master devicedrivers/infiniband/ulp/ipoib/ipoib_main.c+11 -100 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchVlad DumitrescuParav Pandit
1/4R-b R-b
1/4R-b R-b
2/4R-b R-b
2/4R-b R-b
3/4R-b R-b
3/4R-b R-b
4/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Fix local destination address resolution with VRF

From Parav:

Presently, address resolve routines consider a destination to be local if the next-hop device of the resolved route for the destination is the loopback netdevice. While this works for simple configurations, it fails when the source and destination IP addresses belong to an enslaved netdevice of a VRF.
In that case the next-hop device is the VRF itself, so packets are generated with an incorrect destination MAC on the VRF netdevice and ib_write_bw times out.

This patch series fixes that by determining whether a destination is local based on the resolved route's type rather than on the next-hop netdevice's loopback flag.
That approach resolves loopback traffic consistently both with and without VRF configurations.

This series contains 4 patches:
1/4: refactor address resolution code for reuse by subsequent patches 2/4: resolve destination MAC via IP stack
3/4: use route table entry instead of netdev loopback flag 4/4: fix netdev lookup for IPoIB interfaces

Parav.

Parav Pandit (3):
RDMA/core: Squash a single user static function RDMA/core: Resolve MAC of next-hop device without ARP support RDMA/core: Use route entry flag to decide on loopback traffic

Vlad Dumitrescu (1):
IB/ipoib: Ignore L3 master device

 drivers/infiniband/core/addr.c            | 83 +++++++++++------------
 drivers/infiniband/ulp/ipoib/ipoib_main.c | 21 +++---
 2 files changed, 50 insertions(+), 54 deletions(-)
Signature · 1 line
2.21.3