Skip to content

v4l2-subdev/int3472: Use "privacy" as con_id for the LED lookup

Hans de Goede linux-media platform-driver-x86 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest1 patch 6 repliesIn review
  2. v12 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Squash the changes into a single patch changing both places where "privacy-led" is used to "privacy" in one go

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1media: v4l2-subdev / pdx86: int3472: Use "privacy" as con_id for the privacy LEDdrivers/media/v4l2-core/v4l2-subdev.c drivers/platform/x86/intel/int3472/led.c+2 -26 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchIlpo Järvinen
1/1A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/1] v4l2-subdev/int3472: Use "privacy" as con_id for the LED lookup

Hi All,

During DT-binding review for extending the V4L2 camera sensor privacy LED support to systems using devicetree, it has come up that having a "-led" suffix for the LED name / con_id is undesirable since it already is clear that it is a LED:

https://lore.kernel.org/linux-media/[email protected]/

There was discussion about making an exception for "privacy-led" since that is already used on x86/ACPI platforms, but I'm afraid that will set a bad example which ends up being copy and pasted, so lets just drop the "-led" prefix from the x86/ACPI side, which we can do since there this is only an in-kernel "API".

Changes in v2:
- Squash the changes into a single patch changing both places where "privacy-led" is used to "privacy" in one go

Ilpo can you give your ack for this patch getting merged through the linux-media tree?

Regards,

Hans

Hans de Goede (1):
media: v4l2-subdev / pdx86: int3472: Use "privacy" as con_id for the
privacy LED

 drivers/media/v4l2-core/v4l2-subdev.c    | 2 +-
 drivers/platform/x86/intel/int3472/led.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.51.0