Skip to content

RFC mm/damon: define and use DAMON initialization check function

SeongJae Park damon linux-mm lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7mm/damon/core: implement damon_initialized() functioninclude/linux/damon.h mm/damon/core.c+11 -00 replies
2/7mm/damon/stat: use damon_initialized()mm/damon/stat.c+6 -40 replies
3/7mm/damon/reclaim: use damon_initialized()mm/damon/reclaim.c+7 -20 replies
4/7mm/damon/lru_sort: use damon_initialized()mm/damon/lru_sort.c+7 -20 replies
5/7samples/damon/wsse: use damon_initialized()samples/damon/wsse.c+9 -60 replies
6/7samples/damon/prcl: use damon_initialized()samples/damon/prcl.c+7 -40 replies
7/7samples/damon/mtier: use damon_initialized()samples/damon/mtier.c+7 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/7] mm/damon: define and use DAMON initialization check function

If DAMON is tried to be used by its API callers when it is not yet successfully initialized, the callers could be crashed. Such issues actually happened and were fixed [1]. DAMON API callers are therefore having their own hacks for seeing if it is safe to use DAMON or not. Those built on an untreliable assumption that DAMON should be ready to be used on module init time. DAMON initialization could fail if KMEM_CACHE() fails, though. Also those are basically duplications that make their maintenance difficult.

Make it reliable and easy to maintain, by implementing a new DAMON core layer API function for seeing if DAMON is ready to be used or not, and replacing the hacks of DAMON API callers with the new core layer function.

[1] https://lore.kernel.org/[email protected]

SeongJae Park (7):
mm/damon/core: implement damon_initialized() function mm/damon/stat: use damon_initialized() mm/damon/reclaim: use damon_initialized() mm/damon/lru_sort: use damon_initialized() samples/damon/wsse: use damon_initialized() samples/damon/prcl: use damon_initialized() samples/damon/mtier: use damon_initialized()

 include/linux/damon.h |  1 +
 mm/damon/core.c       | 10 ++++++++++
 mm/damon/lru_sort.c   |  9 +++++++--
 mm/damon/reclaim.c    |  9 +++++++--
 mm/damon/stat.c       | 10 ++++++----
 samples/damon/mtier.c | 11 +++++++----
 samples/damon/prcl.c  | 11 +++++++----
 samples/damon/wsse.c  | 15 +++++++++------
 8 files changed, 54 insertions(+), 22 deletions(-)

base-commit: f115189b48629e7a8aa707112190b7ccf9928d6b

Signature · 1 line
2.39.5