Allow configfs to disable specific GT type(s)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest23 patches 2 repliesIn review
- v423 patches 17 repliesSuperseded
- v323 patches 21 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 22 patches | 16 replies | Superseded | |
| v1 | 2 patches | 4 replies | Superseded |
Changes in v5 from the cover letter
- Add a missing vm_max_level setting. (Gustavo)
- Rename xe_configfs_*_gt_supported to xe_configfs_*_gt_allowed for consistency with configfs interface and other functions. (Gustavo)
- Make new configfs functions take 'struct pci_dev' instead of 'struct xe_device' for consistency with other configfs helpers. (Michal)
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/23 | drm/xe/huc: Adjust HuC check on primary GTdrivers/ | +7 | 0 replies | |
| 2/23 | drm/xe: Drop GT parameter to xe_display_irq_postinstall()drivers/ drivers/ drivers/ | +5 | 0 replies | |
| 3/23 | drm/xe: Move 'va_bits' flag back to platform descriptordrivers/ drivers/ | +16 | 0 replies | |
| 4/23 | drm/xe: Move 'vm_max_level' flag back to platform descriptordrivers/ drivers/ | +16 | 0 replies | |
| 5/23 | drm/xe: Move 'vram_flags' flag back to platform descriptordrivers/ drivers/ | +5 | 0 replies | |
| 6/23 | drm/xe: Move 'has_flatccs' flag back to platform descriptordrivers/ drivers/ | +7 | 0 replies | |
| 7/23 | drm/xe: Read VF GMD_ID with a specifically-allocated dummy GTdrivers/ drivers/ | +45 | 0 replies | |
| 8/23 | drm/xe: Move primary GT allocation from xe_tile_init_early to xe_tile_initdrivers/ drivers/ | +4 | 0 replies | |
| 9/23 | drm/xe: Skip L2 / TDF cache flushes if primary GT is disableddrivers/ | +5 | 0 replies | |
| 10/23 | drm/xe/query: Report hwconfig size as 0 if primary GT is disableddrivers/ | +1 | 0 replies | |
| 11/23 | drm/xe/pmu: Initialize PMU event types based on first available GTdrivers/ | +10 | 0 replies | |
| 12/23 | drm/xe: Check for primary GT before looking up Wa_22019338487drivers/ | +22 | 0 replies | |
| 13/23 | drm/xe: Make display part of Wa_22019338487 a device workarounddrivers/ drivers/ drivers/ +1 more | +5 | 0 replies | |
| 14/23 | drm/xe/irq: Don't try to lookup engine masks for non-existent primary GTdrivers/ | +8 | 0 replies | |
| 15/23 | drm/xe: Handle Wa_22010954014 and Wa_14022085890 as device workaroundsdrivers/ drivers/ drivers/ +4 more | +17 | 0 replies | |
| 16/23 | drm/xe/rtp: Pass xe_device parameter to FUNC matchesdrivers/ drivers/ drivers/ +3 more | +41 | 0 replies | |
| 17/23 | drm/xe: Bypass Wa_14018094691 when primary GT is disableddrivers/ | +2 | 0 replies | |
| 18/23 | drm/xe: Correct lineage for Wa_22014953428 and only check with valid GTdrivers/ drivers/ | +3 | 0 replies | |
| 19/23 | drm/xe: Check that GT is not NULL before testing Wa_16023588340drivers/ | +2 | 0 replies | |
| 20/23 | drm/xe: Don't check BIOS-disabled FlatCCS if primary GT is disableddrivers/ | +2 | 0 replies | |
| 21/23 | drm/xe: Break GT setup out of xe_info_init()drivers/ | +54 | 0 replies | |
| 22/23 | drm/xe/configfs: Add attribute to disable GT typesdrivers/ drivers/ drivers/ | +170 | 0 replies | |
| 23/23 | drm/xe/sriov: Disable SR-IOV if primary GT is disabled via configfsdrivers/ | +2 | 1 reply |
Reviews trailers per patch
All 23 patches have a Reviewed-by or Acked-by.
| Patch | Daniele Ceraolo Spurio | Tejas Upadhyay | Lucas De Marchi | Gustavo Sousa | Michal Wajdeczko |
|---|---|---|---|---|---|
| 1/23 | R-b | R-b | |||
| 2/23 | R-b | ||||
| 3/23 | R-b | ||||
| 4/23 | R-b | R-b | |||
| 5/23 | R-b | ||||
| 6/23 | R-b | ||||
| 7/23 | R-b | ||||
| 8/23 | R-b | ||||
| 9/23 | R-b | ||||
| 10/23 | R-b | ||||
| 11/23 | R-b | ||||
| 12/23 | R-b | R-b | |||
| 13/23 | R-b | ||||
| 14/23 | R-b | ||||
| 15/23 | R-b | ||||
| 16/23 | R-b | ||||
| 17/23 | R-b | ||||
| 18/23 | R-b | ||||
| 19/23 | R-b | ||||
| 20/23 | R-b | ||||
| 21/23 | R-b | R-b | |||
| 22/23 | R-b | ||||
| 23/23 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v5 00/23] Allow configfs to disable specific GT type(s)
During various debug or hardware bring-up activities, it is often useful to completely disable one of the GTs to reduce the scope of the debug. Add a configfs attribute to make this easy to do in a standard manner, similar to the existing attribute we have to limit engines.
One of the changes in this series is that we reverse direction on the placement of a few feature flags. Previously we had moved things like number of page table levels, size of the virtual address space, or presence/absence of FlatCCS into the graphics descriptor to tie it to the general architecture (Xe2, Xe3, etc.). But upon further reflection, these kind of flags and values are truly platform-specific characteristics rather than being tied just to the graphics IP. The value of these winds up being platform-wide (as already evidenced by the fact that we copied their values into xe->info rather than gt->info) and all IP blocks in a hardware platform (graphics, media, and display) are going to have a consistent understanding of these characteristics; they're not just "graphics" values, and we need to be able to detect and handle them properly even when "graphics" (in the form of the primary GT) is absent. So this series moves some of those flags back into the platform-level descriptors and tries to keep the graphics descriptor's fields focused on values that are truly tied to the primary GT.
Note that at the moment it's only possible to disable the media GT. Although this series includes a number of patches aimed at reducing the driver's reliance on the primary GT and assumptions that the primary GT will always be present and non-NULL, we're not quite at the point where the driver can actually run with primary GT disabled. The main remaining blocker for that is the reliance on the BCS engines (which reside in the primary GT) for various VRAM and migration operations. Additional work after this series will be required to eliminate those dependencies.
v5:
- Add a missing vm_max_level setting. (Gustavo)
- Rename xe_configfs_*_gt_supported to xe_configfs_*_gt_allowed for consistency with configfs interface and other functions. (Gustavo)
- Make new configfs functions take 'struct pci_dev' instead of 'struct xe_device' for consistency with other configfs helpers. (Michal)
v4:
- Initialize gt->tile for SR-IOV's dummy GT to prevent null derefence.
- Switch internal function interface from one function that returns a mask to two functions (one primary, one media) that return true/false if the engine type is enabled.
- Use scope-based cleanup in a couple places to fix memory leaks on error paths and to make code simpler in general.
- Block SR-IOV without primary GT simply by adjusting .has_sriov during early init.
- Drop some outdated comments and commit message paragraphs that should have been removed with the code changes in v3.
- Tweak wording of a couple commit messages to reduce ambiguity of meaning.
v3:
- Drop default values and set va_bits / vm_max_level on all descriptors (Michal, Lucas)
- Use a specifically allocated GT to do SRIOV pre-init GT operations rather than filling tile0's primary GT with data for each tile & GT. This allows the primary GT's allocation to be moved to a more appropriate place (and skipped completely if the primary GT is disabled).
- If primary GT is disabled, do PF->native demotion and VF probe failure in xe_info_init rather than SRIOV pre-init. (Michal)
v2:
- About 20 extra patches added to reduce dependencies on an always-present primary GT.
- Kerneldoc and string parsing fixes to the configfs attribute handling (Gustavo)
Matt Roper (23):
drm/xe/huc: Adjust HuC check on primary GT
drm/xe: Drop GT parameter to xe_display_irq_postinstall() drm/xe: Move 'va_bits' flag back to platform descriptor drm/xe: Move 'vm_max_level' flag back to platform descriptor drm/xe: Move 'vram_flags' flag back to platform descriptor drm/xe: Move 'has_flatccs' flag back to platform descriptor drm/xe: Read VF GMD_ID with a specifically-allocated dummy GT drm/xe: Move primary GT allocation from xe_tile_init_early to
xe_tile_init
drm/xe: Skip L2 / TDF cache flushes if primary GT is disabled drm/xe/query: Report hwconfig size as 0 if primary GT is disabled drm/xe/pmu: Initialize PMU event types based on first available GT drm/xe: Check for primary GT before looking up Wa_22019338487 drm/xe: Make display part of Wa_22019338487 a device workaround drm/xe/irq: Don't try to lookup engine masks for non-existent primary
GT
drm/xe: Handle Wa_22010954014 and Wa_14022085890 as device workarounds drm/xe/rtp: Pass xe_device parameter to FUNC matches drm/xe: Bypass Wa_14018094691 when primary GT is disabled drm/xe: Correct lineage for Wa_22014953428 and only check with valid
GT
drm/xe: Check that GT is not NULL before testing Wa_16023588340 drm/xe: Don't check BIOS-disabled FlatCCS if primary GT is disabled drm/xe: Break GT setup out of xe_info_init() drm/xe/configfs: Add attribute to disable GT types drm/xe/sriov: Disable SR-IOV if primary GT is disabled via configfs
drivers/gpu/drm/xe/display/intel_fbdev_fb.c | 4 +- drivers/gpu/drm/xe/display/xe_display.c | 5 +- drivers/gpu/drm/xe/display/xe_display.h | 4 +- drivers/gpu/drm/xe/display/xe_display_wa.c | 3 +- drivers/gpu/drm/xe/display/xe_plane_initial.c | 4 +- drivers/gpu/drm/xe/tests/xe_pci.c | 6 +- drivers/gpu/drm/xe/tests/xe_rtp_test.c | 6 +- drivers/gpu/drm/xe/xe_configfs.c | 143 +++++++++++ drivers/gpu/drm/xe/xe_configfs.h | 4 + drivers/gpu/drm/xe/xe_device.c | 7 + drivers/gpu/drm/xe/xe_device_wa_oob.rules | 3 + drivers/gpu/drm/xe/xe_ggtt.c | 31 ++- drivers/gpu/drm/xe/xe_gsc.c | 4 +- drivers/gpu/drm/xe/xe_guc_pc.c | 3 +- drivers/gpu/drm/xe/xe_huc.c | 10 +- drivers/gpu/drm/xe/xe_hw_engine.c | 10 +- drivers/gpu/drm/xe/xe_irq.c | 14 +- drivers/gpu/drm/xe/xe_pci.c | 238 ++++++++++++------ drivers/gpu/drm/xe/xe_pci_types.h | 9 +- drivers/gpu/drm/xe/xe_platform_types.h | 1 + drivers/gpu/drm/xe/xe_pmu.c | 11 +- drivers/gpu/drm/xe/xe_query.c | 2 +- drivers/gpu/drm/xe/xe_reg_whitelist.c | 3 +- drivers/gpu/drm/xe/xe_rtp.c | 24 +- drivers/gpu/drm/xe/xe_rtp.h | 18 +- drivers/gpu/drm/xe/xe_rtp_types.h | 4 +- drivers/gpu/drm/xe/xe_tile.c | 4 - drivers/gpu/drm/xe/xe_vm.c | 3 +- drivers/gpu/drm/xe/xe_wa.c | 2 +- drivers/gpu/drm/xe/xe_wa_oob.rules | 8 +- include/drm/intel/pciids.h | 7 +- 31 files changed, 439 insertions(+), 156 deletions(-)
Signature · 1 line
2.51.0