Skip to content

KVM: SVM: Enable AVIC for Zen4+ (if x2AVIC)

Sean Christopherson kvm lkml 2 versions Applied

Status from this message: Applied to kvm-x86 svm, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 1 replyApplied
  2. v36 patches 12 repliesSuperseded

Changes in v4 from the cover letter

- Collect tags. [Naveen]
- Add missing "(AMD)" for Naveen's attribution. [Naveen]
- Make svm_x86_ops globally visible, to match TDX, instead of passing in the struct as parameter to avic_hardware_setup(). [Naveen]
- s/avic_want_avic_enabled/avic_want_enabled. [Naveen]
- Print "AVIC enabled" in avic_harware_setup() so that it's close to the "x2AVIC enabled" message. [Naveen]

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/7KVM: SVM: Make svm_x86_ops globally visible, clean up on-HyperV usagearch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm.h arch/x86/kvm/svm/svm_onhyperv.c +1 more+31 -320 replies
2/7KVM: SVM: Move x2AVIC MSR interception helper to avic.carch/x86/kvm/svm/avic.c arch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm.h+54 -530 replies
3/7KVM: SVM: Update "APICv in x2APIC without x2AVIC" in avic.c, not svm.carch/x86/kvm/svm/avic.c arch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm.h+5 -60 replies
4/7KVM: SVM: Always print "AVIC enabled" separately, even when force enabledarch/x86/kvm/svm/avic.c+9 -100 replies
5/7KVM: SVM: Don't advise the user to do force_avic=y (when x2AVIC is detected)arch/x86/kvm/svm/avic.c+2 -40 replies
6/7KVM: SVM: Move global "avic" variable to avic.carch/x86/kvm/svm/avic.c arch/x86/kvm/svm/svm.c+26 -180 replies
7/7KVM: SVM: Enable AVIC by default for Zen4+ if x2AVIC is supportarch/x86/kvm/svm/avic.c+36 -40 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchNaveen N Rao (AMD)
1/7
2/7R-b T-b
3/7A-b T-b
4/7R-b T-b
5/7R-b T-b
6/7A-b T-b
7/7T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/7] KVM: SVM: Enable AVIC for Zen4+ (if x2AVIC)

Enable AVIC by default for Zen4+, so long as x2AVIC is supported (which should be the case if AVIC is supported).

v4:
- Collect tags. [Naveen]
- Add missing "(AMD)" for Naveen's attribution. [Naveen]
- Make svm_x86_ops globally visible, to match TDX, instead of passing in the struct as parameter to avic_hardware_setup(). [Naveen]
- s/avic_want_avic_enabled/avic_want_enabled. [Naveen]
- Print "AVIC enabled" in avic_harware_setup() so that it's close to the "x2AVIC enabled" message. [Naveen]

v3: https://lore.kernel.org/all/owztdzclln5pmgsuxgzt54vneiejtngdkujaebr7r35zx3f4lj@xvvhwvumkkha
- Don't advise the user to enable force_avic. [Naveen]
- Gather AVIC related module params in avic.c (by moving code/helpers to avic.c).
- Print "AVIC enabled" even when it's forced.
- Enable by default iff x2AVIC is supported.
- Use "auto" to select KVM's automatic/default behavior.

v2: https://lore.kernel.org/all/[email protected]

v1: http://lkml.kernel.org/r/[email protected]

Naveen N Rao (AMD) (1):
KVM: SVM: Enable AVIC by default for Zen4+ if x2AVIC is support

Sean Christopherson (6):
KVM: SVM: Make svm_x86_ops globally visible, clean up on-HyperV usage
KVM: SVM: Move x2AVIC MSR interception helper to avic.c
KVM: SVM: Update "APICv in x2APIC without x2AVIC" in avic.c, not svm.c
KVM: SVM: Always print "AVIC enabled" separately, even when force
enabled
KVM: SVM: Don't advise the user to do force_avic=y (when x2AVIC is
detected)
KVM: SVM: Move global "avic" variable to avic.c

 arch/x86/kvm/svm/avic.c         | 151 ++++++++++++++++++++++++++------
 arch/x86/kvm/svm/svm.c          |  64 +-------------
 arch/x86/kvm/svm/svm.h          |   6 +-
 arch/x86/kvm/svm/svm_onhyperv.c |  28 +++++-
 arch/x86/kvm/svm/svm_onhyperv.h |  31 +------
 5 files changed, 158 insertions(+), 122 deletions(-)

base-commit: c8fbf7ceb2ae3f64b0c377c8c21f6df577a13eb4

Signature · 1 line
2.51.0.470.ga7dc726c21-goog