Skip to content

x86-android-tablets: convert to use GPIO references + Acer A1-840 support

Hans de Goede platform-driver-x86 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest20 patches 41 repliesIn review
  2. v319 patches 13 repliesSuperseded

Changes in v4 from the cover letter

- "convert Yoga Tab2 fast charger to GPIO references" change:
Split propagating the platform-dev fwnode to the serdev and the fwnode_handle_get() call on the serdev fwnode into 2 separate statements
- New patch: "Simplify node-group [un]registration"

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20platform/x86: x86-android-tablets: convert Goodix devices to GPIO referencesdrivers/platform/x86/x86-android-tablets/asus.c drivers/platform/x86/x86-android-tablets/core.c drivers/platform/x86/x86-android-tablets/lenovo.c +2 more+105 -5839 replies
2/20platform/x86: x86-android-tablets: convert Wacom devices to GPIO referencesdrivers/platform/x86/x86-android-tablets/lenovo.c+1 -90 replies
3/20platform/x86: x86-android-tablets: convert HiDeep devices to GPIO referencesdrivers/platform/x86/x86-android-tablets/lenovo.c+3 -230 replies
4/20platform/x86: x86-android-tablets: convert Novatek devices to GPIO referencesdrivers/platform/x86/x86-android-tablets/other.c+11 -90 replies
5/20platform/x86: x86-android-tablets: convert EDT devices to GPIO referencesdrivers/platform/x86/x86-android-tablets/other.c+13 -150 replies
6/20platform/x86: x86-android-tablets: convert int3496 devices to GPIO referencesdrivers/platform/x86/x86-android-tablets/asus.c drivers/platform/x86/x86-android-tablets/lenovo.c drivers/platform/x86/x86-android-tablets/other.c +2 more+43 -550 replies
7/20platform/x86: x86-android-tablets: convert wm1502 devices to GPIO referencesdrivers/platform/x86/x86-android-tablets/lenovo.c sound/soc/intel/boards/bytcr_wm5102.c+76 -330 replies
8/20platform/x86: x86-android-tablets: convert HID-I2C devices to GPIO referencesdrivers/platform/x86/x86-android-tablets/other.c+4 -280 replies
9/20platform/x86: x86-android-tablets: convert Yoga Tab2 fast charger to GPIO referencesdrivers/platform/x86/lenovo/yoga-tab2-pro-1380-fastcharger.c drivers/platform/x86/x86-android-tablets/lenovo.c+13 -150 replies
10/20platform/x86: x86-android-tablets: remove support for GPIO lookup tablesdrivers/platform/x86/x86-android-tablets/core.c drivers/platform/x86/x86-android-tablets/x86-android-tablets.h+0 -100 replies
11/20platform/x86: x86-android-tablets: convert gpio_keys devices to GPIO referencesdrivers/platform/x86/x86-android-tablets/asus.c drivers/platform/x86/x86-android-tablets/core.c drivers/platform/x86/x86-android-tablets/lenovo.c +2 more+177 -1360 replies
12/20platform/x86: x86-android-tablets: replace bat_swnode with swnode_groupdrivers/platform/x86/x86-android-tablets/asus.c drivers/platform/x86/x86-android-tablets/core.c drivers/platform/x86/x86-android-tablets/lenovo.c +3 more+25 -110 replies
13/20platform/x86: x86-android-tablets: use swnode_group instead of manual registeringdrivers/platform/x86/x86-android-tablets/lenovo.c drivers/platform/x86/x86-android-tablets/other.c+7 -280 replies
14/20platform/x86: x86-android-tablets: Simplify node-group [un]registrationdrivers/platform/x86/x86-android-tablets/core.c+11 -201 reply
15/20platform/x86: x86-android-tablets: Update my email addressdrivers/platform/x86/x86-android-tablets/asus.c drivers/platform/x86/x86-android-tablets/core.c drivers/platform/x86/x86-android-tablets/dmi.c +6 more+10 -100 replies
16/20platform/x86: x86-android-tablets: Move Acer info to its own filedrivers/platform/x86/x86-android-tablets/Makefile drivers/platform/x86/x86-android-tablets/acer.c drivers/platform/x86/x86-android-tablets/other.c+88 -710 replies
17/20platform/x86: x86-android-tablets: Add support for Acer A1-840 tabletdrivers/platform/x86/x86-android-tablets/acer.c drivers/platform/x86/x86-android-tablets/dmi.c drivers/platform/x86/x86-android-tablets/x86-android-tablets.h+171 -00 replies
18/20platform/x86: x86-android-tablets: Simplify lenovo_yoga_tab2_830_1050_exit()drivers/platform/x86/x86-android-tablets/lenovo.c+4 -90 replies
19/20platform/x86: x86-android-tablets: Fix modules lists for Lenovo devicesdrivers/platform/x86/x86-android-tablets/lenovo.c+14 -70 replies
20/20platform/x86: x86-android-tablets: Stop using EPROBE_DEFERdrivers/platform/x86/x86-android-tablets/core.c drivers/platform/x86/x86-android-tablets/other.c+8 -40 replies

Reviews trailers per patch

All 20 patches have a Reviewed-by or Acked-by.

PatchHans de GoedeAndy ShevchenkoDmitry Torokhov
1/20T-b R-b R-b
2/20T-b R-b R-b
3/20T-b R-b R-b
4/20T-b R-b R-b
5/20T-b R-b R-b
6/20T-b R-b R-b
7/20T-b R-b R-b
8/20T-b R-b R-b
9/20T-b R-b R-b
10/20T-b R-b R-b
11/20T-b R-b R-b
12/20R-b R-b
13/20R-b R-b
14/20R-b
15/20R-b
16/20R-b R-b
17/20R-b
18/20R-b R-b
19/20R-b
20/20R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/20] x86-android-tablets: convert to use GPIO references + Acer A1-840 support

Hi all,

Original cover-letter from Dmitry's v2 posting:

"This series came about because now software nodes can be used to describe GPIOs (via PROPERTY_ENTRY_GPIO() macros) and I would like to eventually get rid of gpio_keys_platform_data structure.

So while I was doing the conversions from GPIO_LOOKUP() tables for gpio_keys devices I decided to convert the rest of them as well. Maybe some time in the future we can drop support for GPIO_LOOKUP() and rely on device properties exclusively."

Follow-up changes / new patches from me:

Changes in v4:
- "convert Yoga Tab2 fast charger to GPIO references" change:
Split propagating the platform-dev fwnode to the serdev and the fwnode_handle_get() call on the serdev fwnode into 2 separate statements
- New patch: "Simplify node-group [un]registration"

Changes in v3:
- Add missing pinctrl_put() in lenovo_yoga_tab2_830_1050_init_codec() error-exit paths after the pinctrl_get_select() succeeds

- Adding a swnode to the yt3 spi device changes the name of the SPI/codec device and the sound/soc/intel/boards/bytcr_wm5102.c machine driver looks up the code by name, update the machine driver to use the new name.

- Make yoga-tab2-pro-1380-fastcharger.c propagate the fwnode set on the platform-device to the serdev it creates to fix this.

- Fix the commit message of "platform/x86: x86-android-tablets: convert gpio_keys devices to GPIO references" which contained a stray reference to wm5102.

New patches in v3:

- Change sw_bat register mechanism into a generic swnode_group mechanism

- Use swnode_group mechanism to register groups needed, instead of having init() callbacks manually do this

- Changed my email address in the driver to [email protected]

- Rebased "platform/x86: x86-android-tablets: Add support for Acer A1-840 tablet" on top, switched that to also use software-nodes for GPIOs and added it to this series

- Some Lenovo Yoga Tab 2 support fixes

Regards,

Hans

Dmitry Torokhov (11):
platform/x86: x86-android-tablets: convert Goodix devices to GPIO
references
platform/x86: x86-android-tablets: convert Wacom devices to GPIO
references
platform/x86: x86-android-tablets: convert HiDeep devices to GPIO
references
platform/x86: x86-android-tablets: convert Novatek devices to GPIO
references
platform/x86: x86-android-tablets: convert EDT devices to GPIO
references
platform/x86: x86-android-tablets: convert int3496 devices to GPIO
references
platform/x86: x86-android-tablets: convert wm1502 devices to GPIO
references
platform/x86: x86-android-tablets: convert HID-I2C devices to GPIO
references
platform/x86: x86-android-tablets: convert Yoga Tab2 fast charger to
GPIO references
platform/x86: x86-android-tablets: remove support for GPIO lookup
tables
platform/x86: x86-android-tablets: convert gpio_keys devices to GPIO
references

Hans de Goede (9):
platform/x86: x86-android-tablets: replace bat_swnode with
swnode_group
platform/x86: x86-android-tablets: use swnode_group instead of manual
registering
platform/x86: x86-android-tablets: Simplify node-group
[un]registration
platform/x86: x86-android-tablets: Update my email address platform/x86: x86-android-tablets: Move Acer info to its own file platform/x86: x86-android-tablets: Add support for Acer A1-840 tablet platform/x86: x86-android-tablets: Simplify

    lenovo_yoga_tab2_830_1050_exit()

platform/x86: x86-android-tablets: Fix modules lists for Lenovo
devices
platform/x86: x86-android-tablets: Stop using EPROBE_DEFER

 .../lenovo/yoga-tab2-pro-1380-fastcharger.c   |   5 +
 .../platform/x86/x86-android-tablets/Makefile |   2 +-
 .../platform/x86/x86-android-tablets/acer.c   | 247 +++++++++++++
 .../platform/x86/x86-android-tablets/asus.c   | 108 +++---
 .../platform/x86/x86-android-tablets/core.c   | 118 +++---
 .../platform/x86/x86-android-tablets/dmi.c    |  12 +-
 .../platform/x86/x86-android-tablets/lenovo.c | 291 ++++++++-------
 .../platform/x86/x86-android-tablets/other.c  | 338 ++++++------------
 .../x86/x86-android-tablets/shared-psy-info.c |  34 +-
 .../x86/x86-android-tablets/shared-psy-info.h |   8 +-
 .../x86/x86-android-tablets/vexia_atla10_ec.c |   2 +-
 .../x86-android-tablets/x86-android-tablets.h |  28 +-
 sound/soc/intel/boards/bytcr_wm5102.c         |   2 +-
 13 files changed, 714 insertions(+), 481 deletions(-)
 create mode 100644 drivers/platform/x86/x86-android-tablets/acer.c
Signature · 1 line
2.51.0