Skip to content

rust: pci: don't probe() VFs in nova-core

John Hubbard linux-pci lkml nouveau rust-for-linux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 29 repliesIn review

Changes in v2 from the cover letter

1) Completely rewrote the series, using Danilo's suggested approach of "driver supports VF probing or not": the PCI driver core will skip probing any device's VFs if the driver has coded itself as "not supporting VFs".

2) Included Joel's clarification, as a comment in the code, about what happens if VFs are probed.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2rust: pci: skip probing VFs if driver doesn't support VFsdrivers/pci/pci-driver.c include/linux/pci.h rust/kernel/pci.rs+8 -029 replies
2/2gpu: nova-core: declare that VFs are not (yet) supporteddrivers/gpu/nova-core/driver.rs+5 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] rust: pci: don't probe() VFs in nova-core

Changes in v2:

1) Completely rewrote the series, using Danilo's suggested approach of "driver supports VF probing or not": the PCI driver core will skip probing any device's VFs if the driver has coded itself as "not supporting VFs".

2) Included Joel's clarification, as a comment in the code, about what happens if VFs are probed.

As with v1 [1], I've based this on top of today's driver-core-next [2], because the first patch belongs there, and the second patch applies cleanly to either driver-core-next or drm-rust-next. So this seems like the easiest to work with.

[1]] https://lore.kernel.org/[email protected]
[2] https://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git/

Cc Alexandre Courbot <[email protected]>
Cc Alistair Popple <[email protected]>
Cc Joel Fernandes <[email protected]>
Cc Zhi Wang <[email protected]>
Cc Alex Williamson <[email protected]>
Cc Jason Gunthorpe <[email protected]>
Cc Danilo Krummrich <[email protected]>

John Hubbard (2):
rust: pci: skip probing VFs if driver doesn't support VFs
gpu: nova-core: declare that VFs are not (yet) supported

 drivers/gpu/nova-core/driver.rs | 5 +++++
 drivers/pci/pci-driver.c        | 3 +++
 include/linux/pci.h             | 1 +
 rust/kernel/pci.rs              | 4 ++++
 4 files changed, 13 insertions(+)

base-commit: 6d97171ac6585de698df019b0bfea3f123fd8385

Signature · 1 line
2.51.0