Skip to content

Fix a couple of wedge corner-case memory leaks

Stuart Summers intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/xe: Add additional trace points for LRCsdrivers/gpu/drm/xe/xe_lrc.c drivers/gpu/drm/xe/xe_lrc.h drivers/gpu/drm/xe/xe_trace_lrc.h+48 -10 replies
2/7drm/xe: Add a trace point for VM closedrivers/gpu/drm/xe/xe_trace_bo.h drivers/gpu/drm/xe/xe_vm.c+8 -00 replies
3/7drm/xe: Add the BO pointer info to the BO tracedrivers/gpu/drm/xe/xe_trace_bo.h+4 -20 replies
4/7drm/xe: Add new exec queue trace pointsdrivers/gpu/drm/xe/xe_exec_queue.c drivers/gpu/drm/xe/xe_guc_submit.c drivers/gpu/drm/xe/xe_trace.h+31 -60 replies
5/7drm/xe: Handle missing migration VM on VM creationdrivers/gpu/drm/xe/xe_exec_queue.c+3 -03 replies
6/7drm/xe: Don't send a CLEANUP message on sched pausedrivers/gpu/drm/xe/xe_guc_submit.c+2 -12 replies
7/7drm/xe: Check for GuC responses on disabling schedulingdrivers/gpu/drm/xe/xe_guc_submit.c+22 -16 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] Fix a couple of wedge corner-case memory leaks

Most of the patches in this series are just adding some debug hints to help track these down. I split these up in case we want to pick and choose which ones to include in the tree. I found them useful.

The main two interesting patches are the last two in the series which are fixing some corner cases when the driver becomes wedged in the middle of either communication with the DRM scheduler or in the event the GuC becomes unresponsive. In both of these cases there is a chance we could leak memory around the exec queue members like the LRC and the LRC BO. These patches fix those scenarios.

Stuart Summers (7):
drm/xe: Add additional trace points for LRCs drm/xe: Add a trace point for VM close
drm/xe: Add the BO pointer info to the BO trace drm/xe: Add new exec queue trace points drm/xe: Handle missing migration VM on VM creation drm/xe: Don't send a CLEANUP message on sched pause drm/xe: Check for GuC responses on disabling scheduling

 drivers/gpu/drm/xe/xe_exec_queue.c |  7 +++++
 drivers/gpu/drm/xe/xe_guc_submit.c | 37 +++++++++++++++++++++-----
 drivers/gpu/drm/xe/xe_lrc.c        |  4 +++
 drivers/gpu/drm/xe/xe_lrc.h        |  3 +++
 drivers/gpu/drm/xe/xe_trace.h      | 22 ++++++++++++++--
 drivers/gpu/drm/xe/xe_trace_bo.h   | 12 +++++++--
 drivers/gpu/drm/xe/xe_trace_lrc.h  | 42 +++++++++++++++++++++++++++++-
 drivers/gpu/drm/xe/xe_vm.c         |  2 ++
 8 files changed, 118 insertions(+), 11 deletions(-)
Signature · 1 line
2.34.1