Skip to content

drm/i915/dp: Fix panel replay in DSC mode

Imre Deak intel-gfx intel-xe 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 15 repliesIn review
  2. v12 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/i915/dsc: Add helper to enable the DSC configuration for a CRTCdrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_vdsc.c +1 more+9 -21 reply
2/7drm/i915/dp: Ensure the FEC state stays disabled for UHBR linksdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp_mst.c+12 -31 reply
3/7drm/i915/dp: Export helper to determine if FEC on non-UHBR links is requireddrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h drivers/gpu/drm/i915/display/intel_dp_mst.c+16 -95 replies
4/7drm/i915/dp_mst: Reuse the DP-SST helper function to compute FEC configdrivers/gpu/drm/i915/display/intel_dp_mst.c+4 -61 reply
5/7drm/i915/dp_mst: Track DSC enabled status on the MST linkdrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_vdsc.c +1 more+15 -11 reply
6/7drm/i915/dp_mst: Recompute all MST link CRTCs if DSC gets enabled on the linkdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_dp_mst.c drivers/gpu/drm/i915/display/intel_link_bw.c +1 more+19 -181 reply
7/7drm/i915/dp: Fix panel replay when DSC is enableddrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_psr.c+99 -51 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchJouni Högander
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] drm/i915/dp: Fix panel replay in DSC mode

This is v2 of [1], addressing Jouni's review comments and fixing the logic to derermine if DSC is enabled on a UHBR DP-MST link. The latter can't depend on whether FEC is enabled or not on the link, since FEC is always (i.e. regardless of DSC) enabled on a UHBR link; so this version adds an explicit way of tracking whether DSC is enabled for any CRTC on the link and uses this during a CRTC's state computation to decide if Panel Replay can be enabled or not for any CRTC on the link.

Cc Jouni Högander <[email protected]>

[1] https://lore.kernel.org/all/[email protected]

Imre Deak (7):
drm/i915/dsc: Add helper to enable the DSC configuration for a CRTC drm/i915/dp: Ensure the FEC state stays disabled for UHBR links drm/i915/dp: Export helper to determine if FEC on non-UHBR links is
required
drm/i915/dp_mst: Reuse the DP-SST helper function to compute FEC
config
drm/i915/dp_mst: Track DSC enabled status on the MST link drm/i915/dp_mst: Recompute all MST link CRTCs if DSC gets enabled on
the link
drm/i915/dp: Fix panel replay when DSC is enabled

 drivers/gpu/drm/i915/display/icl_dsi.c        |  2 +-
 drivers/gpu/drm/i915/display/intel_display.c  |  2 +-
 .../drm/i915/display/intel_display_types.h    | 11 +++
 drivers/gpu/drm/i915/display/intel_dp.c       | 34 ++++---
 drivers/gpu/drm/i915/display/intel_dp.h       |  2 +
 drivers/gpu/drm/i915/display/intel_dp_mst.c   | 31 ++++---
 drivers/gpu/drm/i915/display/intel_link_bw.c  | 17 ++--
 drivers/gpu/drm/i915/display/intel_link_bw.h  |  2 +-
 drivers/gpu/drm/i915/display/intel_psr.c      | 93 ++++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_vdsc.c     | 16 ++++
 drivers/gpu/drm/i915/display/intel_vdsc.h     |  2 +
 11 files changed, 171 insertions(+), 41 deletions(-)
Signature · 1 line
2.49.1