Skip to content

RFC Skip thaw sequence for all devices, not just amdgpu

Mario Limonciello (AMD) amd-gfx dri-devel linux-pm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3PM: hibernate: Nominally skip thaw sequence for all devicesdrivers/base/power/main.c kernel/power/hibernate.c kernel/power/user.c+19 -33 replies
2/3drm/amd: Drop special cases for thaw() callbackdrivers/gpu/drm/amd/amdgpu/amdgpu_drv.c+0 -40 replies
3/3PM: Drop pm_hibernate_is_recovering() and pm_hibernation_mode_is_suspend()drivers/base/power/main.c include/linux/suspend.h kernel/power/hibernate.c+0 -330 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/3] Skip thaw sequence for all devices, not just amdgpu

As part of looking at the hibernate code recently again I was considering whether we really need the thaw stage at all when things are working well.

So I wanted to explore what breaks if we just skip it. This should speed up the S4 sequence since nothing needs to resume.

If we do this we can drop the special cases in amdgpu and the exported symbols too.

Mario Limonciello (3):
PM: hibernate: Nominally skip thaw sequence for all devices drm/amd: Drop special cases for thaw() callback
PM: Drop pm_hibernate_is_recovering() and
pm_hibernation_mode_is_suspend()

 drivers/base/power/main.c               | 20 ++++++--------------
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c |  4 ----
 include/linux/suspend.h                 |  8 --------
 kernel/power/hibernate.c                | 24 ++++++++++--------------
 kernel/power/user.c                     |  3 +++
 5 files changed, 19 insertions(+), 40 deletions(-)
Signature · 1 line
2.43.0