Fix a couple of wedge corner-case memory leaks
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | drm/xe: Add additional trace points for LRCsdrivers/ drivers/ drivers/ | +48 | 0 replies | |
| 2/7 | drm/xe: Add a trace point for VM closedrivers/ drivers/ | +8 | 0 replies | |
| 3/7 | drm/xe: Add the BO pointer info to the BO tracedrivers/ | +4 | 0 replies | |
| 4/7 | drm/xe: Add new exec queue trace pointsdrivers/ drivers/ drivers/ | +31 | 0 replies | |
| 5/7 | drm/xe: Correct migration VM teardown orderdrivers/ | +1 | 0 replies | |
| 6/7 | drm/xe: Kick start GPU scheduler on teardowndrivers/ | +6 | 2 replies | |
| 7/7 | drm/xe: Check for GuC responses on disabling schedulingdrivers/ | +13 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/7] Fix a couple of wedge corner-case memory leaks
Most of the patches in this series are just adding some debug hints to help track these down. I split these up in case we want to pick and choose which ones to include in the tree. I found them useful.
The main two interesting patches are the last two in the series which are fixing some corner cases when the driver becomes wedged in the middle of either communication with the DRM scheduler or in the event the GuC becomes unresponsive. In both of these cases there is a chance we could leak memory around the exec queue members like the LRC and the LRC BO. These patches fix those scenarios.
v2: Address feedback from Matt:
- Let the DRM scheduler handle pausing/unpausing
- Still do the wait after scheduling disable/deregister as with the previous patch, but skip the intermediate software-based schedule disable using the "banned" flag and instead just jump straight to the deregister handling which will fully reset the queue state. Note that for this case I am seeing a hardware failure after submitting to GuC but before receiving the response from GuC. So even if we wedge in this case (monitoring the hardware state change), the queue itself is not wedged because of the active GuC submission (CT is not stalled at that point).
v3: Add back in the xe pause checks and instead just kickstart
message handling in the guc_submi_fini() routine before doing the async wait there.
Stuart Summers (7):
drm/xe: Add additional trace points for LRCs drm/xe: Add a trace point for VM close
drm/xe: Add the BO pointer info to the BO trace drm/xe: Add new exec queue trace points drm/xe: Correct migration VM teardown order drm/xe: Kick start GPU scheduler on teardown drm/xe: Check for GuC responses on disabling scheduling
drivers/gpu/drm/xe/xe_exec_queue.c | 4 +++ drivers/gpu/drm/xe/xe_guc_submit.c | 30 ++++++++++++++++++--- drivers/gpu/drm/xe/xe_lrc.c | 4 +++ drivers/gpu/drm/xe/xe_lrc.h | 3 +++ drivers/gpu/drm/xe/xe_migrate.c | 2 +- drivers/gpu/drm/xe/xe_trace.h | 22 ++++++++++++++-- drivers/gpu/drm/xe/xe_trace_bo.h | 12 +++++++-- drivers/gpu/drm/xe/xe_trace_lrc.h | 42 +++++++++++++++++++++++++++++- drivers/gpu/drm/xe/xe_vm.c | 2 ++ 9 files changed, 111 insertions(+), 10 deletions(-)
Signature · 1 line
2.34.1