Skip to content

Clean and update tilcdc driver to support DRM_BRIDGE_ATTACH_NO_CONNECTOR

Kory Maincent (TI.com) dri-devel linux-arm-kernel linux-devicetree linux-omap lkml 5 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected] change-id 20251014-feature_tilcdc-79cd49e67bf9

Versions newest first

  1. v5 Latest25 patches 4 repliesApplied
  2. v425 patches 15 repliesSuperseded
  3. v322 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v220 patches25 repliesSuperseded
v121 patches24 repliesSuperseded

Changes in v5 from the cover letter

- Fix a missing cleanup path.
- Link to v4: https://lore.kernel.org/r/[email protected]

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/25dt-bindings: display: tilcdc: Convert to DT schemaDocumentation/devicetree/bindings/display/tilcdc/ti,am33xx-tilcdc.yaml Documentation/devicetree/bindings/display/tilcdc/tilcdc.txt+100 -820 replies
2/25dt-bindings: display: tilcdc: Mark panel binding as deprecatedDocumentation/devicetree/bindings/display/tilcdc/panel.txt+1 -00 replies
3/25drm/tilcdc: Remove simulate_vesa_sync flagdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.h drivers/gpu/drm/tilcdc/tilcdc_external.c+0 -190 replies
4/25drm/tilcdc: Add support for DRM bus flags and simplify panel configdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+34 -320 replies
5/25drm/tilcdc: Convert legacy panel binding via DT overlay at boot timedrivers/gpu/drm/tilcdc/Kconfig drivers/gpu/drm/tilcdc/Makefile drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.c +1 more+232 -00 replies
6/25drm/tilcdc: Remove tilcdc panel driverdrivers/gpu/drm/tilcdc/Makefile drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_panel.c +1 more+0 -4270 replies
7/25drm/tilcdc: Remove component framework supportdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h +2 more+9 -1500 replies
8/25drm/tilcdc: Remove tilcdc_panel_info structuredrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.h drivers/gpu/drm/tilcdc/tilcdc_external.c+3 -810 replies
9/25drm/tilcdc: Remove redundant #endif/#ifdef in debugfs codedrivers/gpu/drm/tilcdc/tilcdc_drv.c+0 -30 replies
10/25drm/tilcdc: Remove unused encoder and connector tracking arraysdrivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+1 -80 replies
11/25drm/tilcdc: Rename external_encoder and external_connector to encoder and connectordrivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h drivers/gpu/drm/tilcdc/tilcdc_external.c +1 more+14 -170 replies
12/25drm/tilcdc: Rename tilcdc_external to tilcdc_encoderdrivers/gpu/drm/tilcdc/Makefile drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_encoder.c +1 more+3 -30 replies
13/25drm/tilcdc: Remove the useless module list supportdrivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+0 -560 replies
14/25drm/tilcdc: Use drm_module_platform_driver() helperdrivers/gpu/drm/tilcdc/tilcdc_drv.c+2 -170 replies
15/25drm/tilcdc: Move tilcdc_init/fini closer to probe/removedrivers/gpu/drm/tilcdc/tilcdc_drv.c+119 -1190 replies
16/25drm/tilcdc: Modernize driver initialization and cleanup pathsdrivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+35 -670 replies
17/25drm/tilcdc: Remove the use of drm_device private_datadrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h +3 more+28 -270 replies
18/25drm/tilcdc: Convert to DRM managed resourcesdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h +2 more+64 -740 replies
19/25drm/tilcdc: Convert to drm_device-based logging helpersdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_encoder.c +1 more+27 -270 replies
20/25drm/tilcdc: Use devm_drm_of_get_bridge() helperdrivers/gpu/drm/tilcdc/tilcdc_encoder.c+4 -143 replies
21/25drm/bridge: tda998x: Remove component supportdrivers/gpu/drm/bridge/tda998x_drv.c+1 -680 replies
22/25drm/bridge: tda998x: Move tda998x_create/destroy into probe and removedrivers/gpu/drm/bridge/tda998x_drv.c+51 -480 replies
23/25drm/bridge: tda998x: Remove useless tda998x_connector_destroy wrapperdrivers/gpu/drm/bridge/tda998x_drv.c+1 -60 replies
24/25drm/bridge: tda998x: Add support for DRM_BRIDGE_ATTACH_NO_CONNECTORdrivers/gpu/drm/bridge/tda998x_drv.c+85 -110 replies
25/25drm/tilcdc: Add support for DRM_BRIDGE_ATTACH_NO_CONNECTORdrivers/gpu/drm/tilcdc/Kconfig drivers/gpu/drm/tilcdc/tilcdc_encoder.c+18 -210 replies

Reviews trailers per patch

All 25 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiLuca CeresoliHerve Codina
1/25R-b
2/25A-b
3/25R-b
4/25R-b
5/25R-b R-b
6/25R-b
7/25R-b
8/25R-b
9/25R-b
10/25R-b
11/25R-b
12/25R-b
13/25R-b
14/25R-b
15/25R-b
16/25R-b
17/25R-b
18/25R-b
19/25R-b
20/25R-b
21/25R-b
22/25R-b
23/25R-b
24/25R-b
25/25R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/25] Clean and update tilcdc driver to support DRM_BRIDGE_ATTACH_NO_CONNECTOR

The starting point for this work was adding support for the HDMI cape:
https://www.seeedstudio.com/Seeed-Studio-BeagleBone-Green-HDMI-Cape.html
This will be sent in a later series.

Initially, Miguel proposed modifying the ite-it66121 bridge to support the legacy behavior without the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag:
https://lore.kernel.org/lkml/[email protected]/
This patch was NAK'd as we don't want to add more legacy code. Maxime requested that the tilcdc driver be updated to use DRM_BRIDGE_ATTACH_NO_CONNECTOR instead.

While working on this update, I discovered that the tilcdc driver contained significant amounts of legacy code that needed cleaning. Since this driver was developed alongside the tda998x driver for several AM335x boards, the tda998x driver also required cleanup and support for the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag.

A new tilcdc_panel_legacy driver replaces the old tilcdc_panel driver. It modifies the devicetree at boot time to properly bind the tilcdc driver with the standard panel-simple driver.

This series is based on the tilcdc fix sent to mainline:
https://lore.kernel.org/lkml/[email protected]/

This series has been tested on:
- BeagleBone Black (tilcdc + tda998x bridge)
- BeagleBone Black with LCD cape (tilcdc + ti,tilcdc,panel binding)
- BeagleBone Green Eco with HDMI cape (tilcdc + it66121 bridge)

The following mainline devicetrees still use ti,tilcdc,panel binding. I believe this series maintains compatibility, but I cannot test without hardware:
- da850-evm.dts
- am335x-guardian.dts
- am335x-pdu001.dts
- am335x-pepper.dts
- am335x-sbc-t335.dts
- am335x-sl50.dts

Patches 1-2: Convert tilcdc binding to YAML and set the ti,tilcdc,panel
sub-binding as legacy.
Patches 3-6: Replace tilcdc_panel driver to the new tilcdc_panel_legacy
driver which is tweaking the devicetree at boot time.
Patches 7-20: Clean up tilcdc driver.
Patches 21-23: Clean up tda998x driver.
Patch 24: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support for tda998x driver. Patch 25: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support for tilcdc driver.

Changes in v5:
- Fix a missing cleanup path.
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Use device_get_match_data instead of of_match_node.
- Convert the driver to use DRM managed resources to avoid lifetime
resources issue.
- Add a patch to convert to drm_device-based logging helpers.
- Replace drm_of_find_panel_or_bridge() with the newer devm_drm_of_get_bridge() helper.
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Split patch 13 and patch 14 into two for better readability and git
history clarity.
- Update patch 5 to use OF changeset and __free() macro. Made also few
small improvements as requested by Luca.
- Rename binding file to ti,am33xx-tilcdc.yaml, use generic node name and
drop unused label.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Remove patch 2 that add fifo-threshold property. Use FIFO threshold
value from SoC id instead.
- Remove the part that breaks DTB compatibility.
- Add tilcdc_panel_legacy to modify the devicetree at boot time to properly bind the tilcdc driver with the standard panel-simple driver.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Kory Maincent (TI.com) (25):
dt-bindings: display: tilcdc: Convert to DT schema
dt-bindings: display: tilcdc: Mark panel binding as deprecated drm/tilcdc: Remove simulate_vesa_sync flag
drm/tilcdc: Add support for DRM bus flags and simplify panel config drm/tilcdc: Convert legacy panel binding via DT overlay at boot time drm/tilcdc: Remove tilcdc panel driver
drm/tilcdc: Remove component framework support
drm/tilcdc: Remove tilcdc_panel_info structure
drm/tilcdc: Remove redundant #endif/#ifdef in debugfs code drm/tilcdc: Remove unused encoder and connector tracking arrays drm/tilcdc: Rename external_encoder and external_connector to encoder and connector drm/tilcdc: Rename tilcdc_external to tilcdc_encoder
drm/tilcdc: Remove the useless module list support
drm/tilcdc: Use drm_module_platform_driver() helper
drm/tilcdc: Move tilcdc_init/fini closer to probe/remove
drm/tilcdc: Modernize driver initialization and cleanup paths drm/tilcdc: Remove the use of drm_device private_data
drm/tilcdc: Convert to DRM managed resources
drm/tilcdc: Convert to drm_device-based logging helpers
drm/tilcdc: Use devm_drm_of_get_bridge() helper
drm/bridge: tda998x: Remove component support
drm/bridge: tda998x: Move tda998x_create/destroy into probe and remove drm/bridge: tda998x: Remove useless tda998x_connector_destroy wrapper drm/bridge: tda998x: Add support for DRM_BRIDGE_ATTACH_NO_CONNECTOR drm/tilcdc: Add support for DRM_BRIDGE_ATTACH_NO_CONNECTOR

 .../devicetree/bindings/display/tilcdc/panel.txt   |   1 +
 .../bindings/display/tilcdc/ti,am33xx-tilcdc.yaml  | 100 +++++
 .../devicetree/bindings/display/tilcdc/tilcdc.txt  |  82 ----
 drivers/gpu/drm/bridge/tda998x_drv.c               | 251 +++++------
 drivers/gpu/drm/tilcdc/Kconfig                     |  18 +
 drivers/gpu/drm/tilcdc/Makefile                    |   5 +-
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c               | 192 +++-----
 drivers/gpu/drm/tilcdc/tilcdc_drv.c                | 486 ++++++++-------------
 drivers/gpu/drm/tilcdc/tilcdc_drv.h                |  99 +----
 drivers/gpu/drm/tilcdc/tilcdc_encoder.c            |  69 +++
 .../tilcdc/{tilcdc_external.h => tilcdc_encoder.h} |   5 +-
 drivers/gpu/drm/tilcdc/tilcdc_external.c           | 179 --------
 drivers/gpu/drm/tilcdc/tilcdc_panel.c              | 408 -----------------
 drivers/gpu/drm/tilcdc/tilcdc_panel.h              |  15 -
 drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.c       | 185 ++++++++
 drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.dtso    |  29 ++
 drivers/gpu/drm/tilcdc/tilcdc_plane.c              |  37 +-
 drivers/gpu/drm/tilcdc/tilcdc_regs.h               |   8 +-
 18 files changed, 812 insertions(+), 1357 deletions(-)

---
base-commit: a3158f3710111bbd4bfba3bc0883449efde10a0b
change-id: 20251014-feature_tilcdc-79cd49e67bf9

Best regards,

Signature · 3 lines
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com