Skip to content

sched: Rewrite MM CID management

Thomas Gleixner bpf lkml sched-ext 5 versions – Applied

Status from this message: The following commit has been merged into the core/rseq branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest20 patches 19 repliesApplied
  2. v420 patches 14 repliesSuperseded
  3. v320 patches 44 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v220 patches8 repliesSuperseded
v119 patches19 repliesSuperseded

Changes in v5 from the cover letter

- Zero mm_cid::transit on init - Mathieu

- Rephrase change logs - Mathiue

- Picked up Reviewed/Acked-by tags

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/20sched/mmcid: Revert the complex CID managementinclude/linux/mm_types.h kernel/fork.c kernel/sched/core.c +1 more+64 -8000 replies
2/20sched/mmcid: Use proper data structuresinclude/linux/mm_types.h include/linux/rseq_types.h include/linux/sched.h +4 more+85 -750 replies
3/20sched/mmcid: Cacheline align MM CID storageinclude/linux/rseq_types.h+2 -20 replies
4/20sched: Fixup whitespace damagekernel/sched/core.c+4 -40 replies
5/20sched/mmcid: Move scheduler code out of global headerinclude/linux/mm_types.h kernel/sched/core.c+18 -150 replies
6/20sched/mmcid: Prevent pointless work in mm_update_cpus_allowed()kernel/sched/core.c+8 -30 replies
7/20cpumask: Introduce cpumask_weighted_or()include/linux/bitmap.h include/linux/cpumask.h lib/bitmap.c+37 -00 replies
8/20sched/mmcid: Use cpumask_weighted_or()kernel/sched/core.c+3 -20 replies
9/20cpumask: Cache num_possible_cpus()include/linux/cpumask.h kernel/cpu.c+27 -27 replies
10/20sched/mmcid: Convert mm CID mask to a bitmapinclude/linux/mm_types.h kernel/sched/core.c kernel/sched/sched.h+9 -80 replies
11/20signal: Move MMCID exit out of sighand lockinclude/linux/sched.h kernel/exit.c kernel/sched/core.c +1 more+5 -60 replies
12/20sched/mmcid: Move initialization out of lineinclude/linux/mm_types.h kernel/sched/core.c+15 -140 replies
13/20sched/mmcid: Provide precomputed maximal valueinclude/linux/rseq_types.h kernel/fork.c kernel/sched/core.c +1 more+50 -190 replies
14/20sched/mmcid: Serialize sched_mm_cid_fork()/exit() with a mutexinclude/linux/rseq_types.h kernel/sched/core.c+24 -00 replies
15/20sched/mmcid: Introduce per task/CPU ownership infrastructureinclude/linux/rseq_types.h include/linux/sched.h kernel/sched/core.c +1 more+75 -40 replies
16/20sched/mmcid: Provide new scheduler CID mechanisminclude/linux/rseq.h include/linux/rseq_types.h kernel/sched/core.c +1 more+168 -100 replies
17/20sched/mmcid: Provide CID ownership mode fixup functionsinclude/linux/rseq_types.h kernel/sched/core.c+258 -260 replies
18/20irqwork: Move data struct to a types headerinclude/linux/irq_work.h include/linux/irq_work_types.h+16 -70 replies
19/20sched/mmcid: Implement deferred mode changeinclude/linux/rseq_types.h kernel/sched/core.c+59 -70 replies
20/20sched/mmcid: Switch over to the new mechanisminclude/linux/rseq.h include/linux/rseq_types.h kernel/fork.c +2 more+103 -1163 replies

Reviews trailers per patch

19 of 20 patches have a Reviewed-by or Acked-by.

PatchMathieu DesnoyersYury Norov (NVIDIA)Shrikanth HegdeMarek SzyprowskiPaul E. McKenney
1/20A-b
2/20R-b
3/20R-b
4/20R-b
5/20R-b A-b
6/20R-b
7/20R-b R-b
8/20R-b A-b
9/20R-b R-b R-b T-b T-b
10/20R-b A-b
11/20R-b
12/20R-b
13/20R-b
14/20R-b
15/20
16/20R-b
17/20R-b
18/20R-b
19/20R-b
20/20R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v5 thread

Cover letter [patch V5 00/20] sched: Rewrite MM CID management

This is a follow up on the V4 series which can be found here:

    https://lore.kernel.org/[email protected]

The V1 cover letter contains a detailed analyisis of the issues:

    https://lore.kernel.org/[email protected]

TLDR: The CID management is way to complex and adds significant overhead into scheduler hotpaths.

The series rewrites MM CID management in a more simplistic way which focusses on low overhead in the scheduler while maintaining per task CIDs as long as the number of threads is not exceeding the number of possible CPUs.

The series is based on the V6 series of the rseq rewrite:

    https://lore.kernel.org/[email protected]

which is also available from git:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core/rseq

The series on top of the tip core/rseq branch is available from git as well:

git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git rseq/cid

Changes vs. V4:

- Zero mm_cid::transit on init - Mathieu

- Rephrase change logs - Mathiue

- Picked up Reviewed/Acked-by tags

Delta patch to V4 below.

Thanks,

tglx
---

kernel/sched/core.c +1 -0
index 93a2523908c4..72f368f7d6e2 100644
@@ -10848,6 +10848,7 @@ void mm_init_cid(struct mm_struct *mm, struct task_struct *p)
 {
 	mm->mm_cid.max_cids = 0;
 	mm->mm_cid.percpu = 0;
+	mm->mm_cid.transit = 0;
 	mm->mm_cid.nr_cpus_allowed = p->nr_cpus_allowed;
 	mm->mm_cid.users = 0;
 	mm->mm_cid.pcpu_thrs = 0;