Skip to content

Optimize vrr.guardband

Ankit Nautiyal intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/i915/vrr: prep patches for guardband optimization squasheddrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_dp.c +8 more+246 -890 replies
2/6drm/i915/prefill: Prefill latency calculations series squasheddrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_cdclk.h +10 more+528 -940 replies
3/6drm/i915/psr: Add helper to get min psr guardbanddrivers/gpu/drm/i915/display/intel_psr.c drivers/gpu/drm/i915/display/intel_psr.h+13 -00 replies
4/6drm/i915/dp: Add helper to get min sdp guardbanddrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h+38 -00 replies
5/6drm/i915/dp: Check if guardband can accommodate sdp latenciesdrivers/gpu/drm/i915/display/intel_dp.c+22 -00 replies
6/6drm/i915/vrr: Use the min static optimized guardbanddrivers/gpu/drm/i915/display/intel_vrr.c+48 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] Optimize vrr.guardband

Instead of setting vrr.guardband to vblank, use optimal guardband that works for most of the cases. This will help in avoiding need of change in guardband and fix the LRR feature that needs seamless switching to a lower refresh rate.

-Patch [1-2] are squashed from series [1] and [2] and are not meant for
review.
-Patch [3-6] are patches to check the guardband for prefill+PSR+SDP
latencies and to use a static optimized guardband.

[1] "Preparatory patches for guardband optimization"
https://patchwork.freedesktop.org/series/155661/#rev8

[2] "Introduce helpers for prefill latency calculations"
https://patchwork.freedesktop.org/series/155629/#rev3

Rev2:
- Drop patch to check guardband in crtc_check phase, instead check guardband for SDP in compute_config_late.
- Modify the helper to get the min sdp guardband if all SDPs are assumed to be enabled.
- Rename the helpers to get min guardband for sdp and psr.

Ankit Nautiyal (5):
[NOT FOR REVIEW] drm/i915/vrr: prep patches for guardband optimization
squashed
drm/i915/psr: Add helper to get min psr guardband drm/i915/dp: Add helper to get min sdp guardband drm/i915/dp: Check if guardband can accommodate sdp latencies drm/i915/vrr: Use the min static optimized guardband

Ville Syrjälä (1):
[NOT FOR REVIEW] drm/i915/prefill: Prefill latency calculations series
squashed

 drivers/gpu/drm/i915/Makefile                |   1 +
 drivers/gpu/drm/i915/display/intel_cdclk.c   |  80 +++++-
 drivers/gpu/drm/i915/display/intel_cdclk.h   |   6 +
 drivers/gpu/drm/i915/display/intel_ddi.c     |   7 +
 drivers/gpu/drm/i915/display/intel_display.c |  26 +-
 drivers/gpu/drm/i915/display/intel_dp.c      |  69 +++++
 drivers/gpu/drm/i915/display/intel_dp.h      |   5 +
 drivers/gpu/drm/i915/display/intel_psr.c     | 256 +++++++++++++------
 drivers/gpu/drm/i915/display/intel_psr.h     |   3 +
 drivers/gpu/drm/i915/display/intel_vblank.c  |  10 +
 drivers/gpu/drm/i915/display/intel_vblank.h  |   2 +
 drivers/gpu/drm/i915/display/intel_vdsc.c    |   8 +
 drivers/gpu/drm/i915/display/intel_vdsc.h    |   1 +
 drivers/gpu/drm/i915/display/intel_vrr.c     |  83 +++++-
 drivers/gpu/drm/i915/display/intel_vrr.h     |   2 +-
 drivers/gpu/drm/i915/display/skl_prefill.c   | 157 ++++++++++++
 drivers/gpu/drm/i915/display/skl_prefill.h   |  46 ++++
 drivers/gpu/drm/i915/display/skl_scaler.c    | 141 ++++++++++
 drivers/gpu/drm/i915/display/skl_scaler.h    |  15 ++
 drivers/gpu/drm/i915/display/skl_watermark.c | 156 +++++------
 drivers/gpu/drm/i915/display/skl_watermark.h |   3 +
 drivers/gpu/drm/xe/Makefile                  |   1 +
 22 files changed, 894 insertions(+), 184 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/skl_prefill.c
 create mode 100644 drivers/gpu/drm/i915/display/skl_prefill.h
Signature · 1 line
2.45.2