Skip to content

ALSA: cs35l56: Add support for factory calibration

Richard Fitzgerald linux-sound lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 3 repliesIn review
  2. v111 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Changed the file handlers to be debugfs files instead of sysfs files.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11ASoC: cs35l56: Read silicon ID during initialization and save itinclude/sound/cs35l56.h sound/soc/codecs/cs35l56-shared.c+27 -270 replies
2/11ASoC: cs-amp-lib: Add helpers for factory calibrationinclude/sound/cs-amp-lib.h sound/soc/codecs/cs-amp-lib.c+155 -50 replies
3/11ASoC: cs35l56: Add common code for factory calibrationinclude/sound/cs35l56.h sound/soc/codecs/Kconfig sound/soc/codecs/cs35l56-shared.c+331 -50 replies
4/11ASoC: cs35l56: Create debugfs files for factory calibrationsound/soc/codecs/Kconfig sound/soc/codecs/cs35l56.c sound/soc/codecs/cs35l56.h+180 -00 replies
5/11ALSA: hda/cs35l56: Create debugfs files for factory calibrationsound/hda/codecs/side-codecs/Kconfig sound/hda/codecs/side-codecs/cs35l56_hda.c sound/hda/codecs/side-codecs/cs35l56_hda.h+130 -50 replies
6/11ASoC: cs-amp-lib-test: Add cases for factory calibration helpersinclude/sound/cs-amp-lib.h sound/soc/codecs/cs-amp-lib-test.c sound/soc/codecs/cs-amp-lib.c+79 -20 replies
7/11ASoC: cs-amp-lib: Return attributes from cs_amp_get_efi_variable()include/sound/cs-amp-lib.h sound/soc/codecs/cs-amp-lib-test.c sound/soc/codecs/cs-amp-lib.c+34 -50 replies
8/11ASoC: cs-amp-lib: Add function to write calibration to UEFIinclude/sound/cs-amp-lib.h sound/soc/codecs/cs-amp-lib.c+188 -40 replies
9/11ASoC: cs35l56: Add calibration command to store into UEFIinclude/sound/cs35l56.h sound/soc/codecs/cs35l56-shared.c+19 -30 replies
10/11ALSA: hda/cs35l56: Set cal_index to the amp indexsound/hda/codecs/side-codecs/cs35l56_hda.c+1 -10 replies
11/11ASoC: cs-amp-lib-test: Add test cases for cs_amp_set_efi_calibration_data()include/sound/cs-amp-lib.h sound/soc/codecs/cs-amp-lib-test.c sound/soc/codecs/cs-amp-lib.c+1397 -80 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTakashi Iwai
SeriesR-b
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/11] ALSA: cs35l56: Add support for factory calibration

Until now, all products with an amplifier supported by the cs35l56 driver have shipped with Microsoft Windows pre-installed. The factory calibration of speaker protection has therefore been done using the Windows driver.

However, products that ship with a Linux-based distro must be able to perform the factory calibration procedure from within the Linux-based environment. This patch series adds that support.

NOTE: unfortunately this is yet another series that is mainly ASoC but also needs some changes to the HDA driver, and they have build dependencies on the ASoC code. I suggest taking this all through Mark's tree and we'll avoid sending any other commits to the HDA driver until it has all landed in Takashi's tree.

Changes since V1:
- Changed the file handlers to be debugfs files instead of sysfs files.

Richard Fitzgerald (11):
ASoC: cs35l56: Read silicon ID during initialization and save it
ASoC: cs-amp-lib: Add helpers for factory calibration
ASoC: cs35l56: Add common code for factory calibration
ASoC: cs35l56: Create debugfs files for factory calibration
ALSA: hda/cs35l56: Create debugfs files for factory calibration
ASoC: cs-amp-lib-test: Add cases for factory calibration helpers
ASoC: cs-amp-lib: Return attributes from cs_amp_get_efi_variable()
ASoC: cs-amp-lib: Add function to write calibration to UEFI
ASoC: cs35l56: Add calibration command to store into UEFI
ALSA: hda/cs35l56: Set cal_index to the amp index
ASoC: cs-amp-lib-test: Add test cases for
cs_amp_set_efi_calibration_data()

 include/sound/cs-amp-lib.h                 |   25 +-
 include/sound/cs35l56.h                    |   35 +
 sound/hda/codecs/side-codecs/Kconfig       |   15 +
 sound/hda/codecs/side-codecs/cs35l56_hda.c |  116 +-
 sound/hda/codecs/side-codecs/cs35l56_hda.h |    6 +
 sound/soc/codecs/Kconfig                   |   18 +
 sound/soc/codecs/cs-amp-lib-test.c         | 1491 +++++++++++++++++++-
 sound/soc/codecs/cs-amp-lib.c              |  345 ++++-
 sound/soc/codecs/cs35l56-shared.c          |  368 ++++-
 sound/soc/codecs/cs35l56.c                 |  159 +++
 sound/soc/codecs/cs35l56.h                 |    6 +
 11 files changed, 2530 insertions(+), 54 deletions(-)
Signature · 1 line
2.47.3