Skip to content

Improve usage of 'ret' variable and make pcf_doAdress() void

Cezar Chiru linux-i2c lkml 2 versions – Applied

Status from this message: merged to i2c/i2c-host.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest3 patches 5 repliesApplied
  2. v81 patch 1 replySuperseded

Patches in v9 Applied

#Subject and filesSizeRepliesApplied
1/3i2c: pcf8584: Move 'ret' variable inside for loop, goto out if ret < 0.drivers/i2c/algos/i2c-algo-pcf.c+8 -44 replies
2/3i2c: pcf8584: Make pcf_doAddress() function voiddrivers/i2c/algos/i2c-algo-pcf.c+2 -40 replies
3/3i2c: pcf8584: Change pcf_doAdress() to pcf_send_address()drivers/i2c/algos/i2c-algo-pcf.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v9 yet.

Read the v9 thread

Cover letter [PATCH v9 0/3] Improve usage of 'ret' variable and make pcf_doAdress() void

Hello maintainers,
This patch series is a response to Change Requests made by Andi Shyti on [PATCH v7 0/3] i2c: pcf8584: Fix errors and warnings reported by checkpatch and more specific on PATCH: i2c: pcf8584: Move 'ret' variable inside for loop, break if ret < 0.
Also a comment from Andy Shevchenko on "[PATCH v8 1/1] i2c: pcf8584: Move 'ret' variable inside for loop, break if ret < 0." about using 'goto out;' instead of break since the goto out; was used in other error path branches so it makes sense to be consistent.

2 new patches have been introduced into this patch series and they are dependent on each other that's why the need for a new patch series v9.

Change Requests:
-remove initialization of 'ret' variable inside for loop of pcf_xfer() as it is not needed
-change pcf_doAddress() function type from int to void as it always returns 0.
-change if (ret < 0) break; with if (ret < 0) goto out; to be consistent -change pcf_doAddress() function name to pcf_send_address()

Testing:
*built kernel and modules with I2C_ALGOPCF=m and my 3 patches applied on top of 6.18.0-rc1.
*installed kernel and external modules generated by build on my laptop *rebooted and loaded i2c-algo-pcf.ko without i2c_debug parameter. *when loading the .ko with i2c_debug parameter an error is seen in dmesg and this is expected as the parameter was removed.
*No success message related to i2c_algo_pcf was seen in dmesg but also no failures.
*Module loading and unloading successful.
*No PCF8584 Hardware was available

Cezar Chiru (3):
i2c: pcf8584: Move 'ret' variable inside for loop, goto out if ret <

    0.

i2c: pcf8584: Make pcf_doAddress() function void
i2c: pcf8584: Change pcf_doAdress() to pcf_send_address()

 drivers/i2c/algos/i2c-algo-pcf.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

--
2.43.0